From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id F070A385781A; Mon, 22 Mar 2021 22:04:18 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F070A385781A
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/96749] [coroutines] unexpected 'warning: statement has no
 effect [-Wunused-value]'
Date: Mon, 22 Mar 2021 22:04:18 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: iains at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 10.3
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-96749-4-p2kIplL5ku@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-96749-4@http.gcc.gnu.org/bugzilla/>
References: <bug-96749-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Mar 2021 22:04:19 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D96749

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:8fba8178ac49493ed7998fb9008810aac8138c19

commit r10-9515-g8fba8178ac49493ed7998fb9008810aac8138c19
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Tue Mar 2 10:12:58 2021 +0000

    coroutines : Avoid generating empty statements [PR96749].

    In the compiler-only idiom:
    " a =3D (target expr creats temp, op uses temp) "
    the target expression variable needs to be promoted to a frame one
    (if the expression has a suspend point).  However, the only uses of
    the var are in the second part of the compound expression - and we
    were creating an empty statement corresponding to the (now unused)
    first arm.  This then produces the spurious warnings noted.

    Fixed by avoiding generation of a separate variable nest for
    isolated target expressions (or similarly isolated co_awaits used
    in a function call).

    gcc/cp/ChangeLog:

            PR c++/96749
            * coroutines.cc (flatten_await_stmt): Allow for the case
            where a target expression variable only has uses in the
            second part of a compound expression.
            (maybe_promote_temps): Avoid emiting empty statements.

    gcc/testsuite/ChangeLog:

            PR c++/96749
            * g++.dg/coroutines/pr96749-1.C: New test.
            * g++.dg/coroutines/pr96749-2.C: New test.

    (cherry picked from commit ed8198461735f9b5b3c2cbe50f9913690ce4b4ca)=