public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/96817] __cxa_guard_acquire unsafe against dynamically loaded pthread Date: Sat, 26 Sep 2020 19:41:22 +0000 [thread overview] Message-ID: <bug-96817-4-1aV1fCgAnJ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-96817-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96817 --- Comment #17 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>: https://gcc.gnu.org/g:e6923541fae5081b646f240d54de2a32e17a0382 commit r11-3484-ge6923541fae5081b646f240d54de2a32e17a0382 Author: Jonathan Wakely <jwakely@redhat.com> Date: Sat Sep 26 20:32:36 2020 +0100 libstdc++: Use __libc_single_threaded to optimise atomics [PR 96817] Glibc 2.32 adds a global variable that says whether the process is single-threaded. We can use this to decide whether to elide atomic operations, as a more precise and reliable indicator than __gthread_active_p. This means that guard variables for statics and reference counting in shared_ptr can use less expensive, non-atomic ops even in processes that are linked to libpthread, as long as no threads have been created yet. It also means that we switch to using atomics if libpthread gets loaded later via dlopen (this still isn't supported in general, for other reasons). We can't use __libc_single_threaded to replace __gthread_active_p everywhere. If we replaced the uses of __gthread_active_p in std::mutex then we would elide the pthread_mutex_lock in the code below, but not the pthread_mutex_unlock: std::mutex m; m.lock(); // pthread_mutex_lock std::thread t([]{}); // __libc_single_threaded = false t.join(); m.unlock(); // pthread_mutex_unlock We need the lock and unlock to use the same "is threading enabled" predicate, and similarly for init/destroy pairs for mutexes and condition variables, so that we don't try to release resources that were never acquired. There are other places that could use __libc_single_threaded, such as _Sp_locker in src/c++11/shared_ptr.cc and locale init functions, but they can be changed later. libstdc++-v3/ChangeLog: PR libstdc++/96817 * include/ext/atomicity.h (__gnu_cxx::__is_single_threaded()): New function wrapping __libc_single_threaded if available. (__exchange_and_add_dispatch, __atomic_add_dispatch): Use it. * libsupc++/guard.cc (__cxa_guard_acquire, __cxa_guard_abort) (__cxa_guard_release): Likewise. * testsuite/18_support/96817.cc: New test.
next prev parent reply other threads:[~2020-09-26 19:41 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-27 12:32 [Bug libstdc++/96817] New: " yshuiv7 at gmail dot com 2020-08-27 12:48 ` [Bug libstdc++/96817] " yshuiv7 at gmail dot com 2020-08-27 12:48 ` redi at gcc dot gnu.org 2020-08-27 12:53 ` yshuiv7 at gmail dot com 2020-08-27 12:58 ` rguenth at gcc dot gnu.org 2020-08-27 13:05 ` yshuiv7 at gmail dot com 2020-08-27 13:06 ` yshuiv7 at gmail dot com 2020-08-27 13:15 ` redi at gcc dot gnu.org 2020-08-27 13:23 ` redi at gcc dot gnu.org 2020-08-27 13:26 ` yshuiv7 at gmail dot com 2020-08-27 13:34 ` redi at gcc dot gnu.org 2020-08-27 14:02 ` redi at gcc dot gnu.org 2020-08-27 14:04 ` redi at gcc dot gnu.org 2020-09-25 18:11 ` redi at gcc dot gnu.org 2020-09-25 19:55 ` redi at gcc dot gnu.org 2020-09-25 20:37 ` yshuiv7 at gmail dot com 2020-09-25 20:40 ` yshuiv7 at gmail dot com 2020-09-26 19:41 ` cvs-commit at gcc dot gnu.org [this message] 2020-10-25 9:27 ` rimvydas.jas at gmail dot com 2020-10-25 22:08 ` redi at gcc dot gnu.org 2020-11-04 15:34 ` cvs-commit at gcc dot gnu.org 2020-11-04 15:36 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-96817-4-1aV1fCgAnJ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).