public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/96830] GCC does not complain about redeclaration with inconsistent requires clause
Date: Thu, 27 Apr 2023 23:04:09 +0000 [thread overview]
Message-ID: <bug-96830-4-BwRPo45MLF@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-96830-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96830
--- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:3cf551240fcbc7a5e0f5ba07a9164e237e6c097b
commit r10-11316-g3cf551240fcbc7a5e0f5ba07a9164e237e6c097b
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Wed Jul 20 12:49:28 2022 +0100
libstdc++: Fix minor bugs in std::common_iterator
The noexcept-specifier for some std::common_iterator constructors was
incorrectly using an rvalue as the first argument of
std::is_nothrow_assignable_v. This gave the wrong answer for some types,
e.g. std::common_iterator<int*, S>, because an rvalue of scalar type
cannot be assigned to.
Also fix the friend declaration to use the same constraints as on the
definition of the class template. G++ fails to diagnose this error, due
to PR c++/96830.
Finally, the copy constructor was using std::move for its argument
in some cases, which should be removed.
libstdc++-v3/ChangeLog:
* include/bits/stl_iterator.h (common_iterator): Fix incorrect
uses of is_nothrow_assignable_v. Fix inconsistent constraints on
friend declaration. Do not move argument in copy constructor.
* testsuite/24_iterators/common_iterator/1.cc: Check for
noexcept constructibnle/assignable.
(cherry picked from commit 3b5567c3ec7e5759bdecc6a6fc0be2b65a93636e)
prev parent reply other threads:[~2023-04-27 23:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 8:39 [Bug c++/96830] New: GCC does not complain template-head containing " p.hyundeok76 at gmail dot com
2020-08-28 11:13 ` [Bug c++/96830] " redi at gcc dot gnu.org
2020-08-28 11:24 ` redi at gcc dot gnu.org
2020-08-28 11:26 ` redi at gcc dot gnu.org
2022-07-20 9:54 ` redi at gcc dot gnu.org
2022-07-20 22:59 ` [Bug c++/96830] GCC does not complain about redeclaration with inconsistent " cvs-commit at gcc dot gnu.org
2022-07-21 11:17 ` cvs-commit at gcc dot gnu.org
2022-07-22 7:07 ` cvs-commit at gcc dot gnu.org
2022-10-02 6:59 ` oschonrock at gmail dot com
2022-10-02 18:43 ` redi at gcc dot gnu.org
2022-10-02 18:46 ` redi at gcc dot gnu.org
2022-10-03 13:58 ` redi at gcc dot gnu.org
2022-10-31 16:57 ` ppalka at gcc dot gnu.org
2023-03-13 20:40 ` ppalka at gcc dot gnu.org
2023-03-14 23:18 ` cvs-commit at gcc dot gnu.org
2023-03-14 23:18 ` cvs-commit at gcc dot gnu.org
2023-03-14 23:28 ` ppalka at gcc dot gnu.org
2023-04-27 23:04 ` cvs-commit at gcc dot gnu.org [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-96830-4-BwRPo45MLF@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).