public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rsandifo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/96974] [10/11 Regression] ICE in vect_get_vector_types_for_stmt compiling for SVE
Date: Thu, 28 Jan 2021 11:59:17 +0000	[thread overview]
Message-ID: <bug-96974-4-BJr8a0cx7R@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-96974-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96974

--- Comment #9 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
(In reply to Stam Markianos-Wright from comment #8)
> I have a liiitle bit more progress here, but I have a question about
> vect_get_smallest_scalar_type.
> 
> If we look at the comment before the function:
> 
> >/* Return the smallest scalar part of STMT_INFO.
> >   This is used to determine the vectype of the stmt.  We generally set the
> >   vectype according to the type of the result (lhs).  For stmts whose
> >   result-type is different than the type of the arguments (e.g., demotion,
> >   promotion), vectype will be reset appropriately (later).  Note that we have
> >   to visit the smallest datatype in this function, because that determines the
> >   VF.  If the smallest datatype in the loop is present only as the rhs of a
> >   promotion operation - we'd miss it.
> 
> Would this be "smallest datatype in all cases", or is this more like "the
> smallest
> datatype within the same promotion/demotion chain"?
> 
> i.e. how should we react if we detect a smallest datatype on the rhs of
> "float"
> when everything else in the stmt has been in the integer chain (int or,
> like in this case, long int)?
Not sure if this is really answering the question (let me know if it's not),
but: for an lhs of int and an rhs of float, the choice doesn't really matter,
since they're the same size.  But for an lhs of long int and an rhs of float,
the smallest vectype has to be taken from the float.

  parent reply	other threads:[~2021-01-28 11:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08 11:20 [Bug tree-optimization/96974] New: " ktkachov at gcc dot gnu.org
2020-09-08 11:21 ` [Bug tree-optimization/96974] " ktkachov at gcc dot gnu.org
2020-09-08 13:03 ` rguenth at gcc dot gnu.org
2020-10-15 15:36 ` stammark at gcc dot gnu.org
2021-01-05 10:09 ` ktkachov at gcc dot gnu.org
2021-01-18 10:29 ` stammark at gcc dot gnu.org
2021-01-18 10:38 ` rsandifo at gcc dot gnu.org
2021-01-18 13:32 ` stammark at gcc dot gnu.org
2021-01-18 13:48 ` rsandifo at gcc dot gnu.org
2021-01-18 13:52 ` stammark at gcc dot gnu.org
2021-01-28 11:47 ` stammark at gcc dot gnu.org
2021-01-28 11:47 ` stammark at gcc dot gnu.org
2021-01-28 11:59 ` rsandifo at gcc dot gnu.org [this message]
2021-01-28 13:12 ` rguenth at gcc dot gnu.org
2021-03-25 15:30 ` cvs-commit at gcc dot gnu.org
2021-03-25 15:32 ` cvs-commit at gcc dot gnu.org
2021-03-31  9:42 ` ktkachov at gcc dot gnu.org
2021-03-31  9:54 ` rguenth at gcc dot gnu.org
2021-03-31 13:57 ` cvs-commit at gcc dot gnu.org
2021-03-31 13:59 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-96974-4-BJr8a0cx7R@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).