public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/97009] [9/10/11 Regression] Inlining with non-standard selected_int_kind leads to errors
Date: Thu, 01 Apr 2021 09:51:22 +0000 [thread overview]
Message-ID: <bug-97009-4-bHoM4XQuxj@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-97009-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97009
--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Martin Jambor
<jamborm@gcc.gnu.org>:
https://gcc.gnu.org/g:368875572b6b6be75d7cc162797d07e779194fb1
commit r10-9650-g368875572b6b6be75d7cc162797d07e779194fb1
Author: Martin Jambor <mjambor@suse.cz>
Date: Thu Apr 1 10:12:23 2021 +0200
sra: Fix bug in grp_write propagation (PR 97009)
SRA represents parts of aggregates which are arrays accessed with
unknown index as "unscalarizable regions." When there are two such
regions one within another and the outer is only read whereas the
inner is written to, SRA fails to propagate that write information
across assignments. This means that a second aggregate can contain
data while SRA thinks it does not and the pass can wrongly eliminate
big chunks of assignment from that second aggregate into a third
aggregate, which is what happens in PR 97009.
Fixed by checking all children of unscalariable accesses for the
grp_write flag.
gcc/ChangeLog:
2021-03-31 Martin Jambor <mjambor@suse.cz>
PR tree-optimization/97009
* tree-sra.c (access_or_its_child_written): New function.
(propagate_subaccesses_from_rhs): Use it instead of a simple
grp_write
test.
gcc/testsuite/ChangeLog:
2021-03-31 Martin Jambor <mjambor@suse.cz>
PR tree-optimization/97009
* gcc.dg/tree-ssa/pr97009.c: New test.
(cherry picked from commit 19d71674616e6494a60432a2a28adcd762a6c877)
next prev parent reply other threads:[~2021-04-01 9:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 11:32 [Bug fortran/97009] New: " pvitt at posteo dot de
2020-09-10 11:33 ` [Bug fortran/97009] " pvitt at posteo dot de
2020-09-10 18:57 ` [Bug fortran/97009] [9/10/11 Regression] " anlauf at gcc dot gnu.org
2020-09-10 20:20 ` [Bug tree-optimization/97009] " anlauf at gcc dot gnu.org
2020-09-11 18:17 ` anlauf at gcc dot gnu.org
2020-10-12 12:10 ` rguenth at gcc dot gnu.org
2021-03-31 20:26 ` jamborm at gcc dot gnu.org
2021-03-31 20:28 ` jamborm at gcc dot gnu.org
2021-03-31 21:32 ` jamborm at gcc dot gnu.org
2021-04-01 8:12 ` cvs-commit at gcc dot gnu.org
2021-04-01 9:51 ` cvs-commit at gcc dot gnu.org [this message]
2021-04-01 13:38 ` [Bug tree-optimization/97009] [9 " jamborm at gcc dot gnu.org
2021-04-08 16:58 ` cvs-commit at gcc dot gnu.org
2021-04-08 16:58 ` jamborm at gcc dot gnu.org
2024-03-27 5:00 ` pinskia at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-97009-4-bHoM4XQuxj@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).