[Bug bootstrap/97105] New: [11 regression] dumpfile.c:169:33: error: storage size of 'optgroup_options' isn't known

[Bug bootstrap/97105] New: [11 regression] dumpfile.c:169:33: error: storage size of 'optgroup_options' isn't known

[dimhen at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97105

            Bug ID: 97105
           Summary: [11 regression] dumpfile.c:169:33: error: storage size
                    of 'optgroup_options' isn't known
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dimhen at gmail dot com
  Target Milestone: ---

r11-3264 PASS
r11-3279 FAIL

$ configure --enable-checking=release --enable-languages=c,c++,lto
--disable-multilib --enable-shared
$ make -j5
[...]

make[3]: Entering directory '/home/dimhen/build/gcc_current/gcc'
/home/dimhen/build/gcc_current/./prev-gcc/xg++
-B/home/dimhen/build/gcc_current/./prev-gcc/
-B/home/dimhen/arch-gcc/gcc_current/x86_64-pc-linux-gnu/bin/ -nostdinc++
-B/home/dimhen/build/gcc_current/prev-x86_64-pc-linux-gnu/libstdc++-v3/src/.libs
-B/home/dimhen/build/gcc_current/prev-x86_64-pc-linux-gnu/libstdc++-v3/libsupc++/.libs

-I/home/dimhen/build/gcc_current/prev-x86_64-pc-linux-gnu/libstdc++-v3/include/x86_64-pc-linux-gnu
 -I/home/dimhen/build/gcc_current/prev-x86_64-pc-linux-gnu/libstdc++-v3/include
 -I/home/dimhen/src/gcc_current/libstdc++-v3/libsupc++
-L/home/dimhen/build/gcc_current/prev-x86_64-pc-linux-gnu/libstdc++-v3/src/.libs
-L/home/dimhen/build/gcc_current/prev-x86_64-pc-linux-gnu/libstdc++-v3/libsupc++/.libs
 -fno-PIE -c   -g -O2 -fno-checking -gtoggle -DIN_GCC     -fno-exceptions
-fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wno-error=format-diag -Wmissing-format-attribute
-Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros
-Wno-overlength-strings -Werror   -DHAVE_CONFIG_H -I. -I.
-I/home/dimhen/src/gcc_current/gcc -I/home/dimhen/src/gcc_current/gcc/.
-I/home/dimhen/src/gcc_current/gcc/../include
-I/home/dimhen/src/gcc_current/gcc/../libcpp/include
-I/home/dimhen/build/gcc_current/./gmp -I/home/dimhen/src/gcc_current/gmp
-I/home/dimhen/build/gcc_current/./mpfr/src
-I/home/dimhen/src/gcc_current/mpfr/src -I/home/dimhen/src/gcc_current/mpc/src 
-I/home/dimhen/src/gcc_current/gcc/../libdecnumber
-I/home/dimhen/src/gcc_current/gcc/../libdecnumber/bid -I../libdecnumber
-I/home/dimhen/src/gcc_current/gcc/../libbacktrace
-I/home/dimhen/build/gcc_current/./isl/include
-I/home/dimhen/src/gcc_current/isl/include  -o dumpfile.o -MT dumpfile.o -MMD
-MP -MF ./.deps/dumpfile.TPo /home/dimhen/src/gcc_current/gcc/dumpfile.c
/home/dimhen/src/gcc_current/gcc/coretypes.h: In instantiation of 'struct
kv_pair<optgroup_flag>':
/home/dimhen/src/gcc_current/gcc/dumpfile.c:169:50:   required from here
/home/dimhen/src/gcc_current/gcc/dumpfile.c:169:33: error: storage size of
'optgroup_options' isn't known
  169 | const kv_pair<optgroup_flags_t> optgroup_options[] =
      |                                 ^~~~~~~~~~~~~~~~
/home/dimhen/src/gcc_current/gcc/dumpfile.c: In function 'void
dump_loc(dump_flags_t, pretty_printer*, location_t)':
/home/dimhen/src/gcc_current/gcc/dumpfile.c:498:34: warning: spurious trailing
space in format [-Wformat-diag]
  498 |         pp_printf (pp, "%s:%d:%d: ", LOCATION_FILE (loc),
      |                                  ^
/home/dimhen/src/gcc_current/gcc/dumpfile.c:501:34: warning: spurious trailing
space in format [-Wformat-diag]
  501 |         pp_printf (pp, "%s:%d:%d: ",
      |                                  ^
/home/dimhen/src/gcc_current/gcc/dumpfile.c:505:26: warning: spurious trailing
space in format [-Wformat-diag]
  505 |       pp_printf (pp, "%s: ", kind_as_string (dump_kind));
      |                          ^
/home/dimhen/src/gcc_current/gcc/dumpfile.c: In member function 'void
dump_context::begin_scope(const char*, const dump_user_location_t&, const
dump_impl_location_t&)':
/home/dimhen/src/gcc_current/gcc/dumpfile.c:1122:20: warning: spurious leading
punctuation sequence '===' in format [-Wformat-diag]
 1122 |   pp_printf (&pp, "=== %s ===\n", name);
      |                    ^~~
/home/dimhen/src/gcc_current/gcc/dumpfile.c:1122:27: warning: unquoted sequence
of 3 consecutive punctuation characters '===' in format [-Wformat-diag]
 1122 |   pp_printf (&pp, "=== %s ===\n", name);
      |                           ^~~
/home/dimhen/src/gcc_current/gcc/dumpfile.c:1122:30: warning: unquoted
whitespace character '\x0a' in format [-Wformat-diag]
 1122 |   pp_printf (&pp, "=== %s ===\n", name);
      |                              ^~
make[3]: *** [Makefile:1123: dumpfile.o] Error 1
make[3]: Leaving directory '/home/dimhen/build/gcc_current/gcc'
make[2]: *** [Makefile:4793: all-stage2-gcc] Error 2
make[2]: Leaving directory '/home/dimhen/build/gcc_current'
make[1]: *** [Makefile:27160: stage2-bubble] Error 2
make[1]: Leaving directory '/home/dimhen/build/gcc_current'

[Bug bootstrap/97105] [11 regression] dumpfile.c:169:33: error: storage size of 'optgroup_options' isn't known

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97105

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |jason at gcc dot gnu.org
   Target Milestone|---                         |11.0
           Keywords|                            |build
   Last reconfirmed|                            |2020-09-18
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed, caused by g:f627125855075f7ffde74e48481ee961f0bc4c7b

[Bug bootstrap/97105] [11 regression] dumpfile.c:169:33: error: storage size of 'optgroup_options' isn't known

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97105

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug bootstrap/97105] [11 regression] dumpfile.c:169:33: error: storage size of 'optgroup_options' isn't known

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97105

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl.tools at gmail dot com

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
*** Bug 97118 has been marked as a duplicate of this bug. ***

[Bug bootstrap/97105] [11 regression] dumpfile.c:169:33: error: storage size of 'optgroup_options' isn't known

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97105

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Reduced testcase:
template <int> struct A {};
extern const A<0> a[];
const A<0> a[] = {};

[Bug bootstrap/97105] [11 regression] dumpfile.c:169:33: error: storage size of 'optgroup_options' isn't known

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97105

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
>From what I can see, when doing pushdecl of the extern a declaration the
VAR_DECL is pushed into incomplete_vars, then when seeing the definition
pushdecl is called again and during duplicate_decls it is turned into no longer
DECL_EXTERNAL, but the type hasn't been instantiated yet.  Then start_decl
calls start_decl_1 which calls complete_decl and that sees an incomplete type
that can't be completed and errors.
One way out of this might be not call layout_var_decl if !COMPLETE_TYPE_P
(type).
Another one might be to let start_decl_1 record in some global variable that it
is processing (if it is) a variable with [] array and let complete_vars skip
that var.

[Bug bootstrap/97105] [11 regression] dumpfile.c:169:33: error: storage size of 'optgroup_options' isn't known

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97105

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Ah, Jason has committed a fix already, against the other PR.  I'll commit the
testcase and close this PR.

[Bug bootstrap/97105] [11 regression] dumpfile.c:169:33: error: storage size of 'optgroup_options' isn't known

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97105

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:4a5ff2b56bfea0b3e154a15e809c5c42dc3b9e9f

commit r11-3292-g4a5ff2b56bfea0b3e154a15e809c5c42dc3b9e9f
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Sep 19 00:09:11 2020 +0200

    c++: Add testcase for already fixed PR97105

    This has been fixed by the PR bootstrap/97118 fix.

    2020-09-19  Jakub Jelinek  <jakub@redhat.com>

            PR c++/97105
            * g++.dg/template/pr97105.C: New test.

[Bug bootstrap/97105] [11 regression] dumpfile.c:169:33: error: storage size of 'optgroup_options' isn't known

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97105

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed by the PR97118 fix.