public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/97150] New: [AArch64] 2nd parameter of unsigned Neon scalar shift intrinsics should be signed
@ 2020-09-21 14:44 david.spickett at linaro dot org
  2020-09-21 14:45 ` [Bug target/97150] " david.spickett at linaro dot org
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: david.spickett at linaro dot org @ 2020-09-21 14:44 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97150

            Bug ID: 97150
           Summary: [AArch64] 2nd parameter of unsigned Neon scalar shift
                    intrinsics should be signed
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: david.spickett at linaro dot org
  Target Milestone: ---

The attached test file assigns the following intrinsics to function pointers to
check the argument and return types:
vqshlb_u8 vqshlh_u16 vqshls_u32 vqshld_u64
vqrshlb_u8 vqrshlh_u16 vqrshls_u32 vqrshld_u64
vshld_u64

(for quick reference)
https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vqshlb_u8
https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vqshlh_u16
https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vqshls_u32
https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vqshld_u64
https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vqrshlb_u8
https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vqrshlh_u16
https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vqrshls_u32
https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vqrshld_u64
https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vshld_u64
https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vrshld_u64

The types in the function pointer declaration are taken from the ACLE, so I'd
expect this to compile without issue. Except that the second parameter for
these intrinsics is not signed as it should be.

gcc version: 11.0.0
System: Ubuntu 16.04.7 LTS on x86_64
gcc options:
Configured with:
/tmp/dgboter/bbs/rhev-vm4--rhe6x86_64/buildbot/rhe6x86_64--aarch64-none-elf/build/src/gcc/configure
--target=aarch64-none-elf
--prefix=/tmp/dgboter/bbs/rhev-vm4--rhe6x86_64/buildbot/rhe6x86_64--aarch64-none-elf/build/build-aarch64-none-elf/install//
--with-gmp=/tmp/dgboter/bbs/rhev-vm4--rhe6x86_64/buildbot/rhe6x86_64--aarch64-none-elf/build/build-aarch64-none-elf/host-tools
--with-mpfr=/tmp/dgboter/bbs/rhev-vm4--rhe6x86_64/buildbot/rhe6x86_64--aarch64-none-elf/build/build-aarch64-none-elf/host-tools
--with-mpc=/tmp/dgboter/bbs/rhev-vm4--rhe6x86_64/buildbot/rhe6x86_64--aarch64-none-elf/build/build-aarch64-none-elf/host-tools
--with-isl=/tmp/dgboter/bbs/rhev-vm4--rhe6x86_64/buildbot/rhe6x86_64--aarch64-none-elf/build/build-aarch64-none-elf/host-tools
--disable-shared --disable-nls --disable-threads --disable-tls
--enable-checking=yes --enable-languages=c,c++,fortran --with-newlib
--with-pkgversion=fsf-trunk.2226

Command line to reproduce and output:
$ ./aarch64-none-elf-gcc -march=armv8-a+simd -c -o /dev/null /tmp/test.c -Wall
-Wextra
/tmp/test.c:3:38: warning: initialization of 'uint8_t (*)(uint8_t,  int8_t)'
{aka 'unsigned char (*)(unsigned char,  signed char)'} from incompatible
pointer type 'uint8_t (*)(uint8_t,  uint8_t)' {aka 'unsigned char (*)(unsigned
char,  unsigned char)'} [-Wincompatible-pointer-types]
    3 | uint8_t  (*fp0)(uint8_t, int8_t)   = vqshlb_u8;
      |                                      ^~~~~~~~~
/tmp/test.c:4:38: warning: initialization of 'uint16_t (*)(uint16_t,  int16_t)'
{aka 'short unsigned int (*)(short unsigned int,  short int)'} from
incompatible pointer type 'uint16_t (*)(uint16_t,  uint16_t)' {aka 'short
unsigned int (*)(short unsigned int,  short unsigned int)'}
[-Wincompatible-pointer-types]
    4 | uint16_t (*fp1)(uint16_t, int16_t) = vqshlh_u16;
      |                                      ^~~~~~~~~~
/tmp/test.c:5:38: warning: initialization of 'uint32_t (*)(uint32_t,  int32_t)'
{aka 'unsigned int (*)(unsigned int,  int)'} from incompatible pointer type
'uint32_t (*)(uint32_t,  uint32_t)' {aka 'unsigned int (*)(unsigned int, 
unsigned int)'} [-Wincompatible-pointer-types]
    5 | uint32_t (*fp2)(uint32_t, int32_t) = vqshls_u32;
      |                                      ^~~~~~~~~~
/tmp/test.c:6:38: warning: initialization of 'uint64_t (*)(uint64_t,  int64_t)'
{aka 'long unsigned int (*)(long unsigned int,  long int)'} from incompatible
pointer type 'uint64_t (*)(uint64_t,  uint64_t)' {aka 'long unsigned int
(*)(long unsigned int,  long unsigned int)'} [-Wincompatible-pointer-types]
    6 | uint64_t (*fp3)(uint64_t, int64_t) = vqshld_u64;
      |                                      ^~~~~~~~~~
/tmp/test.c:7:38: warning: initialization of 'uint8_t (*)(uint8_t,  int8_t)'
{aka 'unsigned char (*)(unsigned char,  signed char)'} from incompatible
pointer type 'uint8_t (*)(uint8_t,  uint8_t)' {aka 'unsigned char (*)(unsigned
char,  unsigned char)'} [-Wincompatible-pointer-types]
    7 | uint8_t  (*fp4)(uint8_t, int8_t)   = vqrshlb_u8;
      |                                      ^~~~~~~~~~
/tmp/test.c:8:38: warning: initialization of 'uint16_t (*)(uint16_t,  int16_t)'
{aka 'short unsigned int (*)(short unsigned int,  short int)'} from
incompatible pointer type 'uint16_t (*)(uint16_t,  uint16_t)' {aka 'short
unsigned int (*)(short unsigned int,  short unsigned int)'}
[-Wincompatible-pointer-types]
    8 | uint16_t (*fp5)(uint16_t, int16_t) = vqrshlh_u16;
      |                                      ^~~~~~~~~~~
/tmp/test.c:9:38: warning: initialization of 'uint32_t (*)(uint32_t,  int32_t)'
{aka 'unsigned int (*)(unsigned int,  int)'} from incompatible pointer type
'uint32_t (*)(uint32_t,  uint32_t)' {aka 'unsigned int (*)(unsigned int, 
unsigned int)'} [-Wincompatible-pointer-types]
    9 | uint32_t (*fp6)(uint32_t, int32_t) = vqrshls_u32;
      |                                      ^~~~~~~~~~~
/tmp/test.c:10:38: warning: initialization of 'uint64_t (*)(uint64_t, 
int64_t)' {aka 'long unsigned int (*)(long unsigned int,  long int)'} from
incompatible pointer type 'uint64_t (*)(uint64_t,  uint64_t)' {aka 'long
unsigned int (*)(long unsigned int,  long unsigned int)'}
[-Wincompatible-pointer-types]
   10 | uint64_t (*fp7)(uint64_t, int64_t) = vqrshld_u64;
      |                                      ^~~~~~~~~~~
/tmp/test.c:11:38: warning: initialization of 'uint64_t (*)(uint64_t, 
int64_t)' {aka 'long unsigned int (*)(long unsigned int,  long int)'} from
incompatible pointer type 'uint64_t (*)(uint64_t,  uint64_t)' {aka 'long
unsigned int (*)(long unsigned int,  long unsigned int)'}
[-Wincompatible-pointer-types]
   11 | uint64_t (*fp8)(uint64_t, int64_t) = vshld_u64;
      |                                      ^~~~~~~~~

For what it's worth this also fails to compile with "gcc version 5.4.0 20160609
(Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9)". (so it isn't a new change)

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-10-08 17:24 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 14:44 [Bug target/97150] New: [AArch64] 2nd parameter of unsigned Neon scalar shift intrinsics should be signed david.spickett at linaro dot org
2020-09-21 14:45 ` [Bug target/97150] " david.spickett at linaro dot org
2020-09-21 14:49 ` david.spickett at linaro dot org
2020-09-30 11:03 ` cvs-commit at gcc dot gnu.org
2020-09-30 11:08 ` ktkachov at gcc dot gnu.org
2020-10-08 15:00 ` cvs-commit at gcc dot gnu.org
2020-10-08 16:10 ` cvs-commit at gcc dot gnu.org
2020-10-08 17:22 ` cvs-commit at gcc dot gnu.org
2020-10-08 17:24 ` ktkachov at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).