public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/97184] New: Incorrect MOVDIRI and MOVDIR64B patterns
@ 2020-09-23 19:07 hjl.tools at gmail dot com
  2020-09-27 13:23 ` [Bug target/97184] " hjl.tools at gmail dot com
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: hjl.tools at gmail dot com @ 2020-09-23 19:07 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97184

            Bug ID: 97184
           Summary: Incorrect MOVDIRI and MOVDIR64B patterns
           Product: gcc
           Version: 8.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hjl.tools at gmail dot com
                CC: crazylht at gmail dot com, wwwhhhyyy333 at gmail dot com
  Target Milestone: ---
            Target: i386,x86-64

MOVDIRI and MOVDIR64B update memory.  But there is not SET operation:

;; MOVDIRI and MOVDIR64B

(define_insn "movdiri<mode>"
  [(unspec_volatile:SWI48 [(match_operand:SWI48 0 "memory_operand" "m")
                           (match_operand:SWI48 1 "register_operand" "r")]
                          UNSPECV_MOVDIRI)]
  "TARGET_MOVDIRI"
  "movdiri\t{%1, %0|%0, %1}"
  [(set_attr "type" "other")])

(define_insn "@movdir64b_<mode>"
  [(unspec_volatile:XI [(match_operand:P 0 "register_operand" "r")
                        (match_operand:XI 1 "memory_operand")]
                       UNSPECV_MOVDIR64B)]
  "TARGET_MOVDIR64B"
  "movdir64b\t{%1, %0|%0, %1}"
  [(set_attr "type" "other")])

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug target/97184] Incorrect MOVDIRI and MOVDIR64B patterns
  2020-09-23 19:07 [Bug target/97184] New: Incorrect MOVDIRI and MOVDIR64B patterns hjl.tools at gmail dot com
@ 2020-09-27 13:23 ` hjl.tools at gmail dot com
  2020-09-30 12:35 ` cvs-commit at gcc dot gnu.org
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: hjl.tools at gmail dot com @ 2020-09-27 13:23 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97184

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2020-Septemb
                   |                            |er/554933.html
           Keywords|                            |patch
   Target Milestone|---                         |11.0
   Last reconfirmed|                            |2020-09-27
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
A patch is posted at

https://gcc.gnu.org/pipermail/gcc-patches/2020-September/554933.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug target/97184] Incorrect MOVDIRI and MOVDIR64B patterns
  2020-09-23 19:07 [Bug target/97184] New: Incorrect MOVDIRI and MOVDIR64B patterns hjl.tools at gmail dot com
  2020-09-27 13:23 ` [Bug target/97184] " hjl.tools at gmail dot com
@ 2020-09-30 12:35 ` cvs-commit at gcc dot gnu.org
  2020-09-30 12:45 ` cvs-commit at gcc dot gnu.org
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-09-30 12:35 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97184

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:46183c96d2aea8181efb6bc3cfdb221987fe002d

commit r11-3552-g46183c96d2aea8181efb6bc3cfdb221987fe002d
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Sep 23 12:11:45 2020 -0700

    x86: Use SET operation in MOVDIRI and MOVDIR64B

    Since MOVDIRI and MOVDIR64B write to memory, similar to UNSPEC_MOVNT,
    use SET operation in MOVDIRI and MOVDIR64B patterns with UNSPEC instead
    of UNSPECV.

    gcc/

            PR target/97184
            * config/i386/i386.md (UNSPECV_MOVDIRI): Renamed to ...
            (UNSPEC_MOVDIRI): This.
            (UNSPECV_MOVDIR64B): Renamed to ...
            (UNSPEC_MOVDIR64B): This.
            (movdiri<mode>): Use SET operation.
            (@movdir64b_<mode>): Likewise.

    gcc/testsuite/

            PR target/97184
            * gcc.target/i386/movdir64b.c: New test.
            * gcc.target/i386/movdiri32.c: Likewise.
            * gcc.target/i386/movdiri64.c: Likewise.
            * lib/target-supports.exp (check_effective_target_movdir): New.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug target/97184] Incorrect MOVDIRI and MOVDIR64B patterns
  2020-09-23 19:07 [Bug target/97184] New: Incorrect MOVDIRI and MOVDIR64B patterns hjl.tools at gmail dot com
  2020-09-27 13:23 ` [Bug target/97184] " hjl.tools at gmail dot com
  2020-09-30 12:35 ` cvs-commit at gcc dot gnu.org
@ 2020-09-30 12:45 ` cvs-commit at gcc dot gnu.org
  2020-09-30 12:51 ` cvs-commit at gcc dot gnu.org
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-09-30 12:45 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97184

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:021c792a36143f3aaaf27efc7190c6e59b56f084

commit r10-8829-g021c792a36143f3aaaf27efc7190c6e59b56f084
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Sep 23 12:11:45 2020 -0700

    x86: Use SET operation in MOVDIRI and MOVDIR64B

    Since MOVDIRI and MOVDIR64B write to memory, similar to UNSPEC_MOVNT,
    use SET operation in MOVDIRI and MOVDIR64B patterns with UNSPEC instead
    of UNSPECV.

    gcc/

            PR target/97184
            * config/i386/i386.md (UNSPECV_MOVDIRI): Renamed to ...
            (UNSPEC_MOVDIRI): This.
            (UNSPECV_MOVDIR64B): Renamed to ...
            (UNSPEC_MOVDIR64B): This.
            (movdiri<mode>): Use SET operation.
            (@movdir64b_<mode>): Likewise.

    gcc/testsuite/

            PR target/97184
            * gcc.target/i386/movdir64b.c: New test.
            * gcc.target/i386/movdiri32.c: Likewise.
            * gcc.target/i386/movdiri64.c: Likewise.
            * lib/target-supports.exp (check_effective_target_movdir): New.

    (cherry picked from commit 5521e8a629f8bee3a7778d69521d857496556d1f)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug target/97184] Incorrect MOVDIRI and MOVDIR64B patterns
  2020-09-23 19:07 [Bug target/97184] New: Incorrect MOVDIRI and MOVDIR64B patterns hjl.tools at gmail dot com
                   ` (2 preceding siblings ...)
  2020-09-30 12:45 ` cvs-commit at gcc dot gnu.org
@ 2020-09-30 12:51 ` cvs-commit at gcc dot gnu.org
  2020-09-30 12:57 ` cvs-commit at gcc dot gnu.org
  2020-09-30 13:00 ` hjl.tools at gmail dot com
  5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-09-30 12:51 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97184

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:cbe1264d10f34d514cae5f002e0d717bbc8d32a3

commit r9-8959-gcbe1264d10f34d514cae5f002e0d717bbc8d32a3
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Sep 23 12:11:45 2020 -0700

    x86: Use SET operation in MOVDIRI and MOVDIR64B

    Since MOVDIRI and MOVDIR64B write to memory, similar to UNSPEC_MOVNT,
    use SET operation in MOVDIRI and MOVDIR64B patterns with UNSPEC instead
    of UNSPECV.

    gcc/

            PR target/97184
            * config/i386/i386.md (UNSPECV_MOVDIRI): Renamed to ...
            (UNSPEC_MOVDIRI): This.
            (UNSPECV_MOVDIR64B): Renamed to ...
            (UNSPEC_MOVDIR64B): This.
            (movdiri<mode>): Use SET operation.
            (@movdir64b_<mode>): Likewise.

    gcc/testsuite/

            PR target/97184
            * gcc.target/i386/movdir64b.c: New test.
            * gcc.target/i386/movdiri32.c: Likewise.
            * gcc.target/i386/movdiri64.c: Likewise.
            * lib/target-supports.exp (check_effective_target_movdir): New.

    (cherry picked from commit 5521e8a629f8bee3a7778d69521d857496556d1f)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug target/97184] Incorrect MOVDIRI and MOVDIR64B patterns
  2020-09-23 19:07 [Bug target/97184] New: Incorrect MOVDIRI and MOVDIR64B patterns hjl.tools at gmail dot com
                   ` (3 preceding siblings ...)
  2020-09-30 12:51 ` cvs-commit at gcc dot gnu.org
@ 2020-09-30 12:57 ` cvs-commit at gcc dot gnu.org
  2020-09-30 13:00 ` hjl.tools at gmail dot com
  5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-09-30 12:57 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97184

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:b0e6f198547d423b24520c13e3c29f3712026fce

commit r8-10556-gb0e6f198547d423b24520c13e3c29f3712026fce
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Sep 23 12:11:45 2020 -0700

    x86: Use SET operation in MOVDIRI and MOVDIR64B

    Since MOVDIRI and MOVDIR64B write to memory, similar to UNSPEC_MOVNT,
    use SET operation in MOVDIRI and MOVDIR64B patterns with UNSPEC instead
    of UNSPECV.

    gcc/

            PR target/97184
            * config/i386/i386.md (UNSPECV_MOVDIRI): Renamed to ...
            (UNSPEC_MOVDIRI): This.
            (UNSPECV_MOVDIR64B): Renamed to ...
            (UNSPEC_MOVDIR64B): This.
            (movdiri<mode>): Use SET operation.
            (@movdir64b_<mode>): Likewise.

    gcc/testsuite/

            PR target/97184
            * gcc.target/i386/movdir64b.c: New test.
            * gcc.target/i386/movdiri32.c: Likewise.
            * gcc.target/i386/movdiri64.c: Likewise.
            * lib/target-supports.exp (check_effective_target_movdir): New.

    (cherry picked from commit 5521e8a629f8bee3a7778d69521d857496556d1f)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug target/97184] Incorrect MOVDIRI and MOVDIR64B patterns
  2020-09-23 19:07 [Bug target/97184] New: Incorrect MOVDIRI and MOVDIR64B patterns hjl.tools at gmail dot com
                   ` (4 preceding siblings ...)
  2020-09-30 12:57 ` cvs-commit at gcc dot gnu.org
@ 2020-09-30 13:00 ` hjl.tools at gmail dot com
  5 siblings, 0 replies; 7+ messages in thread
From: hjl.tools at gmail dot com @ 2020-09-30 13:00 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97184

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|11.0                        |8.5
             Status|NEW                         |RESOLVED

--- Comment #6 from H.J. Lu <hjl.tools at gmail dot com> ---
Fix for GCC 8.5, GCC 9.4, GCC 10.3 and GCC 11.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-09-30 13:00 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23 19:07 [Bug target/97184] New: Incorrect MOVDIRI and MOVDIR64B patterns hjl.tools at gmail dot com
2020-09-27 13:23 ` [Bug target/97184] " hjl.tools at gmail dot com
2020-09-30 12:35 ` cvs-commit at gcc dot gnu.org
2020-09-30 12:45 ` cvs-commit at gcc dot gnu.org
2020-09-30 12:51 ` cvs-commit at gcc dot gnu.org
2020-09-30 12:57 ` cvs-commit at gcc dot gnu.org
2020-09-30 13:00 ` hjl.tools at gmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).