public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/97251] New: [10/11 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE
@ 2020-09-30  7:58 acoplan at gcc dot gnu.org
  2020-09-30  8:05 ` [Bug target/97251] " cvs-commit at gcc dot gnu.org
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: acoplan at gcc dot gnu.org @ 2020-09-30  7:58 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97251

            Bug ID: 97251
           Summary: [10/11 Regression] arm: ICEs compiling
                    pure-code/no-literal-pool.c with integer MVE
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: acoplan at gcc dot gnu.org
  Target Milestone: ---

Since r10-7193-g63c8f7d6a082b1cd0519fe06d4ed506b04280921, GCC ICEs compiling
gcc/testsuite/gcc.target/arm/pure-code/no-literal-pool.c with integer MVE.

To reproduce:

$ arm-eabi-gcc no-literal-pool.c -c -march=armv8.1-m.main+mve
-mfp16-format=ieee -mpure-code -mfloat-abi=hard
no-literal-pool.c: In function 'testsfp16':
no-literal-pool.c:20:1: error: unrecognizable insn:
   20 | }
      | ^
(insn 33 32 34 2 (set (reg:SF 1 r1)
        (const_double:SF 1.1233999729156494140625e+0 [0x0.8fcb92p+1]))
"no-literal-pool.c":16:6 -1
     (nil))
during RTL pass: vregs
no-literal-pool.c:20:1: internal compiler error: in extract_insn, at
recog.c:2294
0xc6c405 _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
        /home/alecop01/toolchain/src/gcc/gcc/rtl-error.c:108
0xc6c424 _fatal_insn_not_found(rtx_def const*, char const*, int, char const*)
        /home/alecop01/toolchain/src/gcc/gcc/rtl-error.c:116
0xc3bf7f extract_insn(rtx_insn*)
        /home/alecop01/toolchain/src/gcc/gcc/recog.c:2294
0x97d49a instantiate_virtual_regs_in_insn
        /home/alecop01/toolchain/src/gcc/gcc/function.c:1607
0x97d49a instantiate_virtual_regs
        /home/alecop01/toolchain/src/gcc/gcc/function.c:1977
0x97d49a execute
        /home/alecop01/toolchain/src/gcc/gcc/function.c:2026
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

I have a patch (already approved) to fix the issue:
https://gcc.gnu.org/pipermail/gcc-patches/2020-September/555069.html, just
opening the bug to track backporting progress.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/97251] [10/11 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE
  2020-09-30  7:58 [Bug target/97251] New: [10/11 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE acoplan at gcc dot gnu.org
@ 2020-09-30  8:05 ` cvs-commit at gcc dot gnu.org
  2020-09-30  8:06 ` acoplan at gcc dot gnu.org
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-09-30  8:05 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97251

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Alex Coplan <acoplan@gcc.gnu.org>:

https://gcc.gnu.org/g:f63023fafbbc13545fef67e6b32a55b48a945fcf

commit r11-3545-gf63023fafbbc13545fef67e6b32a55b48a945fcf
Author: Alex Coplan <alex.coplan@arm.com>
Date:   Wed Sep 30 09:02:47 2020 +0100

    arm: Fix ICEs in no-literal-pool.c on MVE [PR97251]

    This patch fixes ICEs when compiling
    gcc/testsuite/gcc.target/arm/pure-code/no-literal-pool.c with
    -mfp16-format=ieee -mfloat-abi=hard -march=armv8.1-m.main+mve
    -mpure-code.

    The existing conditions in the movsf/movdf expanders (as well as the
    no_literal_pool patterns) were too restrictive, requiring
    TARGET_HARD_FLOAT instead of TARGET_VFP_BASE, which caused unrecognised
    insns when compiling this testcase with integer MVE and -mpure-code.

    gcc/ChangeLog:

            PR target/97251
            * config/arm/arm.md (movsf): Relax TARGET_HARD_FLOAT to
            TARGET_VFP_BASE.
            (movdf): Likewise.
            * config/arm/vfp.md (no_literal_pool_df_immediate): Likewise.
            (no_literal_pool_sf_immediate): Likewise.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/97251] [10/11 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE
  2020-09-30  7:58 [Bug target/97251] New: [10/11 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE acoplan at gcc dot gnu.org
  2020-09-30  8:05 ` [Bug target/97251] " cvs-commit at gcc dot gnu.org
@ 2020-09-30  8:06 ` acoplan at gcc dot gnu.org
  2020-09-30 13:27 ` acoplan at gcc dot gnu.org
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: acoplan at gcc dot gnu.org @ 2020-09-30  8:06 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97251

--- Comment #2 from Alex Coplan <acoplan at gcc dot gnu.org> ---
Fixed on trunk. Needs backporting to GCC 10.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/97251] [10/11 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE
  2020-09-30  7:58 [Bug target/97251] New: [10/11 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE acoplan at gcc dot gnu.org
  2020-09-30  8:05 ` [Bug target/97251] " cvs-commit at gcc dot gnu.org
  2020-09-30  8:06 ` acoplan at gcc dot gnu.org
@ 2020-09-30 13:27 ` acoplan at gcc dot gnu.org
  2020-09-30 14:48 ` acoplan at gcc dot gnu.org
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: acoplan at gcc dot gnu.org @ 2020-09-30 13:27 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97251

Alex Coplan <acoplan at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2020-09-30
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |acoplan at gcc dot gnu.org

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/97251] [10/11 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE
  2020-09-30  7:58 [Bug target/97251] New: [10/11 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE acoplan at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2020-09-30 13:27 ` acoplan at gcc dot gnu.org
@ 2020-09-30 14:48 ` acoplan at gcc dot gnu.org
  2020-10-12 11:47 ` [Bug target/97251] [10 " rguenth at gcc dot gnu.org
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: acoplan at gcc dot gnu.org @ 2020-09-30 14:48 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97251

Alex Coplan <acoplan at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.3

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/97251] [10 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE
  2020-09-30  7:58 [Bug target/97251] New: [10/11 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE acoplan at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2020-09-30 14:48 ` acoplan at gcc dot gnu.org
@ 2020-10-12 11:47 ` rguenth at gcc dot gnu.org
  2020-10-13 10:07 ` cvs-commit at gcc dot gnu.org
  2020-12-14  9:09 ` wirkus at gcc dot gnu.org
  6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-10-12 11:47 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97251

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|11.0                        |10.2.0
           Priority|P3                          |P2
      Known to work|                            |11.0
            Summary|[10/11 Regression] arm:     |[10 Regression] arm: ICEs
                   |ICEs compiling              |compiling
                   |pure-code/no-literal-pool.c |pure-code/no-literal-pool.c
                   |with integer MVE            |with integer MVE

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/97251] [10 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE
  2020-09-30  7:58 [Bug target/97251] New: [10/11 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE acoplan at gcc dot gnu.org
                   ` (4 preceding siblings ...)
  2020-10-12 11:47 ` [Bug target/97251] [10 " rguenth at gcc dot gnu.org
@ 2020-10-13 10:07 ` cvs-commit at gcc dot gnu.org
  2020-12-14  9:09 ` wirkus at gcc dot gnu.org
  6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-10-13 10:07 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97251

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Przemyslaw Wirkus
<wirkus@gcc.gnu.org>:

https://gcc.gnu.org/g:d121b3259b77203e62402024add1538c1bdf5fdf

commit r10-8885-gd121b3259b77203e62402024add1538c1bdf5fdf
Author: Alex Coplan <alex.coplan@arm.com>
Date:   Wed Sep 30 09:02:47 2020 +0100

    arm: Fix ICEs in no-literal-pool.c on MVE [PR97251]

    This patch fixes ICEs when compiling
    gcc/testsuite/gcc.target/arm/pure-code/no-literal-pool.c with
    -mfp16-format=ieee -mfloat-abi=hard -march=armv8.1-m.main+mve
    -mpure-code.

    The existing conditions in the movsf/movdf expanders (as well as the
    no_literal_pool patterns) were too restrictive, requiring
    TARGET_HARD_FLOAT instead of TARGET_VFP_BASE, which caused unrecognised
    insns when compiling this testcase with integer MVE and -mpure-code.

    gcc/ChangeLog:

            PR target/97251
            * config/arm/arm.md (movsf): Relax TARGET_HARD_FLOAT to
            TARGET_VFP_BASE.
            (movdf): Likewise.
            * config/arm/vfp.md (no_literal_pool_df_immediate): Likewise.
            (no_literal_pool_sf_immediate): Likewise.

    (cherry picked from commit f63023fafbbc13545fef67e6b32a55b48a945fcf)

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/97251] [10 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE
  2020-09-30  7:58 [Bug target/97251] New: [10/11 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE acoplan at gcc dot gnu.org
                   ` (5 preceding siblings ...)
  2020-10-13 10:07 ` cvs-commit at gcc dot gnu.org
@ 2020-12-14  9:09 ` wirkus at gcc dot gnu.org
  6 siblings, 0 replies; 8+ messages in thread
From: wirkus at gcc dot gnu.org @ 2020-12-14  9:09 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97251

Przemyslaw Wirkus <wirkus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
                 CC|                            |wirkus at gcc dot gnu.org

--- Comment #4 from Przemyslaw Wirkus <wirkus at gcc dot gnu.org> ---
Closing as this issue is resolved and backport was done.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-12-14  9:09 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-30  7:58 [Bug target/97251] New: [10/11 Regression] arm: ICEs compiling pure-code/no-literal-pool.c with integer MVE acoplan at gcc dot gnu.org
2020-09-30  8:05 ` [Bug target/97251] " cvs-commit at gcc dot gnu.org
2020-09-30  8:06 ` acoplan at gcc dot gnu.org
2020-09-30 13:27 ` acoplan at gcc dot gnu.org
2020-09-30 14:48 ` acoplan at gcc dot gnu.org
2020-10-12 11:47 ` [Bug target/97251] [10 " rguenth at gcc dot gnu.org
2020-10-13 10:07 ` cvs-commit at gcc dot gnu.org
2020-12-14  9:09 ` wirkus at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).