public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/97264] [11 Regression] -fpa-modref breaks va_arg on glibc
Date: Thu, 01 Oct 2020 09:53:41 +0000 [thread overview]
Message-ID: <bug-97264-4-of6tz1XedG@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-97264-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97264
--- Comment #4 from rguenther at suse dot de <rguenther at suse dot de> ---
On Thu, 1 Oct 2020, slyfox at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97264
>
> --- Comment #3 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
> Oh, that makes sense.
>
> > void __vfscanf_internal__ (const char *f, __builtin_va_list argptr)
> > {
> > /* assume input: "1<>\0" */
> > while (*f != '\0')
> > {
> > const unsigned char ** pstr = (const unsigned char **) &f;
>
> comes from
> https://sourceware.org/git/?p=glibc.git;a=blob;f=stdio-common/vfscanf-internal.c;h=95b46dcbeb55b1724b396f02a940f3047259b926;hb=HEAD#l489
> :
>
> """
> 274 int
> 275 __vfscanf_internal (FILE *s, const char *format, va_list argptr,
> 276 unsigned int mode_flags)
> ...
> 487 if (ISDIGIT ((UCHAR_T) *f))
> 488 {
> 489 argpos = read_int ((const UCHAR_T **) &f);
> """
>From this little context it eventually makes sense to declare
'f' as const unsigned char * in this function.
next prev parent reply other threads:[~2020-10-01 9:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 8:37 [Bug ipa/97264] New: " slyfox at gcc dot gnu.org
2020-10-01 8:38 ` [Bug ipa/97264] " slyfox at gcc dot gnu.org
2020-10-01 9:41 ` rguenth at gcc dot gnu.org
2020-10-01 9:50 ` slyfox at gcc dot gnu.org
2020-10-01 9:53 ` rguenther at suse dot de [this message]
2020-10-01 10:57 ` schwab@linux-m68k.org
2020-10-01 11:31 ` rguenth at gcc dot gnu.org
2020-10-16 12:09 ` rguenth at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-97264-4-of6tz1XedG@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).