* [Bug testsuite/97299] [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563
2020-10-05 20:11 [Bug other/97299] New: [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563 seurer at gcc dot gnu.org
@ 2020-10-06 9:08 ` rguenth at gcc dot gnu.org
2020-10-12 11:46 ` rguenth at gcc dot gnu.org
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-10-06 9:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97299
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |rguenth at gcc dot gnu.org
Component|other |testsuite
Ever confirmed|0 |1
Last reconfirmed| |2020-10-06
Target Milestone|--- |11.0
--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will have a look.
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug testsuite/97299] [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563
2020-10-05 20:11 [Bug other/97299] New: [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563 seurer at gcc dot gnu.org
2020-10-06 9:08 ` [Bug testsuite/97299] " rguenth at gcc dot gnu.org
@ 2020-10-12 11:46 ` rguenth at gcc dot gnu.org
2021-01-18 13:35 ` rguenth at gcc dot gnu.org
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-10-12 11:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97299
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug testsuite/97299] [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563
2020-10-05 20:11 [Bug other/97299] New: [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563 seurer at gcc dot gnu.org
2020-10-06 9:08 ` [Bug testsuite/97299] " rguenth at gcc dot gnu.org
2020-10-12 11:46 ` rguenth at gcc dot gnu.org
@ 2021-01-18 13:35 ` rguenth at gcc dot gnu.org
2021-01-18 13:50 ` rguenth at gcc dot gnu.org
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-01-18 13:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97299
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Just noting that while gcc-testresults has almost daily results of GCC 8,9,10
branches for ppc64le-linux trunk is only daily tested on ppc64-aix
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug testsuite/97299] [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563
2020-10-05 20:11 [Bug other/97299] New: [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563 seurer at gcc dot gnu.org
` (2 preceding siblings ...)
2021-01-18 13:35 ` rguenth at gcc dot gnu.org
@ 2021-01-18 13:50 ` rguenth at gcc dot gnu.org
2021-01-18 13:52 ` cvs-commit at gcc dot gnu.org
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-01-18 13:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97299
--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
OK, so this is a bad interaction of pattern detection and SLP reduction
vectorization. We're detecting
/home/rguenther/src/trunk/gcc/testsuite/gcc.dg/vect/slp-reduc-3.c:26:14: note:
widen_sum pattern recognized: patt_47 = prod_24 w+ res2_31;
which in turn empties LOOP_VINFO_REDUCTIONS via
/* Patterns cannot be vectorized using SLP, because they change the order of
computation. */
if (loop_vinfo)
{
unsigned ix, ix2;
stmt_vec_info *elem_ptr;
VEC_ORDERED_REMOVE_IF (LOOP_VINFO_REDUCTIONS (loop_vinfo), ix, ix2,
elem_ptr, *elem_ptr == stmt_info);
}
which means we're ending up with interleaving (and worse code).
The sentence above should only apply to reduction ops performing lane
reduction (SAD_EXPR, but also WIDEN_SUM_EXPR).
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug testsuite/97299] [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563
2020-10-05 20:11 [Bug other/97299] New: [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563 seurer at gcc dot gnu.org
` (3 preceding siblings ...)
2021-01-18 13:50 ` rguenth at gcc dot gnu.org
@ 2021-01-18 13:52 ` cvs-commit at gcc dot gnu.org
2021-01-18 13:52 ` rguenth at gcc dot gnu.org
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-01-18 13:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97299
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:104304cd246e9e8cd874f6cef7e2a5cd4bb0114d
commit r11-6767-g104304cd246e9e8cd874f6cef7e2a5cd4bb0114d
Author: Richard Biener <rguenther@suse.de>
Date: Mon Jan 18 14:51:00 2021 +0100
testsuite/97299 - fix test condition of gcc.dg/vect/slp-reduc-3.c
This avoids looking for permute optimization when SLP cannot be applied.
2021-01-18 Richard Biener <rguenther@suse.de>
PR testsuite/97299
* gcc.dg/vect/slp-reduc-3.c: Guard VEC_PERM_EXPR scan.
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug testsuite/97299] [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563
2020-10-05 20:11 [Bug other/97299] New: [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563 seurer at gcc dot gnu.org
` (4 preceding siblings ...)
2021-01-18 13:52 ` cvs-commit at gcc dot gnu.org
@ 2021-01-18 13:52 ` rguenth at gcc dot gnu.org
2021-01-20 10:44 ` ro at gcc dot gnu.org
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-01-18 13:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97299
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug testsuite/97299] [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563
2020-10-05 20:11 [Bug other/97299] New: [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563 seurer at gcc dot gnu.org
` (5 preceding siblings ...)
2021-01-18 13:52 ` rguenth at gcc dot gnu.org
@ 2021-01-20 10:44 ` ro at gcc dot gnu.org
2021-01-21 9:13 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: ro at gcc dot gnu.org @ 2021-01-20 10:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97299
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED
CC| |ro at gcc dot gnu.org
--- Comment #6 from Rainer Orth <ro at gcc dot gnu.org> ---
This patch has caused
+XPASS: gcc.dg/vect/slp-reduc-3.c -flto -ffat-lto-objects scan-tree-dump-times
vect "VEC_PERM_EXPR" 0
+XPASS: gcc.dg/vect/slp-reduc-3.c scan-tree-dump-times vect "VEC_PERM_EXPR" 0
on sparc-sun-solaris2.11 (32 and 64-bit) and, according to gcc-testresults, on
armeb-none-linux-gnueabihf, aarch64-suse-linux-gnu
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug testsuite/97299] [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563
2020-10-05 20:11 [Bug other/97299] New: [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563 seurer at gcc dot gnu.org
` (6 preceding siblings ...)
2021-01-20 10:44 ` ro at gcc dot gnu.org
@ 2021-01-21 9:13 ` rguenth at gcc dot gnu.org
2021-01-21 9:22 ` ro at CeBiTec dot Uni-Bielefeld.DE
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-01-21 9:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97299
--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Created attachment 50017
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50017&action=edit
patch
OK, so the arm fails are because they use load_lanes. Which means adjusting
like
/* { dg-final { scan-tree-dump-times "VEC_PERM_EXPR" 0 "vect" { xfail { {
vect_widen_sum_hi_to_si_pattern || { ! vect_unpack } } && { ! vect_load_lanes }
} } } } */
should work there. Then we have solaris which likely does not vectorize this
at all which means we need to condition all scans on the 'vectorized 1 loops'
scan. Meh, complicated target selectors :/
Rainer, can you test the attached patch?
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug testsuite/97299] [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563
2020-10-05 20:11 [Bug other/97299] New: [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563 seurer at gcc dot gnu.org
` (7 preceding siblings ...)
2021-01-21 9:13 ` rguenth at gcc dot gnu.org
@ 2021-01-21 9:22 ` ro at CeBiTec dot Uni-Bielefeld.DE
2021-01-21 9:59 ` cvs-commit at gcc dot gnu.org
2021-01-21 9:59 ` rguenth at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: ro at CeBiTec dot Uni-Bielefeld.DE @ 2021-01-21 9:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97299
--- Comment #8 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
> Created attachment 50017
> --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50017&action=edit
> patch
[...]
> Rainer, can you test the attached patch?
Sure, just did on sparc-sun-solaris2.11 and (for good measure)
i386-pc-solaris2.11: worked fine on both. Thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug testsuite/97299] [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563
2020-10-05 20:11 [Bug other/97299] New: [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563 seurer at gcc dot gnu.org
` (8 preceding siblings ...)
2021-01-21 9:22 ` ro at CeBiTec dot Uni-Bielefeld.DE
@ 2021-01-21 9:59 ` cvs-commit at gcc dot gnu.org
2021-01-21 9:59 ` rguenth at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-01-21 9:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97299
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:f46a40112caa7e039d949beda94386ff4e436a35
commit r11-6831-gf46a40112caa7e039d949beda94386ff4e436a35
Author: Richard Biener <rguenther@suse.de>
Date: Thu Jan 21 10:57:18 2021 +0100
testsuite/97299 - more gcc.dg/vect/slp-reduc-3.c massaging
This adds more guards to the VEC_PERM_EXPR scan, namely that
we also could end up with load-lanes and of course no vectorization
at all. Need dependent scans (scan-if-scan-X PASSed ...).
2021-01-21 Richard Biener <rguenther@suse.de>
PR testsuite/97299
* gcc.dg/vect/slp-reduc-3.c: Amend target selectors.
^ permalink raw reply [flat|nested] 12+ messages in thread* [Bug testsuite/97299] [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563
2020-10-05 20:11 [Bug other/97299] New: [11 regression] gcc.dg/vect/slp-reduc-3.c fails after r11-3563 seurer at gcc dot gnu.org
` (9 preceding siblings ...)
2021-01-21 9:59 ` cvs-commit at gcc dot gnu.org
@ 2021-01-21 9:59 ` rguenth at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-01-21 9:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97299
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed again (fingers crossing...)
^ permalink raw reply [flat|nested] 12+ messages in thread