From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 1660E386191F; Wed,  7 Oct 2020 09:28:29 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1660E386191F
From: "dcb314 at hotmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgcc/97316] New: config/libbid/bid64_noncomp.c: 7 * pointless
 test ?
Date: Wed, 07 Oct 2020 09:28:28 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libgcc
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dcb314 at hotmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-97316-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Oct 2020 09:28:29 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D97316

            Bug ID: 97316
           Summary: config/libbid/bid64_noncomp.c: 7 * pointless test ?
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgcc
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

1.

trunk.git/libgcc/config/libbid/bid64_noncomp.c:91:39: style: Mismatching
assignment and comparison, comparison 'sig_x=3D=3D0' is always false.
[assignIfError]

The source code is

      sig_x =3D (x & MASK_BINARY_SIG2) | MASK_BINARY_OR2;
      // check for zero or non-canonical
      if (sig_x > 9999999999999999ull || sig_x =3D=3D 0) {

but

$ fgrep MASK_BINARY_OR2 `find trunk.git/libgcc/config/libbid -name \*.h -pr=
int`
trunk.git/libgcc/config/libbid/bid_internal.h:#define MASK_BINARY_OR2=20=20=
=20=20=20=20=20=20=20=20
      0x0020000000000000ull
$

so the test for sig_x =3D=3D 0 does look pointless to me.

Some duplicates in the same file:

trunk.git/libgcc/config/libbid/bid64_noncomp.c:143:39: style: Mismatching
assignment and comparison, comparison 'sig_x=3D=3D0' is always false.
[assignIfError]
trunk.git/libgcc/config/libbid/bid64_noncomp.c:391:37: style: Mismatching
assignment and comparison, comparison 'sig_x=3D=3D0' is always false.
[assignIfError]
trunk.git/libgcc/config/libbid/bid64_noncomp.c:614:37: style: Mismatching
assignment and comparison, comparison 'sig_x=3D=3D0' is always false.
[assignIfError]
trunk.git/libgcc/config/libbid/bid64_noncomp.c:629:37: style: Mismatching
assignment and comparison, comparison 'sig_y=3D=3D0' is always false.
[assignIfError]
trunk.git/libgcc/config/libbid/bid64_noncomp.c:836:37: style: Mismatching
assignment and comparison, comparison 'sig_x=3D=3D0' is always false.
[assignIfError]
trunk.git/libgcc/config/libbid/bid64_noncomp.c:852:37: style: Mismatching
assignment and comparison, comparison 'sig_y=3D=3D0' is always false.
[assignIfError]=