public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/97328] [10 Regression] ICE in verify_ctor_sanity, at cp/constexpr.c:3995 since r10-7313-gb599bf9d6d1e180d
Date: Thu, 22 Oct 2020 16:36:24 +0000	[thread overview]
Message-ID: <bug-97328-4-4dbbw8x3PW@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-97328-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97328

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Patrick Palka
<ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:8094f781c35b64da68245d351b85546cca5b809b

commit r10-8938-g8094f781c35b64da68245d351b85546cca5b809b
Author: Patrick Palka <ppalka@redhat.com>
Date:   Thu Oct 22 07:40:40 2020 -0400

    c++: Handle RANGE_EXPR index in init_subob_ctx [PR97328]

    In the testcase below, we're ICEing during constexpr evaluation of the
    CONSTRUCTOR {.data={{}, [1 ... 7]={}}} of type 'vector'.  The interesting
    thing about this CONSTRUCTOR is that it has a RANGE_EXPR index for an
    element initializer which doesn't satisfy reduced_constant_expression_p
    (because the field 't' is uninitialized).

    This is a problem because init_subob_ctx currently punts on setting up a
    sub-aggregate initialization context when given a RANGE_EXPR index, so
    we later trip over the asserts in verify_ctor_sanity when recursing into
    cxx_eval_bare_aggregate on this element initializer.

    Fix this by making init_subob_ctx set up an appropriate initialization
    context when supplied a RANGE_EXPR index.

    gcc/cp/ChangeLog:

            PR c++/97328
            * constexpr.c (init_subob_ctx): Don't punt on RANGE_EXPR
            indexes, instead build a sub-aggregate initialization context
            with no subobject.

    gcc/testsuite/ChangeLog:

            PR c++/97328
            * g++.dg/cpp2a/constexpr-init19.C: New test.
            * g++.dg/cpp2a/constexpr-init20.C: New test.

    (cherry picked from commit 3d423c6f6a69d87ad52ba3af75f3debd8a8b8810)

  parent reply	other threads:[~2020-10-22 16:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07 23:36 [Bug c++/97328] New: [ICE] internal compiler error: in verify_ctor_sanity, at cp/constexpr.c:3995 ldalessandro at gmail dot com
2020-10-08 12:02 ` [Bug c++/97328] [10/11 Regression] ICE in verify_ctor_sanity, at cp/constexpr.c:3995 since r10-7313-gb599bf9d6d1e180d marxin at gcc dot gnu.org
2020-10-08 12:02 ` marxin at gcc dot gnu.org
2020-10-08 13:11 ` ppalka at gcc dot gnu.org
2020-10-08 18:46 ` ppalka at gcc dot gnu.org
2020-10-08 18:51 ` mpolacek at gcc dot gnu.org
2020-10-08 19:20 ` ppalka at gcc dot gnu.org
2020-10-08 21:46 ` ppalka at gcc dot gnu.org
2020-10-12 11:45 ` rguenth at gcc dot gnu.org
2020-10-22 11:41 ` cvs-commit at gcc dot gnu.org
2020-10-22 11:53 ` [Bug c++/97328] [10 " ppalka at gcc dot gnu.org
2020-10-22 16:36 ` cvs-commit at gcc dot gnu.org [this message]
2020-10-22 16:39 ` ppalka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-97328-4-4dbbw8x3PW@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).