[Bug c/97330] New: ice for stmt with wrong VUSE

[Bug c/97330] New: ice for stmt with wrong VUSE

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97330

            Bug ID: 97330
           Summary: ice for stmt with wrong VUSE
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

Created attachment 49328
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49328&action=edit
C source code

Sometime between 20201007 and 20201008, the attached code
has broken.

$ /home/dcb/gcc/results/bin/gcc -c -O2 -w /home/dcb/gcc/foundBugs/bug647.c 
auprocess.c: In function ‘rcm_1’:
auprocess.c:1275:17: error: stmt with wrong VUSE
# VUSE <.MEM_34(D)>
n_39 = el_35(D)->nextSample;
expected .MEM_33
during GIMPLE pass: sink
auprocess.c:1275:17: internal compiler error: verify_ssa failed
0xf02e86 verify_ssa(bool, bool)
        ../../trunk.git/gcc/tree-ssa.c:1208
0xbcd9c1 execute_function_todo(function*, void*)
        ../../trunk.git/gcc/passes.c:1999
0xbcc211 execute_todo(unsigned int)
        ../../trunk.git/gcc/passes.c:2046

I'll have a go at reducing the code.

[Bug c/97330] ice for stmt with wrong VUSE

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97330

--- Comment #1 from David Binderman <dcb314 at hotmail dot com> ---

Reduced code is:

typedef int a;
typedef char b;
int c;
void d(e, f, dst, g, avail, h) int e;
b *f, *dst;
a g, avail;
int h;
{
  b i = *f;
  if (e)
    goto j;
  while (avail) {
    *dst = i;
  j:
    avail -= c;
  }
}

[Bug c/97330] ice for stmt with wrong VUSE

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97330

--- Comment #2 from David Binderman <dcb314 at hotmail dot com> ---
Flags -Werror=implicit-int and -Werror=old-style-definition seem useful.

Here is another reduced test case:

int a, b, d;
char c, e;
void f(void) {
  char g = c;
  if (b)
    goto h;
  while (d) {
    e = c;
  h:
    d -= a;
  }
}

[Bug tree-optimization/97330] [11 Regression] ice for stmt with wrong VUSE

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97330

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0
          Component|c                           |tree-optimization
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2020-10-08
             Status|UNCONFIRMED                 |ASSIGNED
            Summary|ice for stmt with wrong     |[11 Regression] ice for
                   |VUSE                        |stmt with wrong VUSE
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.

[Bug tree-optimization/97330] [11 Regression] ice for stmt with wrong VUSE

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97330

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Just for the record, started with r11-3705-gdae673abd37d4004.

[Bug tree-optimization/97330] [11 Regression] ice for stmt with wrong VUSE

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97330

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:629e0547af33221a925f38757b52a9284148b68a

commit r11-3726-g629e0547af33221a925f38757b52a9284148b68a
Author: Richard Biener <rguenther@suse.de>
Date:   Thu Oct 8 13:18:57 2020 +0200

    tree-optimization/97330 - fix bad load sinking

    This fixes bad placement of sunk loads.

    2020-10-08  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/97330
            * tree-ssa-sink.c (statement_sink_location): Avoid skipping
            PHIs when they dominate the insert location.

            * gcc.dg/torture/pr97330-1.c: New testcase.
            * gcc.dg/torture/pr97330-2.c: Likewise.

[Bug tree-optimization/97330] [11 Regression] ice for stmt with wrong VUSE

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97330

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.