public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/97347] [11 Regression] error: statement marked for throw in middle of block in botan
Date: Fri, 09 Oct 2020 08:13:19 +0000	[thread overview]
Message-ID: <bug-97347-4-sS6P3Kp2Z4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-97347-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97347

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|10.0                        |11.0
           Assignee|marxin at gcc dot gnu.org          |rguenth at gcc dot gnu.org

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Since we're really want to insert on the edge and merely assert that will be
possible we should instead do

                      else
                        {
                          /* When we want to insert after a def where the
                             defining stmt throws then insert on the fallthru
                             edge.  */
                          edge e = find_fallthru_edge
                                     (gimple_bb (insert_after->stmt)->succs);
                          basic_block new_bb
                            = gsi_insert_seq_on_edge_immediate (e, ctor_seq);
                          gcc_assert (!new_bb);
                        }

possibly even allowing a new BB to be created (though our region collection
restrictions should not make this necessary).  Let me take this.

  parent reply	other threads:[~2020-10-09  8:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09  8:01 [Bug tree-optimization/97347] New: " marxin at gcc dot gnu.org
2020-10-09  8:01 ` [Bug tree-optimization/97347] " marxin at gcc dot gnu.org
2020-10-09  8:08 ` marxin at gcc dot gnu.org
2020-10-09  8:13 ` rguenth at gcc dot gnu.org [this message]
2020-10-09  8:57 ` marxin at gcc dot gnu.org
2020-10-09  9:16 ` dcb314 at hotmail dot com
2020-10-09  9:28 ` cvs-commit at gcc dot gnu.org
2020-10-09  9:28 ` rguenth at gcc dot gnu.org
2020-10-12 11:13 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-97347-4-sS6P3Kp2Z4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).