public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/97355] [11 Regression] Bootstrap comparison failure!
Date: Fri, 16 Oct 2020 10:31:18 +0000	[thread overview]
Message-ID: <bug-97355-4-fmKgbkkD88@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-97355-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97355

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nickc at gcc dot gnu.org

--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Mark Wielaard from comment #11)
> I don't understand why the .debug sections are compared in this case.
> 
> But if they are then the diff comes from this gas issue:
> https://sourceware.org/bugzilla/show_bug.cgi?id=26740
> 
> Even though unused gas -g might emit the input file name in the file table
> in some situations. It is harmless but since the the generated assembly file
> name might be different between stage2 and stage3 you will see a diff.
> 
> If this really is an issue I think a workaround might be to make sure that
> the .file 1 directive is emitted as early as possible.

But what is the problematic line before .file 1?  E.g. if I look at
lbasename.s, I see:
        .file   "lbasename.c"
        .text
.Ltext0:
        .p2align 4
        .globl  unix_lbasename
        .type   unix_lbasename, @function
unix_lbasename:
.LVL0:
.LFB20:
        .file 1 "../../libiberty/lbasename.c"

In any case, the change to use -gdwarf-* by default even when not compiling
just assembly was based on the assumption that gas would in that case pretty
much only change the format of the .debug_line section generated from
.file/.loc directives, but certainly not append anything on top of that itself
(e.g. append some stuff to the compiler emitted .debug* sections).
So, if that is not the case, we either need to fix gas in a similar way how it
has been changed before for compiler generated .debug_line, if gas starts
generating something and then sees compiler generated .debug* sections, it
should throw away everything as if -gdwarf-* only affected the default version.
Or we need a different gas option to just change the default dwarf level but
don't enable any other -gdwarf behavior of gas.

  parent reply	other threads:[~2020-10-16 10:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09 16:07 [Bug bootstrap/97355] New: " danglin at gcc dot gnu.org
2020-10-12  6:18 ` [Bug bootstrap/97355] [11 Regression] " rguenth at gcc dot gnu.org
2020-10-12  6:46 ` dave.anglin at bell dot net
2020-10-12  7:07 ` marxin at gcc dot gnu.org
2020-10-12 14:22 ` danglin at gcc dot gnu.org
2020-10-15 19:25 ` danglin at gcc dot gnu.org
2020-10-15 19:58 ` jakub at gcc dot gnu.org
2020-10-15 20:10 ` dave.anglin at bell dot net
2020-10-15 20:18 ` jakub at gcc dot gnu.org
2020-10-15 20:25 ` dave.anglin at bell dot net
2020-10-15 20:35 ` jakub at gcc dot gnu.org
2020-10-15 20:54 ` dave.anglin at bell dot net
2020-10-15 22:43 ` mark at gcc dot gnu.org
2020-10-16  0:14 ` danglin at gcc dot gnu.org
2020-10-16 10:24 ` jakub at gcc dot gnu.org
2020-10-16 10:31 ` jakub at gcc dot gnu.org [this message]
2020-10-16 20:28 ` mark at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-97355-4-fmKgbkkD88@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).