[Bug c/97359] New: ice in logical_combine, at gimple-range-gori.cc:754

[Bug c/97359] New: ice in logical_combine, at gimple-range-gori.cc:754

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97359

            Bug ID: 97359
           Summary: ice in logical_combine, at gimple-range-gori.cc:754
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

The attached C code, when compiled by recent gcc trunk
and compiler flag -O2, does this:

$ ../results/bin/gcc -c -O2 -w bug651.c
during GIMPLE pass: evrp
bug651.c: In function ‘func_14’:
bug651.c:12278:1: internal compiler error: in logical_combine, at
gimple-range-gori.cc:754
12278 | }
      | ^
0x18d8f56 gori_compute::logical_combine(irange&, tree_code, irange const&,
tf_range const&, tf_range const&)
        ../../trunk.git/gcc/gimple-range-gori.cc:754
0x18da9e2 gori_compute_cache::cache_stmt(gimple*)
        ../../trunk.git/gcc/gimple-range-gori.cc:1314
0x18da6c4 gori_compute_cache::compute_operand_range(irange&, gimple*, irange
const&, tree_node*)
        ../../trunk.git/gcc/gimple-range-gori.cc:1279
0x18d881e gori_compute::compute_operand1_range(irange&, gimple*, irange const&,
tree_node*)

I'll have a go at reducing the code.

[Bug c/97359] ice in logical_combine, at gimple-range-gori.cc:754

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97359

--- Comment #1 from David Binderman <dcb314 at hotmail dot com> ---
The code seems to break gcc trunk sometime between 20201006 and 20201007.

[Bug c/97359] ice in logical_combine, at gimple-range-gori.cc:754

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97359

--- Comment #2 from David Binderman <dcb314 at hotmail dot com> ---
The reduced C code is

typedef unsigned int uint32_t;
int a;
void b(uint32_t c) {
  uint32_t *d = &c;
  for (; a;)
    for (;; (*d %= a) / (*d > 1 > (c > 0)) ?: d)
      ;
}

[Bug tree-optimization/97359] [11 Regression] ice in logical_combine, at gimple-range-gori.cc:754

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97359

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ice in logical_combine, at  |[11 Regression] ice in
                   |gimple-range-gori.cc:754    |logical_combine, at
                   |                            |gimple-range-gori.cc:754
   Target Milestone|---                         |11.0
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2020-10-09
                 CC|                            |aldyh at gcc dot gnu.org,
                   |                            |amacleod at redhat dot com,
                   |                            |jakub at gcc dot gnu.org
          Component|c                           |tree-optimization

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Since r11-3685-gfcae5121154d1c3382b056bcc2c563cedac28e74 or r11-3684 (the
latter doesn't build) in particular.

[Bug tree-optimization/97359] [11 Regression] ice in logical_combine, at gimple-range-gori.cc:754

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97359

--- Comment #4 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Created attachment 49340
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49340&action=edit
untested proposed patch

Untested.

[Bug tree-optimization/97359] [11 Regression] ice in logical_combine, at gimple-range-gori.cc:754

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97359

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Aldy Hernandez <aldyh@gcc.gnu.org>:

https://gcc.gnu.org/g:14db1dfcd18e4d2712a043bdcd3976fcfb0642c2

commit r11-3762-g14db1dfcd18e4d2712a043bdcd3976fcfb0642c2
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Sat Oct 10 08:28:52 2020 +0200

    PR97359: Do not cache relops in GORI cache.

    logical_stmt_cache::cacheable_p() returns true for relops, but
    logical_combine (which does the caching) doesn't handle them and ICEs.
    This patch fixes the inconsistency by returning false for relops.

    This was working before because even though logical_combine doesn't
    handle relops, statements with only one SSA are handled in cache_stmt,
    which seems like the only statement we've ever encountered (even through
    a full Fedora build).

            lhs = s_5 > 999;

    However, with two SSA operands we ICE because logical_combine doesn't
    handle them:

            lhs = s_5 > y_8;

    We can either return false for relops in cacheable_p, or fix
    logical_combine to handle them.  The original idea was to only cache
    ANDs and ORs, so I've done the former to unbreak trunk.

    We can decide later if there was ever any benefit in caching relops.

    gcc/ChangeLog:

            PR tree-optimization/97359
            * gimple-range-gori.cc (logical_stmt_cache::cacheable_p): Only
            handle ANDs and ORs.
            (gori_compute_cache::cache_stmt): Adjust comment.

    gcc/testsuite/ChangeLog:

            * gcc.dg/pr97359.c: New test.

[Bug tree-optimization/97359] [11 Regression] ice in logical_combine, at gimple-range-gori.cc:754

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97359

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
fixed

[Bug tree-optimization/97359] [11 Regression] ice in logical_combine, at gimple-range-gori.cc:754

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97359

--- Comment #7 from Andrew Macleod <amacleod at redhat dot com> ---
There is no need to cache non-logical operands. Processing a relational such as
<,>,<=,>= is a linear process, and therefore we never needed to cache them.

&& and || is exponential as we have to evaluate 
op1_true, op1_false,  op2_true,  and op2_false 
and the resulting 4 combinations...  so each logical operand can trigger 4
lookup calculations.. and when they feed into each other the on-demand lookups
become exponential quite quickly.. 

the cache makes processing them linear as well.

Before the next stage 1 opens, I plan to rework the GORI computations to be
more efficient on calculating outgoing ranges.

[Bug tree-optimization/97359] [11 Regression] ice in logical_combine, at gimple-range-gori.cc:754

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97359

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |haoxintu at gmail dot com

--- Comment #8 from H.J. Lu <hjl.tools at gmail dot com> ---
*** Bug 98051 has been marked as a duplicate of this bug. ***