[Bug target/97367] New: powerpc64 g5 and cell optimizations result in .machine power7

[Bug target/97367] New: powerpc64 g5 and cell optimizations result in .machine power7

[rene at exactcode dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

            Bug ID: 97367
           Summary: powerpc64 g5 and cell optimizations result in .machine
                    power7
           Product: gcc
           Version: 10.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rene at exactcode dot de
  Target Milestone: ---

Created attachment 49341
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49341&action=edit
Patch

Since reworking the rs6000 .machine output selection in commit
e154242724b084380e3221df7c08fcdbd8460674 22 May 2019, compiling glibc with
either G5 or cell results in power7 assembly optimizations to be chosen, which
obviously crash with illegal instructions. This is because gcc's .machine
output was accidentally changed due to OPTION_MASK_ALTIVEC only otherwise
present in IBM CPUs since power7.

powerpc64-t2-linux-gnu-gcc  test.c -S -o - -mcpu=G5
        .file   "test.c"
        .machine power7
        .abiversion 2
        .section        ".text"
        .ident  "GCC: (GNU) 10.2.0"
        .section        .note.GNU-stack,"",@progbits

Attached patch fixes this to filter out ALTIVEC just like GFXOPT and GPOPT.

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[mikpelinux at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

Mikael Pettersson <mikpelinux at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikpelinux at gmail dot com

--- Comment #1 from Mikael Pettersson <mikpelinux at gmail dot com> ---
Care to submit this to gcc-patches?

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Mikael Pettersson from comment #1)
> Care to submit this to gcc-patches?

Please send it to the mailing list. Patches don't go in bugzilla, thanks.

https://gcc.gnu.org/contribute.html#patches

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2020-Decembe
                   |                            |r/560994.html
             Target|powerpc                     |powerpc*-*-*

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Ah yes, it was sent to the ML:
https://gcc.gnu.org/pipermail/gcc-patches/2020-December/560994.html

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Rebased patch:
https://svn.exactcode.de/t2/trunk/package/develop/gcc/g5-cell-not-power7.patch

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[rene at exactcode dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

--- Comment #5 from René Rebe <rene at exactcode dot de> ---
latest version:
https://svn.exactcode.de/t2/trunk/package/develop/gcc/hotfix-g5-power4.patch

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

Sam James <sjames at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sjames at gcc dot gnu.org

--- Comment #6 from Sam James <sjames at gcc dot gnu.org> ---
Please send it to the ML with git-send-email.

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |linkw at gcc dot gnu.org

--- Comment #7 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to Sam James from comment #6)
> Please send it to the ML with git-send-email.

...and CC our port maintainers, Segher, Ke Wen and David who are all on CC
here.

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://gcc.gnu.org/piperma |https://gcc.gnu.org/piperma
                   |il/gcc-patches/2020-Decembe |il/gcc-patches/2024-June/65
                   |r/560994.html               |4217.html

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Updated patch https://gcc.gnu.org/pipermail/gcc-patches/2024-June/654217.html

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Target Milestone|---                         |15.0
                URL|https://gcc.gnu.org/piperma |https://gcc.gnu.org/piperma
                   |il/gcc-patches/2024-June/65 |il/gcc-patches/2024-July/65
                   |4217.html                   |7184.html
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2024-07-12

--- Comment #9 from Peter Bergner <bergner at gcc dot gnu.org> ---
I posted an updated version of the latest patch that incorporates the review
comments plus an additional code change from myself.

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

--- Comment #10 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Peter Bergner <bergner@gcc.gnu.org>:

https://gcc.gnu.org/g:6962835bca3e6bef0f6ceae84a7814138b08b8a5

commit r15-2144-g6962835bca3e6bef0f6ceae84a7814138b08b8a5
Author: René Rebe <rene@exactcode.de>
Date:   Fri Jul 12 21:17:08 2024 +0000

    rs6000: Fix .machine cpu selection w/ altivec [PR97367]

    There are various non-IBM CPUs with altivec, so we cannot use that
    flag to determine which .machine cpu to use, so ignore it.
    Emit an additional ".machine altivec" if Altivec is enabled so
    that the assembler doesn't require an explicit -maltivec option
    to assemble any Altivec instructions for those targets where
    the ".machine cpu" is insufficient to enable Altivec.  For example,
    -mcpu=G5 emits a ".machine power4".

    2024-07-18  René Rebe  <rene@exactcode.de>
                Peter Bergner  <bergner@linux.ibm.com>

    gcc/
            PR target/97367
            * config/rs6000/rs6000.cc (rs6000_machine_from_flags): Do not
consider
            OPTION_MASK_ALTIVEC.
            (emit_asm_machine): For Altivec compiles, emit a ".machine
altivec".

    gcc/testsuite/
            PR target/97367
            * gcc.target/powerpc/pr97367.c: New test.

    Signed-off-by: René Rebe <rene@exactcode.de>

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |bergner at gcc dot gnu.org

--- Comment #11 from Peter Bergner <bergner at gcc dot gnu.org> ---
Fixed on trunk.  I'll push the backports after a little burn-in time on trunk.

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

--- Comment #12 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-14 branch has been updated by Peter Bergner
<bergner@gcc.gnu.org>:

https://gcc.gnu.org/g:1205104bbef40abe3baa5965a676f3b0f68971dd

commit r14-10476-g1205104bbef40abe3baa5965a676f3b0f68971dd
Author: René Rebe <rene@exactcode.de>
Date:   Fri Jul 12 21:17:08 2024 +0000

    rs6000: Fix .machine cpu selection w/ altivec [PR97367]

    There are various non-IBM CPUs with altivec, so we cannot use that
    flag to determine which .machine cpu to use, so ignore it.
    Emit an additional ".machine altivec" if Altivec is enabled so
    that the assembler doesn't require an explicit -maltivec option
    to assemble any Altivec instructions for those targets where
    the ".machine cpu" is insufficient to enable Altivec.  For example,
    -mcpu=G5 emits a ".machine power4".

    2024-07-18  René Rebe  <rene@exactcode.de>
                Peter Bergner  <bergner@linux.ibm.com>

    gcc/
            PR target/97367
            * config/rs6000/rs6000.cc (rs6000_machine_from_flags): Do not
consider
            OPTION_MASK_ALTIVEC.
            (emit_asm_machine): For Altivec compiles, emit a ".machine
altivec".

    gcc/testsuite/
            PR target/97367
            * gcc.target/powerpc/pr97367.c: New test.

    Signed-off-by: René Rebe <rene@exactcode.de>
    (cherry picked from commit 6962835bca3e6bef0f6ceae84a7814138b08b8a5)

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

--- Comment #13 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to Peter Bergner from comment #11)
> Fixed on trunk.  I'll push the backports after a little burn-in time on
> trunk.

All of Bill's CI testers were green wrt this test case, so I've started
backports.

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

--- Comment #14 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Peter Bergner
<bergner@gcc.gnu.org>:

https://gcc.gnu.org/g:44fe2c06a156a63f7ae359fd5dd3ce98afa3e92a

commit r13-8925-g44fe2c06a156a63f7ae359fd5dd3ce98afa3e92a
Author: René Rebe <rene@exactcode.de>
Date:   Fri Jul 12 21:17:08 2024 +0000

    rs6000: Fix .machine cpu selection w/ altivec [PR97367]

    There are various non-IBM CPUs with altivec, so we cannot use that
    flag to determine which .machine cpu to use, so ignore it.
    Emit an additional ".machine altivec" if Altivec is enabled so
    that the assembler doesn't require an explicit -maltivec option
    to assemble any Altivec instructions for those targets where
    the ".machine cpu" is insufficient to enable Altivec.  For example,
    -mcpu=G5 emits a ".machine power4".

    2024-07-18  René Rebe  <rene@exactcode.de>
                Peter Bergner  <bergner@linux.ibm.com>

    gcc/
            PR target/97367
            * config/rs6000/rs6000.cc (rs6000_machine_from_flags): Do not
consider
            OPTION_MASK_ALTIVEC.
            (emit_asm_machine): For Altivec compiles, emit a ".machine
altivec".

    gcc/testsuite/
            PR target/97367
            * gcc.target/powerpc/pr97367.c: New test.

    Signed-off-by: René Rebe <rene@exactcode.de>
    (cherry picked from commit 6962835bca3e6bef0f6ceae84a7814138b08b8a5)

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

--- Comment #15 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Peter Bergner
<bergner@gcc.gnu.org>:

https://gcc.gnu.org/g:319b57fb02b52ba9036c00dda36ff28d8274e13d

commit r12-10628-g319b57fb02b52ba9036c00dda36ff28d8274e13d
Author: René Rebe <rene@exactcode.de>
Date:   Fri Jul 12 21:17:08 2024 +0000

    rs6000: Fix .machine cpu selection w/ altivec [PR97367]

    There are various non-IBM CPUs with altivec, so we cannot use that
    flag to determine which .machine cpu to use, so ignore it.
    Emit an additional ".machine altivec" if Altivec is enabled so
    that the assembler doesn't require an explicit -maltivec option
    to assemble any Altivec instructions for those targets where
    the ".machine cpu" is insufficient to enable Altivec.  For example,
    -mcpu=G5 emits a ".machine power4".

    2024-07-18  René Rebe  <rene@exactcode.de>
                Peter Bergner  <bergner@linux.ibm.com>

    gcc/
            PR target/97367
            * config/rs6000/rs6000.cc (rs6000_machine_from_flags): Do not
consider
            OPTION_MASK_ALTIVEC.
            (emit_asm_machine): For Altivec compiles, emit a ".machine
altivec".

    gcc/testsuite/
            PR target/97367
            * gcc.target/powerpc/pr97367.c: New test.

    Signed-off-by: René Rebe <rene@exactcode.de>
    (cherry picked from commit 6962835bca3e6bef0f6ceae84a7814138b08b8a5)

[Bug target/97367] powerpc64 g5 and cell optimizations result in .machine power7

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #16 from Peter Bergner <bergner at gcc dot gnu.org> ---
Fixed everywhere.