[Bug ipa/97389] New: [11 Regression] Segfault in tramp3d since r11-3825-g71dbabccbfb295c8

[Bug ipa/97389] New: [11 Regression] Segfault in tramp3d since r11-3825-g71dbabccbfb295c8

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97389

            Bug ID: 97389
           Summary: [11 Regression] Segfault in tramp3d since
                    r11-3825-g71dbabccbfb295c8
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: ipa
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: hubicka at gcc dot gnu.org, marxin at gcc dot gnu.org
  Target Milestone: ---

It fails with PGO and -Ofast -march=native since the mentioned revision.

[Bug ipa/97389] [11 Regression] Segfault in tramp3d since r11-3825-g71dbabccbfb295c8

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97389

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
           Priority|P3                          |P1
   Last reconfirmed|                            |2020-10-12
   Target Milestone|---                         |11.0

[Bug ipa/97389] [11 Regression] Segfault in tramp3d since r11-3825-g71dbabccbfb295c8

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97389

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |hubicka at gcc dot gnu.org

--- Comment #1 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Mine.

[Bug ipa/97389] [11 Regression] Segfault in tramp3d since r11-3825-g71dbabccbfb295c8

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97389

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jan Hubicka <hubicka@gcc.gnu.org>:

https://gcc.gnu.org/g:56cb815ba22dd2ec00fee7a38f0862bc21d1c2a9

commit r11-3842-g56cb815ba22dd2ec00fee7a38f0862bc21d1c2a9
Author: Jan Hubicka <jh@suse.cz>
Date:   Tue Oct 13 09:19:54 2020 +0200

    Fix tramp3d PGO misoptimization

    this patch fixes tramp3d ICE with PGO.  It has turned out to be by a
misupdate
    in ignore_edge I introduced in previous patch that made us to not compute
    SCCs correctly with -fno-lto.

    While looking for problem I proofread the sources and also fortified the
    srouces for situation where we insert a summary for no good reason and
noticed
    a problem that early ipa-modref disabled itself in some cases.
    I also noticed that param_index is treamed as uhwi while it is signed (that
    wastes file space).

    Bootstrapping/regtesting x86_64-linux, will commit it tomorrow if that
passes.

    gcc/ChangeLog:

    2020-10-13  Jan Hubicka  <hubicka@ucw.cz>

            PR ipa/97389
            * ipa-modref.c (dump_lto_records): Fix formating of dump file.
            (modref_summary::dump): Do not check loads to be non-null.
            (modref_summary_lto::dump): Do not check loads to be non-null.
            (merge_call_side_effects): Improve debug output.
            (analyze_call): Crash when cur_summary->loads is NULL.
            (analyze_function): Update.
            (modref_summaries::insert): Insert only into summaries, not
            optimization_summaries.
            (modref_summaries::duplicate): Likewise; crash when load or sotres
            are NULL.
            (modref_summaries_lto::duplicate): Crash when loads or stores are
NULL.
            (write_modref_records): param_index is signed.
            (read_modref_records): param_index is signed.
            (modref_write): Crash when loads or stores are NULL.
            (read_section): Compensate previous change.
            (pass_modref::execute): Do not check optimization_summaries t be
            non-NULL.
            (ignore_edge): Fix.
            (compute_parm_map): Fix formating.
            (modref_propagate_in_scc): Do not expect loads/stores to be NULL.

[Bug ipa/97389] [11 Regression] Segfault in tramp3d since r11-3825-g71dbabccbfb295c8

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97389

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Fixed.