public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jiawei at iscas dot ac.cn" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug other/97417] RISC-V Unnecessary andi instruction when loading volatile bool
Date: Wed, 21 Oct 2020 03:36:21 +0000	[thread overview]
Message-ID: <bug-97417-4-qmmAEE5lW9@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-97417-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97417

jiawei <jiawei at iscas dot ac.cn> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jiawei at iscas dot ac.cn

--- Comment #2 from jiawei <jiawei at iscas dot ac.cn> ---
(In reply to Jim Wilson from comment #1)
> Comparing with the ARM port, I see that in the ARM port, the movqi pattern
> emits
> (insn 8 7 9 2 (set (reg:SI 117)
>         (zero_extend:SI (mem/v/c:QI (reg/f:SI 115) [1 active+0 S1 A8])))
> "tmp.c\
> ":7:7 -1
>      (nil))
> (insn 9 8 10 2 (set (reg:QI 116)
>         (subreg:QI (reg:SI 117) 0)) "tmp.c":7:7 -1
>      (nil))
> and then later it combines the subreg operation with the following
> zero_extend and cancels them out.
> 
> Whereas in the RISC-V port, the movqi pattern emits
> (insn 9 7 10 2 (set (reg:QI 76)
> 	(mem/v/c:QI (lo_sum:DI (reg:DI 74)
>                 (symbol_ref:DI ("active") [flags 0xc4]  <var_decl
> 0x7f9f0310312\
> 0 active>)) [1 active+0 S1 A8])) "tmp.c":7:7 -1
>      (nil))
> and then combine refuses to combine the following zero-extend with this insn
> as the memory operation is volatile.
> 
> So it seems we need to rewrite the RISC-V port to make movqi and movhi zero
> extend to si/di mode and then subreg.  That probably will require cascading
> changes to avoid code size and performance regressions.
> 
> Looks like a tractable small to medium size project, but will need to wait
> for a volunteer to work on it.

Hi Jim, My name is Jiawei Chen. I am from the PLCT Lab. I had recurrented this
bug, and want to try to help fixing this bug. What should I modify,is there any
suggestions?

  parent reply	other threads:[~2020-10-21  3:36 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 11:56 [Bug other/97417] New: " kjetilos at gmail dot com
2020-10-15 20:34 ` [Bug other/97417] " wilson at gcc dot gnu.org
2020-10-21  3:36 ` jiawei at iscas dot ac.cn [this message]
2020-10-21  5:58 ` wilson at gcc dot gnu.org
2020-10-27 11:18 ` jiawei at iscas dot ac.cn
2020-10-27 15:25 ` wilson at gcc dot gnu.org
2020-10-29  5:27 ` admin at levyhsu dot com
2020-10-29 22:49 ` wilson at gcc dot gnu.org
2020-10-30  8:35 ` admin at levyhsu dot com
2020-10-30 12:46 ` admin at levyhsu dot com
2020-11-04  6:10 ` admin at levyhsu dot com
2020-11-04  6:35 ` kito at gcc dot gnu.org
2020-11-04  7:03 ` admin at levyhsu dot com
2020-11-05 22:57 ` wilson at gcc dot gnu.org
2020-11-06  1:20 ` wilson at gcc dot gnu.org
2020-11-06  2:40 ` wilson at gcc dot gnu.org
2020-11-06  2:44 ` kito at gcc dot gnu.org
2020-11-06  3:35 ` wilson at gcc dot gnu.org
2020-11-06  9:46 ` admin at levyhsu dot com
2020-11-06 11:38 ` admin at levyhsu dot com
2020-11-06 20:44 ` wilson at gcc dot gnu.org
2020-11-06 21:08 ` wilson at gcc dot gnu.org
2020-11-09  8:35 ` admin at levyhsu dot com
2020-11-09  9:22 ` admin at levyhsu dot com
2020-11-10  5:20 ` admin at levyhsu dot com
2020-11-10  5:29 ` kito at gcc dot gnu.org
2020-11-10  5:34 ` admin at levyhsu dot com
2020-11-10  5:36 ` admin at levyhsu dot com
2020-11-10  6:01 ` admin at levyhsu dot com
2020-11-10 10:47 ` admin at levyhsu dot com
2020-11-11  1:21 ` wilson at gcc dot gnu.org
2020-11-11  5:43 ` admin at levyhsu dot com
2020-11-11  6:43 ` admin at levyhsu dot com
2020-11-11 19:35 ` wilson at gcc dot gnu.org
2020-11-12  1:26 ` admin at levyhsu dot com
2020-11-13  0:00 ` wilson at gcc dot gnu.org
2020-11-16  1:17 ` admin at levyhsu dot com
2020-11-16  3:24 ` kito at gcc dot gnu.org
2020-11-17 10:19 ` admin at levyhsu dot com
2020-11-18  6:09 ` admin at levyhsu dot com
2020-11-18 18:31 ` [Bug target/97417] " wilson at gcc dot gnu.org
2020-11-20  2:41 ` admin at levyhsu dot com
2020-11-20  3:32 ` wilson at gcc dot gnu.org
2020-11-23  6:17 ` admin at levyhsu dot com
2020-11-23  6:38 ` admin at levyhsu dot com
2020-11-23  7:43 ` admin at levyhsu dot com
2020-12-01  3:03 ` admin at levyhsu dot com
2020-12-08  9:22 ` admin at levyhsu dot com
2020-12-14 10:43 ` admin at levyhsu dot com
2020-12-15  9:55 ` admin at levyhsu dot com
2020-12-16  2:40 ` wilson at gcc dot gnu.org
2020-12-16  2:42 ` wilson at gcc dot gnu.org
2020-12-17 18:13 ` wilson at gcc dot gnu.org
2020-12-17 18:26 ` jiawei at iscas dot ac.cn
2020-12-21 15:08 ` jiawei at iscas dot ac.cn
2020-12-21 15:38 ` kito at gcc dot gnu.org
2020-12-21 16:09 ` jiawei at iscas dot ac.cn
2020-12-22  6:35 ` admin at levyhsu dot com
2020-12-25  3:31 ` kito at gcc dot gnu.org
2020-12-25  9:09 ` jiawei at iscas dot ac.cn
2021-02-13 20:24 ` cvs-commit at gcc dot gnu.org
2021-02-13 20:37 ` cvs-commit at gcc dot gnu.org
2021-02-13 20:48 ` wilson at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-97417-4-qmmAEE5lW9@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).