public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug gcov-profile/97461] [11 Regression] allocate_gcov_kvp() deadlocks in firefox LTO+PGO build (overridden malloc() recursion) Date: Thu, 29 Oct 2020 18:54:46 +0000 [thread overview] Message-ID: <bug-97461-4-FIafgv0hGs@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-97461-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97461 --- Comment #17 from Martin Liška <marxin at gcc dot gnu.org> --- Or I may have a smarter trick: let's do dry run of malloc/free functions early in __gcov_init. Can you please test the patch as well? commit d80cecdb87d159f0b3a4072b6e1ef80515ad2afb Author: Martin Liska <mliska@suse.cz> Date: Thu Oct 29 19:52:37 2020 +0100 PGO: use dry run of malloc and free functions. diff --git a/libgcc/libgcov-driver.c b/libgcc/libgcov-driver.c index e53e4dc392a..dd481b48e22 100644 --- a/libgcc/libgcov-driver.c +++ b/libgcc/libgcov-driver.c @@ -608,12 +608,25 @@ __gcov_exit (void) gcov_error_exit (); } +/* Test memory that forces malloc and free functions to be called early + so that allocate_gcov_kvp can use calloc. Indirect call counters + taken from a pre-allocated array are used before that. */ +char *__gcov_test_memory; + /* Add a new object file onto the bb chain. Invoked automatically when running an object file's global ctors. */ void __gcov_init (struct gcov_info *info) { + static int malloc_utilized = 0; + if (!malloc_utilized) + { + __gcov_test_memory = malloc (16); + free (__gcov_test_memory); + malloc_utilized = 1; + } + if (!info->version || !info->n_functions) return; if (gcov_version (info, info->version, 0))
next prev parent reply other threads:[~2020-10-29 18:54 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-16 15:03 [Bug gcov-profile/97461] New: " slyfox at gcc dot gnu.org 2020-10-16 15:05 ` [Bug gcov-profile/97461] " slyfox at gcc dot gnu.org 2020-10-16 15:09 ` slyfox at gcc dot gnu.org 2020-10-16 15:16 ` slyfox at gcc dot gnu.org 2020-10-19 7:12 ` [Bug gcov-profile/97461] [11 Regression] " marxin at gcc dot gnu.org 2020-10-19 7:15 ` rguenth at gcc dot gnu.org 2020-10-19 13:42 ` marxin at gcc dot gnu.org 2020-10-19 13:46 ` Jan Hubicka 2020-10-19 13:46 ` hubicka at ucw dot cz 2020-10-19 14:15 ` marxin at gcc dot gnu.org 2020-10-19 14:51 ` Jan Hubicka 2020-10-19 14:52 ` hubicka at ucw dot cz 2020-10-19 14:58 ` marxin at gcc dot gnu.org 2020-10-27 10:50 ` cvs-commit at gcc dot gnu.org 2020-10-27 10:50 ` marxin at gcc dot gnu.org 2020-10-27 22:18 ` slyfox at gcc dot gnu.org 2020-10-29 10:19 ` marxin at gcc dot gnu.org 2020-10-29 14:53 ` slyfox at gcc dot gnu.org 2020-10-29 15:00 ` marxin at gcc dot gnu.org 2020-10-29 15:05 ` marxin at gcc dot gnu.org 2020-10-29 18:54 ` marxin at gcc dot gnu.org [this message] 2020-10-29 19:11 ` jakub at gcc dot gnu.org 2020-10-30 8:45 ` slyfox at gcc dot gnu.org 2020-10-30 23:37 ` slyfox at gcc dot gnu.org 2020-11-06 13:47 ` cvs-commit at gcc dot gnu.org 2020-11-06 13:49 ` marxin at gcc dot gnu.org 2020-11-09 9:57 ` marxin at gcc dot gnu.org 2020-12-04 7:01 ` marxin at gcc dot gnu.org 2021-01-21 9:26 ` rguenth at gcc dot gnu.org 2021-01-26 11:51 ` marxin at gcc dot gnu.org 2021-03-03 13:22 ` cvs-commit at gcc dot gnu.org 2021-03-03 13:27 ` marxin at gcc dot gnu.org 2021-03-03 13:31 ` jakub at gcc dot gnu.org 2021-03-03 14:49 ` marxin at gcc dot gnu.org 2021-03-03 15:14 ` lh_mouse at 126 dot com 2021-03-05 18:11 ` slyfox at gcc dot gnu.org 2021-03-06 8:19 ` marxin at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-97461-4-FIafgv0hGs@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).