From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 24C3A3A3E419; Thu, 22 Apr 2021 16:50:26 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 24C3A3A3E419
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/97487] [8/9 Regression] ICE in expand_simple_binop,
 at optabs.c:939 since r8-3977
Date: Thu, 22 Apr 2021 16:50:25 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 8.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-97487-4-R84zsbMSPX@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-97487-4@http.gcc.gnu.org/bugzilla/>
References: <bug-97487-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2021 16:50:26 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D97487

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:0afc3f561b5cf66d1ee9562369919ca19273c260

commit r8-10880-g0afc3f561b5cf66d1ee9562369919ca19273c260
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Feb 3 09:09:26 2021 +0100

    ifcvt: Avoid ICEs trying to force_operand random RTL [PR97487]

    As the testcase shows, RTL ifcvt can throw random RTL (whatever it foun=
d in
    some insns) at expand_binop or expand_unop and expects it to do somethi=
ng
    (and then will check if it created valid insns and punts if not).
    These functions in the end if the operands don't match try to
    copy_to_mode_reg the operands, which does
    if (!general_operand (x, VOIDmode))
      x =3D force_operand (x, temp);
    but, force_operand is far from handling all possible RTLs, it will ICE =
for
    all more unusual RTL codes.  Basically handles just simple arithmetic a=
nd
    unary RTL operations if they have an optab and
    expand_simple_binop/expand_simple_unop ICE on others.

    The following patch fixes it by adding some operand verification (wheth=
er
    there is a hope that copy_to_mode_reg will succeed on those).  It is ad=
ded
    both to noce_emit_move_insn (not needed for this exact testcase,
    that function simply tries to recog the insn as is and if it fails,
    handles some simple binop/unop cases; the patch performs the verificati=
on
    of their operands) and noce_try_sign_mask.

    2021-02-03  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/97487
            * ifcvt.c (noce_can_force_operand): New function.
            (noce_emit_move_insn): Use it.
            (noce_try_sign_mask): Likewise.  Formatting fix.

            * gcc.dg/pr97487-1.c: New test.
            * gcc.dg/pr97487-2.c: New test.

    (cherry picked from commit 025a0ee3911c0866c69f841df24a558c7c8df0eb)=