[Bug analyzer/97514] New: [11 Regression] ICE in add_function_entry, at analyzer/engine.cc:1958

[Bug analyzer/97514] New: [11 Regression] ICE in add_function_entry, at analyzer/engine.cc:1958

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97514

            Bug ID: 97514
           Summary: [11 Regression] ICE in add_function_entry, at
                    analyzer/engine.cc:1958
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: analyzer
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

gcc-11.0.0-alpha20201018 snapshot (g:1e70b1a358b6ce3b894f284d88fbb90518d45cc0)
ICEs when compiling the following testcase w/ -fanalyzer --param
analyzer-max-enodes-per-program-point=0:

typedef void (*sighandler_t) (int);

void
signal (int, sighandler_t);

static void
kw (int signum)
{
  (void) signum;
}

void
gk (int ot)
{
  signal (ot, kw);
}

% gcc-11.0.0 -fanalyzer --param analyzer-max-enodes-per-program-point=0 -c
dc48hftm.c
during IPA pass: analyzer
dc48hftm.c: In function 'gk':
dc48hftm.c:15:3: internal compiler error: in add_function_entry, at
analyzer/engine.cc:1958
   15 |   signal (ot, kw);
      |   ^~~~~~~~~~~~~~~
0x73aa05 ana::exploded_graph::add_function_entry(function*)
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201018/work/gcc-11-20201018/gcc/analyzer/engine.cc:1958
0x113b557 ana::exploded_graph::on_escaped_function(tree_node*)
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201018/work/gcc-11-20201018/gcc/analyzer/engine.cc:3985
0x11789e8
ana::reachable_regions::mark_escaped_clusters(ana::region_model_context*)
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201018/work/gcc-11-20201018/gcc/analyzer/region-model-reachability.cc:226
0x115ba3c ana::region_model::handle_unrecognized_call(gcall const*,
ana::region_model_context*)
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201018/work/gcc-11-20201018/gcc/analyzer/region-model.cc:887
0x113a4c5 ana::exploded_node::on_stmt(ana::exploded_graph&, ana::supernode
const*, gimple const*, ana::program_state*) const
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201018/work/gcc-11-20201018/gcc/analyzer/engine.cc:1175
0x113c761 ana::exploded_graph::process_node(ana::exploded_node*)
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201018/work/gcc-11-20201018/gcc/analyzer/engine.cc:2865
0x113d23a ana::exploded_graph::process_worklist()
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201018/work/gcc-11-20201018/gcc/analyzer/engine.cc:2490
0x113f33d ana::impl_run_checkers(ana::logger*)
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201018/work/gcc-11-20201018/gcc/analyzer/engine.cc:4579
0x114018c ana::run_checkers()
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201018/work/gcc-11-20201018/gcc/analyzer/engine.cc:4650
0x1133178 execute
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201018/work/gcc-11-20201018/gcc/analyzer/analyzer-pass.cc:84

[Bug analyzer/97514] [11 Regression] ICE in add_function_entry, at analyzer/engine.cc:1958

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97514

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |11.0

[Bug analyzer/97514] [11 Regression] ICE in add_function_entry, at analyzer/engine.cc:1958

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97514

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2020-10-21
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1

--- Comment #1 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Thanks for filing this; confirmed.

[Bug analyzer/97514] [11 Regression] ICE in add_function_entry, at analyzer/engine.cc:1958

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97514

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Just for the record, started with r11-3840-gaf66094d03779377.

[Bug analyzer/97514] [11 Regression] ICE in add_function_entry, at analyzer/engine.cc:1958

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97514

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:f7decfaebbcb8522fcb39b03a391a5c2cb64f460

commit r11-4222-gf7decfaebbcb8522fcb39b03a391a5c2cb64f460
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Thu Oct 22 06:16:28 2020 -0400

    analyzer: fix ICE when handling callback exceeds enode limit [PR97514]

    gcc/analyzer/ChangeLog:
            PR analyzer/97514
            * engine.cc (exploded_graph::add_function_entry): Handle failure
            to create an enode, rather than asserting.

    gcc/testsuite/ChangeLog:
            PR analyzer/97514
            * gcc.dg/analyzer/pr97514.c: New test.

[Bug analyzer/97514] [11 Regression] ICE in add_function_entry, at analyzer/engine.cc:1958

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97514

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Should be fixed by the above commit.

[Bug analyzer/97514] [11 Regression] ICE in add_function_entry, at analyzer/engine.cc:1958

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97514

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:ea0ae4e77a89d4a0492dcbbc13e9cbc19bcc2361

commit r11-4433-gea0ae4e77a89d4a0492dcbbc13e9cbc19bcc2361
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Tue Oct 27 09:50:24 2020 -0400

    analyzer: fix param "analyzer-max-enodes-per-program-point"

    This was effectively checking for one beyond the limit, rather than
    the limit itself.

    Seen when fixing PR analyzer/97514.

    gcc/analyzer/ChangeLog:
            * engine.cc (exploded_graph::get_or_create_node): Fix off-by-one
            when imposing param_analyzer_max_enodes_per_program_point limit.