* [Bug rtl-optimization/97535] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
@ 2020-10-23 2:06 ` icenowy at aosc dot io
2020-10-23 7:47 ` marxin at gcc dot gnu.org
` (16 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: icenowy at aosc dot io @ 2020-10-23 2:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
--- Comment #1 from Icenowy Zheng <icenowy at aosc dot io> ---
The problem is found to be trying to expand a memcpy() call with fixed length
2181038080.
Handling of memcpy() expansion seem to be corrupted when len >= 2147483648. The
length is mod with 2147483648, and then forced to expand.
When a test program that contains a call to memcpy() with len 2147483648 is
tried, it is "expanded" to nothing.
The problematic thing seems to be aarch64_expand_cpymem() in master at
config/aarch64/aarch64.c (aarch64_expand_movmem() in GCC 9), in which the
variable n is declared with `int` (a 32-bit signed integer on both AArch64 LP64
and x86-64). Modify it to HOST_WIDE_INT seems to fix the problem.
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug rtl-optimization/97535] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
2020-10-23 2:06 ` [Bug rtl-optimization/97535] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max icenowy at aosc dot io
@ 2020-10-23 7:47 ` marxin at gcc dot gnu.org
2020-10-23 8:07 ` icenowy at aosc dot io
` (15 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-10-23 7:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
CC| |marxin at gcc dot gnu.org
Last reconfirmed| |2020-10-23
Keywords| |needs-reduction
Status|UNCONFIRMED |NEW
--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Confirmed. I'm reducing that right now.
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug rtl-optimization/97535] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
2020-10-23 2:06 ` [Bug rtl-optimization/97535] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max icenowy at aosc dot io
2020-10-23 7:47 ` marxin at gcc dot gnu.org
@ 2020-10-23 8:07 ` icenowy at aosc dot io
2020-10-23 9:42 ` [Bug rtl-optimization/97535] [9/10/11 Regression] " tnfchris at gcc dot gnu.org
` (14 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: icenowy at aosc dot io @ 2020-10-23 8:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
--- Comment #3 from Icenowy Zheng <icenowy at aosc dot io> ---
A minimal reproduction: (Compile with gcc -c -O1)
```
#include <string.h>
#define SIZE 2181038080
extern char raw_buffer[SIZE];
void setRaw(const void *raw)
{
memcpy(raw_buffer, raw, SIZE);
}
```
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug rtl-optimization/97535] [9/10/11 Regression] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
` (2 preceding siblings ...)
2020-10-23 8:07 ` icenowy at aosc dot io
@ 2020-10-23 9:42 ` tnfchris at gcc dot gnu.org
2020-10-27 16:59 ` [Bug target/97535] " cvs-commit at gcc dot gnu.org
` (13 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2020-10-23 9:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
--- Comment #4 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Yeah, the overflow in the signed type is causing the number of instructions
guard to fail.
I'll submit a patch.
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug target/97535] [9/10/11 Regression] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
` (3 preceding siblings ...)
2020-10-23 9:42 ` [Bug rtl-optimization/97535] [9/10/11 Regression] " tnfchris at gcc dot gnu.org
@ 2020-10-27 16:59 ` cvs-commit at gcc dot gnu.org
2020-10-27 17:15 ` [Bug target/97535] [9/10 " tnfchris at gcc dot gnu.org
` (12 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-10-27 16:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:
https://gcc.gnu.org/g:0f801e0b6cc9f67c9a8983127e23161f6025c5b6
commit r11-4453-g0f801e0b6cc9f67c9a8983127e23161f6025c5b6
Author: Tamar Christina <tamar.christina@arm.com>
Date: Tue Oct 27 16:30:31 2020 +0000
AArch64: Fix overflow in memcopy expansion on aarch64.
Currently the inline memcpy expansion code for AArch64 is using a signed
int
to hold the number of elements to copy. When you giver give it a value
larger
than INT_MAX it will overflow.
The overflow causes the maximum number of instructions we want to expand to
check to fail since this assumes an unsigned number.
This patch changes the maximum isns arithmetic to be unsigned
HOST_WIDE_INT.
note that the calculation *must* remained signed as the memcopy issues
overlapping unaligned copies. This means the pointer must be moved back
and
so you need signed arithmetic.
gcc/ChangeLog:
PR target/97535
* config/aarch64/aarch64.c (aarch64_expand_cpymem): Use unsigned
arithmetic in check.
gcc/testsuite/ChangeLog:
PR target/97535
* gcc.target/aarch64/pr97535.c: New test.
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug target/97535] [9/10 Regression] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
` (4 preceding siblings ...)
2020-10-27 16:59 ` [Bug target/97535] " cvs-commit at gcc dot gnu.org
@ 2020-10-27 17:15 ` tnfchris at gcc dot gnu.org
2020-10-28 19:14 ` cvs-commit at gcc dot gnu.org
` (11 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2020-10-27 17:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
Tamar Christina <tnfchris at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[9/10/11 Regression] On |[9/10 Regression] On
|AArch64 memcpy expansion |AArch64 memcpy expansion
|cannot handle length > |cannot handle length >
|32-bit signed int max |32-bit signed int max
Status|NEW |ASSIGNED
--- Comment #6 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
fixed in trunk, will backport in a few days.
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug target/97535] [9/10 Regression] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
` (5 preceding siblings ...)
2020-10-27 17:15 ` [Bug target/97535] [9/10 " tnfchris at gcc dot gnu.org
@ 2020-10-28 19:14 ` cvs-commit at gcc dot gnu.org
2020-11-09 15:02 ` rguenth at gcc dot gnu.org
` (10 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-10-28 19:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:
https://gcc.gnu.org/g:3dcd47389b16f48dcf5512b9ebba15af5c0be948
commit r11-4496-g3dcd47389b16f48dcf5512b9ebba15af5c0be948
Author: Tamar Christina <tamar.christina@arm.com>
Date: Wed Oct 28 19:13:27 2020 +0000
AArch64: Skip test for pr97535 on ILP32 since it can't express the range.
I am excluding the test from ILP32 since the goal of the test is to test
truncations of large numbers above INT_MAX.
gcc/testsuite/ChangeLog:
PR target/97535
* gcc.target/aarch64/pr97535.c: Exclude ILP32.
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug target/97535] [9/10 Regression] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
` (6 preceding siblings ...)
2020-10-28 19:14 ` cvs-commit at gcc dot gnu.org
@ 2020-11-09 15:02 ` rguenth at gcc dot gnu.org
2020-11-17 10:20 ` cvs-commit at gcc dot gnu.org
` (9 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-11-09 15:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |wrong-code
Priority|P3 |P2
CC| |rguenth at gcc dot gnu.org
Target Milestone|--- |9.4
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug target/97535] [9/10 Regression] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
` (7 preceding siblings ...)
2020-11-09 15:02 ` rguenth at gcc dot gnu.org
@ 2020-11-17 10:20 ` cvs-commit at gcc dot gnu.org
2020-11-17 10:25 ` cvs-commit at gcc dot gnu.org
` (8 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-11-17 10:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Tamar Christina
<tnfchris@gcc.gnu.org>:
https://gcc.gnu.org/g:886964a78aa89ef3c15e69a7b4b96c55d51ea812
commit r10-9034-g886964a78aa89ef3c15e69a7b4b96c55d51ea812
Author: Tamar Christina <tamar.christina@arm.com>
Date: Tue Nov 17 10:19:20 2020 +0000
AArch64: Fix overflow in memcopy expansion on aarch64.
Currently the inline memcpy expansion code for AArch64 is using a signed
int
to hold the number of elements to copy. When you giver give it a value
larger
than INT_MAX it will overflow.
The overflow causes the maximum number of instructions we want to expand to
check to fail since this assumes an unsigned number.
This patch changes the maximum isns arithmetic to be unsigned. The type
can
stay 32-bits since the number of instructions we are allowed to expand to
are at most 8 which is far below what you could fit in an unsigned int.
note that the calculation *must* remained signed as the memcopy issues
overlapping unaligned copies. This means the pointer must be moved back
and
so you need signed arithmetic.
gcc/ChangeLog:
PR target/97535
* config/aarch64/aarch64.c (aarch64_expand_cpymem): Use unsigned
arithmetic in check.
gcc/testsuite/ChangeLog:
PR target/97535
* gcc.target/aarch64/pr97535.c: New test.
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug target/97535] [9/10 Regression] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
` (8 preceding siblings ...)
2020-11-17 10:20 ` cvs-commit at gcc dot gnu.org
@ 2020-11-17 10:25 ` cvs-commit at gcc dot gnu.org
2020-11-17 10:25 ` cvs-commit at gcc dot gnu.org
` (7 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-11-17 10:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Tamar Christina
<tnfchris@gcc.gnu.org>:
https://gcc.gnu.org/g:9d65095e72502c12903e202cfe2e1fc58140522a
commit r9-9052-g9d65095e72502c12903e202cfe2e1fc58140522a
Author: Tamar Christina <tamar.christina@arm.com>
Date: Tue Oct 27 16:30:31 2020 +0000
AArch64: Fix overflow in memcopy expansion on aarch64.
Currently the inline memcpy expansion code for AArch64 is using a signed
int
to hold the number of elements to copy. When you giver give it a value
larger
than INT_MAX it will overflow.
The overflow causes the maximum number of instructions we want to expand to
check to fail since this assumes an unsigned number.
This patch changes the maximum isns arithmetic to be unsigned
HOST_WIDE_INT.
note that the calculation *must* remained signed as the memcopy issues
overlapping unaligned copies. This means the pointer must be moved back
and
so you need signed arithmetic.
gcc/ChangeLog:
PR target/97535
* config/aarch64/aarch64.c (aarch64_expand_cpymem): Use unsigned
arithmetic in check.
gcc/testsuite/ChangeLog:
PR target/97535
* gcc.target/aarch64/pr97535.c: New test.
(cherry picked from commit 0f801e0b6cc9f67c9a8983127e23161f6025c5b6)
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug target/97535] [9/10 Regression] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
` (9 preceding siblings ...)
2020-11-17 10:25 ` cvs-commit at gcc dot gnu.org
@ 2020-11-17 10:25 ` cvs-commit at gcc dot gnu.org
2020-11-17 10:26 ` cvs-commit at gcc dot gnu.org
` (6 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-11-17 10:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Tamar Christina
<tnfchris@gcc.gnu.org>:
https://gcc.gnu.org/g:7e785f4c7643dbf5c4ae8cf02e2c148429adbfcf
commit r9-9053-g7e785f4c7643dbf5c4ae8cf02e2c148429adbfcf
Author: Tamar Christina <tamar.christina@arm.com>
Date: Wed Oct 28 19:13:27 2020 +0000
AArch64: Skip test for pr97535 on ILP32 since it can't express the range.
I am excluding the test from ILP32 since the goal of the test is to test
truncations of large numbers above INT_MAX.
gcc/testsuite/ChangeLog:
PR target/97535
* gcc.target/aarch64/pr97535.c: Exclude ILP32.
(cherry picked from commit 3dcd47389b16f48dcf5512b9ebba15af5c0be948)
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug target/97535] [9/10 Regression] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
` (10 preceding siblings ...)
2020-11-17 10:25 ` cvs-commit at gcc dot gnu.org
@ 2020-11-17 10:26 ` cvs-commit at gcc dot gnu.org
2020-11-17 10:31 ` tnfchris at gcc dot gnu.org
` (5 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-11-17 10:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Tamar Christina
<tnfchris@gcc.gnu.org>:
https://gcc.gnu.org/g:98ba03ffe0b9f37b4916ce6238fad754e00d720b
commit r10-9035-g98ba03ffe0b9f37b4916ce6238fad754e00d720b
Author: Tamar Christina <tamar.christina@arm.com>
Date: Wed Oct 28 19:13:27 2020 +0000
AArch64: Skip test for pr97535 on ILP32 since it can't express the range.
I am excluding the test from ILP32 since the goal of the test is to test
truncations of large numbers above INT_MAX.
gcc/testsuite/ChangeLog:
PR target/97535
* gcc.target/aarch64/pr97535.c: Exclude ILP32.
(cherry picked from commit 3dcd47389b16f48dcf5512b9ebba15af5c0be948)
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug target/97535] [9/10 Regression] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
` (11 preceding siblings ...)
2020-11-17 10:26 ` cvs-commit at gcc dot gnu.org
@ 2020-11-17 10:31 ` tnfchris at gcc dot gnu.org
2020-11-17 10:48 ` rguenther at suse dot de
` (4 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2020-11-17 10:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
Tamar Christina <tnfchris at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #12 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Fixed and backported to GCC 10,9. Could not reproduce on 8 which has a
different algorithm.
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug target/97535] [9/10 Regression] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
` (12 preceding siblings ...)
2020-11-17 10:31 ` tnfchris at gcc dot gnu.org
@ 2020-11-17 10:48 ` rguenther at suse dot de
2020-11-17 10:50 ` tnfchris at gcc dot gnu.org
` (3 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: rguenther at suse dot de @ 2020-11-17 10:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
--- Comment #13 from rguenther at suse dot de <rguenther at suse dot de> ---
On Tue, 17 Nov 2020, tnfchris at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
>
> Tamar Christina <tnfchris at gcc dot gnu.org> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> Resolution|--- |FIXED
> Status|ASSIGNED |RESOLVED
>
> --- Comment #12 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
> Fixed and backported to GCC 10,9. Could not reproduce on 8 which has a
> different algorithm.
But aarch64_expand_movmem has the same problem:
bool
aarch64_expand_movmem (rtx *operands)
{
unsigned int n;
...
n = UINTVAL (operands[2]);
should use unsigned HOST_WIDE_INT.
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug target/97535] [9/10 Regression] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
` (13 preceding siblings ...)
2020-11-17 10:48 ` rguenther at suse dot de
@ 2020-11-17 10:50 ` tnfchris at gcc dot gnu.org
2020-11-17 10:50 ` tnfchris at gcc dot gnu.org
` (2 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2020-11-17 10:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
Tamar Christina <tnfchris at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |ASSIGNED
--- Comment #14 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Hmm indeed. I only saw it was doing unsigned arithmetic. I'll patch that one
too.
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug target/97535] [9/10 Regression] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
` (14 preceding siblings ...)
2020-11-17 10:50 ` tnfchris at gcc dot gnu.org
@ 2020-11-17 10:50 ` tnfchris at gcc dot gnu.org
2020-11-17 12:53 ` cvs-commit at gcc dot gnu.org
2020-11-17 12:55 ` tnfchris at gcc dot gnu.org
17 siblings, 0 replies; 19+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2020-11-17 10:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
--- Comment #15 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Hmm indeed. I only saw it was doing unsigned arithmetic. I'll patch that one
too.
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug target/97535] [9/10 Regression] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
` (15 preceding siblings ...)
2020-11-17 10:50 ` tnfchris at gcc dot gnu.org
@ 2020-11-17 12:53 ` cvs-commit at gcc dot gnu.org
2020-11-17 12:55 ` tnfchris at gcc dot gnu.org
17 siblings, 0 replies; 19+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-11-17 12:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
--- Comment #16 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Tamar Christina
<tnfchris@gcc.gnu.org>:
https://gcc.gnu.org/g:ff3bb57646fb49090ce84b05bda5003b8f33fc07
commit r8-10626-gff3bb57646fb49090ce84b05bda5003b8f33fc07
Author: Tamar Christina <tamar.christina@arm.com>
Date: Tue Nov 17 12:53:08 2020 +0000
AArch64: Fix overflow in memcopy expansion on aarch64.
This a partial backport for 0f801e0b6cc9f67c9a8983127e23161f6025c5b6 which
fixes
a truncation error for the inline memcopy on AArch64 on GCC-8.
gcc/ChangeLog:
PR target/97535
* config/aarch64/aarch64.c (aarch64_expand_movme): Use
unsigned HOST_WIDE_INT.
gcc/testsuite/ChangeLog:
PR target/97535
* gcc.target/aarch64/pr97535.c: New test.
^ permalink raw reply [flat|nested] 19+ messages in thread* [Bug target/97535] [9/10 Regression] On AArch64 memcpy expansion cannot handle length > 32-bit signed int max
2020-10-23 0:54 [Bug rtl-optimization/97535] New: ICE when building xmrig on AArch64 icenowy at aosc dot io
` (16 preceding siblings ...)
2020-11-17 12:53 ` cvs-commit at gcc dot gnu.org
@ 2020-11-17 12:55 ` tnfchris at gcc dot gnu.org
17 siblings, 0 replies; 19+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2020-11-17 12:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97535
Tamar Christina <tnfchris at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #17 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Fixed on master and all branches still open.
^ permalink raw reply [flat|nested] 19+ messages in thread