public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/97549] [11 Regression] include/pstl rebase breaking <execution> Date: Fri, 19 Feb 2021 11:08:35 +0000 [thread overview] Message-ID: <bug-97549-4-IOqwipbv2d@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-97549-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97549 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jakub at gcc dot gnu.org --- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> --- After rpm -e tbb-devel , I can reproduce. The following fixes it for me. In GCC 10, parallel_backend.h just included parallel_backend_{serial,tbb}.h and did nothing beyond that, and parallel_backend_tbb.h provided directly namespace __pstl { namespace __par_backend { ... } } and defined everything in there, while parallel_backend_serial.h did: namespace __pstl { namespace __serial { ... } } and had this namespace __pstl { namespace __par_backend { using namespace __pstl::__serial; } } at the end. in GCC 11, parallel_backend.h does: namespace __pstl { namespace __par_backend = __serial_backend; } after including parallel_backend_serial.h or namespace __pstl { namespace __par_backend = __tbb_backend; } after including parallel_backend_tbb.h. The latter then has: namespace __pstl { namespace __tbb_backend { ... } } and no using etc. at the end, while parallel_backend_serial.h changed to: namespace __pstl { namespace __serial_backend { ... } } but has this leftover block from the GCC 10 times. Even changing that using namespace __pstl::__serial; to using namespace __pstl::__serial_backend; doesn't work, as it clashes with namespace __pstl { namespace __par_backend = __serial_backend; } in parallel_backend.h. 2021-02-19 Jakub Jelinek <jakub@redhat.com> * include/pstl/parallel_backend_serial.h: Remove __pstl::__par_backend. --- libstdc++-v3/include/pstl/parallel_backend_serial.h.jj 2020-10-21 19:33:24.059872401 +0200 +++ libstdc++-v3/include/pstl/parallel_backend_serial.h 2021-02-19 11:59:56.414645219 +0100 @@ -127,12 +127,4 @@ __parallel_invoke(_ExecutionPolicy&&, _F } // namespace __serial_backend } // namespace __pstl -namespace __pstl -{ -namespace __par_backend -{ -using namespace __pstl::__serial; -} -} // namespace __pstl - #endif /* _PSTL_PARALLEL_BACKEND_SERIAL_H */
next prev parent reply other threads:[~2021-02-19 11:08 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-23 15:16 [Bug libstdc++/97549] New: " nathan at gcc dot gnu.org 2020-11-04 13:52 ` [Bug libstdc++/97549] [11 Regression] " redi at gcc dot gnu.org 2020-12-15 12:32 ` redi at gcc dot gnu.org 2020-12-15 12:37 ` redi at gcc dot gnu.org 2021-01-14 9:30 ` rguenth at gcc dot gnu.org 2021-02-19 11:08 ` jakub at gcc dot gnu.org [this message] 2021-02-23 8:28 ` cvs-commit at gcc dot gnu.org 2021-02-23 9:10 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-97549-4-IOqwipbv2d@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).