* [Bug tree-optimization/97558] [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f
2020-10-24 6:49 [Bug tree-optimization/97558] New: [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f marxin at gcc dot gnu.org
@ 2020-10-24 6:49 ` marxin at gcc dot gnu.org
2020-10-26 7:55 ` rguenth at gcc dot gnu.org
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-10-24 6:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97558
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Known to fail| |11.0
Last reconfirmed| |2020-10-24
Ever confirmed|0 |1
Priority|P3 |P1
Target Milestone|--- |11.0
Known to work| |10.2.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/97558] [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f
2020-10-24 6:49 [Bug tree-optimization/97558] New: [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f marxin at gcc dot gnu.org
2020-10-24 6:49 ` [Bug tree-optimization/97558] " marxin at gcc dot gnu.org
@ 2020-10-26 7:55 ` rguenth at gcc dot gnu.org
2020-10-26 9:38 ` rguenth at gcc dot gnu.org
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-10-26 7:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97558
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |rguenth at gcc dot gnu.org
--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/97558] [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f
2020-10-24 6:49 [Bug tree-optimization/97558] New: [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f marxin at gcc dot gnu.org
2020-10-24 6:49 ` [Bug tree-optimization/97558] " marxin at gcc dot gnu.org
2020-10-26 7:55 ` rguenth at gcc dot gnu.org
@ 2020-10-26 9:38 ` rguenth at gcc dot gnu.org
2020-10-26 10:03 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-10-26 9:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97558
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Huh. OK, so we're having a !relevant and !live stmt in the SLP tree, and the
removed check for !vectype caught this.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/97558] [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f
2020-10-24 6:49 [Bug tree-optimization/97558] New: [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f marxin at gcc dot gnu.org
` (2 preceding siblings ...)
2020-10-26 9:38 ` rguenth at gcc dot gnu.org
@ 2020-10-26 10:03 ` rguenth at gcc dot gnu.org
2020-10-29 12:09 ` rguenth at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-10-26 10:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97558
--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
But then in vect_fixup_scalar_cycles_with_patterns we leave us with
a reduction chain with eventually half irrelevant stmts because we
mix in-pattern and non-in-pattern stmts for gcc.dg/vect/pr83965-2.c.
Will think of the situation after some of the current refactoring is finished.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/97558] [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f
2020-10-24 6:49 [Bug tree-optimization/97558] New: [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f marxin at gcc dot gnu.org
` (3 preceding siblings ...)
2020-10-26 10:03 ` rguenth at gcc dot gnu.org
@ 2020-10-29 12:09 ` rguenth at gcc dot gnu.org
2020-10-30 9:10 ` marxin at gcc dot gnu.org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-10-29 12:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97558
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
*** Bug 97625 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/97558] [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f
2020-10-24 6:49 [Bug tree-optimization/97558] New: [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f marxin at gcc dot gnu.org
` (4 preceding siblings ...)
2020-10-29 12:09 ` rguenth at gcc dot gnu.org
@ 2020-10-30 9:10 ` marxin at gcc dot gnu.org
2020-11-02 10:03 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-10-30 9:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97558
--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Maybe a bit different back-trace:
$ gcc
/home/marxin/Programming/gcc/gcc/testsuite/gcc.dg/vect/no-scevccp-outer-10b.c
-fno-tree-forwprop -O3 -c -c
during GIMPLE pass: vect
/home/marxin/Programming/gcc/gcc/testsuite/gcc.dg/vect/no-scevccp-outer-10b.c:
In function ‘foo’:
/home/marxin/Programming/gcc/gcc/testsuite/gcc.dg/vect/no-scevccp-outer-10b.c:12:1:
internal compiler error: in vect_slp_analyze_node_operations, at
tree-vect-slp.c:3559
12 | foo (int n){
| ^~~
0x73959e vect_slp_analyze_node_operations
/home/marxin/Programming/gcc/gcc/tree-vect-slp.c:3559
0x1053641 vect_slp_analyze_node_operations
/home/marxin/Programming/gcc/gcc/tree-vect-slp.c:3521
0x1053641 vect_slp_analyze_node_operations
/home/marxin/Programming/gcc/gcc/tree-vect-slp.c:3521
0x1053641 vect_slp_analyze_node_operations
/home/marxin/Programming/gcc/gcc/tree-vect-slp.c:3521
0x1053641 vect_slp_analyze_node_operations
/home/marxin/Programming/gcc/gcc/tree-vect-slp.c:3521
0x10548e2 vect_slp_analyze_operations(vec_info*)
/home/marxin/Programming/gcc/gcc/tree-vect-slp.c:3713
0x1035ee4 vect_analyze_loop_2
/home/marxin/Programming/gcc/gcc/tree-vect-loop.c:2338
0x1035ee4 vect_analyze_loop(loop*, vec_info_shared*)
/home/marxin/Programming/gcc/gcc/tree-vect-loop.c:2799
0x105c94b try_vectorize_loop_1
/home/marxin/Programming/gcc/gcc/tree-vectorizer.c:995
0x105d409 vectorize_loops()
/home/marxin/Programming/gcc/gcc/tree-vectorizer.c:1229
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/97558] [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f
2020-10-24 6:49 [Bug tree-optimization/97558] New: [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f marxin at gcc dot gnu.org
` (5 preceding siblings ...)
2020-10-30 9:10 ` marxin at gcc dot gnu.org
@ 2020-11-02 10:03 ` cvs-commit at gcc dot gnu.org
2020-11-02 10:05 ` rguenth at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-11-02 10:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97558
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:5b41d673ad96dd2f9a7dec3877d0381320ccadb1
commit r11-4603-g5b41d673ad96dd2f9a7dec3877d0381320ccadb1
Author: Richard Biener <rguenther@suse.de>
Date: Mon Nov 2 09:38:09 2020 +0100
tree-optimization/97558 - avoid SLP analyzing irrelevant stmts
This avoids analyzing reductions that are not relevant (thus dead)
which eventually will lead into crashes because the participating
stmts meta is not analyzed. For this to work the patch also
properly removes reduction groups that are not uniformly recognized
as patterns.
2020-11-02 Richard Biener <rguenther@suse.de>
PR tree-optimization/97558
* tree-vect-loop.c (vect_fixup_scalar_cycles_with_patterns):
Check for any mismatch in pattern vs. non-pattern and dissolve
the group if there is one.
* tree-vect-slp.c (vect_analyze_slp_instance): Avoid
analyzing not relevant reductions.
(vect_analyze_slp): Avoid analyzing not relevant reduction
groups.
* gcc.dg/vect/pr97558.c: New testcase.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/97558] [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f
2020-10-24 6:49 [Bug tree-optimization/97558] New: [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f marxin at gcc dot gnu.org
` (6 preceding siblings ...)
2020-11-02 10:03 ` cvs-commit at gcc dot gnu.org
@ 2020-11-02 10:05 ` rguenth at gcc dot gnu.org
2020-11-02 11:34 ` cvs-commit at gcc dot gnu.org
2020-11-02 11:34 ` rguenth at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-11-02 10:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97558
--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
The ICE in comment#5 remains.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/97558] [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f
2020-10-24 6:49 [Bug tree-optimization/97558] New: [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f marxin at gcc dot gnu.org
` (7 preceding siblings ...)
2020-11-02 10:05 ` rguenth at gcc dot gnu.org
@ 2020-11-02 11:34 ` cvs-commit at gcc dot gnu.org
2020-11-02 11:34 ` rguenth at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-11-02 11:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97558
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:4c198ddff83744f8b7bf24306ed1e6b889c44044
commit r11-4605-g4c198ddff83744f8b7bf24306ed1e6b889c44044
Author: Richard Biener <rguenther@suse.de>
Date: Mon Nov 2 11:09:56 2020 +0100
tree-optimization/97558 - compute vectype for SLP nested cycles
This makes sure to compute the vector type for invariant SLP children
of nested cycles.
2020-11-02 Richard Biener <rguenther@suse.de>
PR tree-optimization/97558
* tree-vect-loop.c (vectorizable_reduction): For nested SLP
cycles compute invariant operands vector type.
* gcc.dg/vect/pr97558-2.c: New testcase.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug tree-optimization/97558] [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f
2020-10-24 6:49 [Bug tree-optimization/97558] New: [11 Regression] ICE in vect_slp_analyze_node_operations, at tree-vect-slp.c:3342 since r11-4227-g655f7f0fb7c9aa2f marxin at gcc dot gnu.org
` (8 preceding siblings ...)
2020-11-02 11:34 ` cvs-commit at gcc dot gnu.org
@ 2020-11-02 11:34 ` rguenth at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-11-02 11:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97558
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 11+ messages in thread