public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/97578] ice during IPA pass: inline
Date: Mon, 26 Oct 2020 12:37:58 +0000	[thread overview]
Message-ID: <bug-97578-4-nxJZqCpun9@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-97578-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97578

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at redhat dot com,
                   |                            |mjambor at suse dot cz
          Component|ipa                         |c
            Summary|[11 Regression] ice during  |ice during IPA pass: inline
                   |IPA pass: inline            |

--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
What hits us here is the hack I needed to introduce to
ipa_param_adjustments::modify_call which triggers materialization to make debug
info code working.  In this case redirection happens from tree-inline and
materialization gets us back to tree-inline. Inliner is however not intended to
be recursive (it uses bb->aux pointers and in this case it will use it twice).

Martin, Jambor,
it would be really great if we did not need to materialize.  I do not see how
attaching debug info to decls can work if caller is in one partition and callee
in another.

We could also just add a loop walking all such calls and trigger
materialization before going to tree-inline to avoid the recursion problem, but
still IMO debug info will get missing on the partitioning boundary. We could
also just avoid the (ab)use of bb->aux and replace it by a vector here which
would be also an option.

  parent reply	other threads:[~2020-10-26 12:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 11:35 [Bug c/97578] New: " dcb314 at hotmail dot com
2020-10-26 11:46 ` [Bug c/97578] " marxin at gcc dot gnu.org
2020-10-26 12:21 ` dcb314 at hotmail dot com
2020-10-26 12:37 ` hubicka at gcc dot gnu.org [this message]
2020-10-31 12:55 ` su at cs dot ucdavis.edu
2020-11-01 14:48   ` Jan Hubicka
2020-11-01 14:48 ` hubicka at ucw dot cz
2020-11-02 16:26 ` jamborm at gcc dot gnu.org
2020-11-03 10:56 ` cvs-commit at gcc dot gnu.org
2020-11-03 11:19 ` hubicka at gcc dot gnu.org
2020-11-03 11:21 ` jakub at gcc dot gnu.org
2020-11-03 11:25   ` Jan Hubicka
2020-11-03 11:25 ` hubicka at ucw dot cz
2021-04-27 11:39 ` jakub at gcc dot gnu.org
2021-07-28  7:05 ` rguenth at gcc dot gnu.org
2022-04-13 15:07 ` [Bug c/97578] [11 Regression] " redi at gcc dot gnu.org
2022-04-13 15:09 ` jakub at gcc dot gnu.org
2022-04-13 16:23 ` dcb314 at hotmail dot com
2022-04-13 17:21 ` jamborm at gcc dot gnu.org
2022-04-21  7:48 ` rguenth at gcc dot gnu.org
2023-05-29 10:03 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-97578-4-nxJZqCpun9@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).