From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id A17193858D29; Mon, 22 Mar 2021 22:03:57 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A17193858D29
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/97587] [coroutines] promise_type constructor is called with
 original parameters, not parameter copies
Date: Mon, 22 Mar 2021 22:03:57 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 10.2.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: iains at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-97587-4-lP88wrQd0o@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-97587-4@http.gcc.gnu.org/bugzilla/>
References: <bug-97587-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Mar 2021 22:03:57 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D97587

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:88bb77a8dcf75f556b8dcb24b8785b4567d24e4f

commit r10-9511-g88bb77a8dcf75f556b8dcb24b8785b4567d24e4f
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Mon Feb 15 16:13:36 2021 +0000

    coroutines : Call promise CTOR with parm copies [PR97587].

    As the PR notes, we were calling the promise CTOR with the original
    function parameters, not the copy (as pointed, a previous wording of
    the section was unambiguous).  Fixed thus.

    gcc/cp/ChangeLog:

            PR c++/97587
            * coroutines.cc (struct param_info): Track rvalue refs.
            (morph_fn_to_coro): Track rvalue refs, and call the promise
            CTOR with the frame copy of passed parms.

    gcc/testsuite/ChangeLog:

            PR c++/97587
            * g++.dg/coroutines/coro1-refs-and-ctors.h: Add a CTOR with two
            reference parms, to distinguish the rvalue ref. variant.
            * g++.dg/coroutines/pr97587.C: New test.

    (cherry picked from commit b8ff3f8efeda02a6bedebfaf20b93645ae3bb5b8)=