[Bug ipa/97593] New: [11 Regression] ICE in gt_pch_nx, at symbol-summary.h:290 since r11-4329-g67f3791f7d133214

[Bug ipa/97593] New: [11 Regression] ICE in gt_pch_nx, at symbol-summary.h:290 since r11-4329-g67f3791f7d133214

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97593

            Bug ID: 97593
           Summary: [11 Regression] ICE in gt_pch_nx, at
                    symbol-summary.h:290 since r11-4329-g67f3791f7d133214
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: ipa
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: hubicka at gcc dot gnu.org, marxin at gcc dot gnu.org
  Target Milestone: ---

The following fails since r11-4329-g67f3791f7d133214:

$ cat prusa.ii
class ConfigBase {
  virtual int *def() const;
};
class DynamicConfig : virtual ConfigBase {
  int *def() const { return 0; }
};

$ g++ -x c++-header prusa.ii -o x.pch
prusa.ii:6:2: internal compiler error: in gt_pch_nx, at symbol-summary.h:329
    6 | };
      |  ^
0x758fea void gt_pch_nx<thunk_info>(function_summary<thunk_info*>* const&)
        /home/marxin/Programming/gcc/gcc/symbol-summary.h:329
0x758fea gt_pch_nx_function_summary_thunk_info__(void*)
        /dev/shm/objdir/gcc/gtype-desc.c:6428
0x758fea gt_pch_nx_symbol_table(void*)
        /dev/shm/objdir/gcc/gtype-desc.c:6451
0x758fea gt_pch_nx_symbol_table(void*)
        /dev/shm/objdir/gcc/gtype-desc.c:6440
0xd4c785 gt_pch_save(_IO_FILE*)
        /home/marxin/Programming/gcc/gcc/ggc-common.c:430
0xb3c5a5 c_common_write_pch()
        /home/marxin/Programming/gcc/gcc/c-family/c-pch.c:177
0x97bd8c c_parse_final_cleanups()
        /home/marxin/Programming/gcc/gcc/cp/decl2.c:4866
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

It's because I added the assert to summaries as we didn't expect PCH being
called for it.

[Bug ipa/97593] [11 Regression] ICE in gt_pch_nx, at symbol-summary.h:290 since r11-4329-g67f3791f7d133214

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97593

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0
      Known to work|                            |10.2.0
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2020-10-27
             Status|UNCONFIRMED                 |NEW
      Known to fail|                            |11.0
           Priority|P3                          |P1

[Bug ipa/97593] [11 Regression] ICE in gt_pch_nx, at symbol-summary.h:290 since r11-4329-g67f3791f7d133214

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97593

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
The original commit was sent here:
https://gcc.gnu.org/legacy-ml/gcc-patches/2019-10/msg01745.html

Git commit: g:315d42482cf3

[Bug ipa/97593] [11 Regression] ICE in gt_pch_nx, at symbol-summary.h:290 since r11-4329-g67f3791f7d133214

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97593

--- Comment #2 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Hmm, this is anoying: we can not store summary to PCH. I guess we want to
collect thunks to a vector and annotate them to callgraph at finalization time
:(

[Bug ipa/97593] [11 Regression] ICE in gt_pch_nx, at symbol-summary.h:290 since r11-4329-g67f3791f7d133214

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97593

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Jan Hubicka from comment #2)
> Hmm, this is anoying: we can not store summary to PCH. I guess we want to
> collect thunks to a vector and annotate them to callgraph at finalization
> time :(

I see.
Can you please take care of it?

[Bug ipa/97593] [11 Regression] ICE in gt_pch_nx, at symbol-summary.h:290 since r11-4329-g67f3791f7d133214

[hubicka at ucw dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97593

--- Comment #4 from Jan Hubicka <hubicka at ucw dot cz> ---
> I see.
> Can you please take care of it?
I will - as a natural punishment for cleaning this up :))

[Bug ipa/97593] [11 Regression] ICE in gt_pch_nx, at symbol-summary.h:290 since r11-4329-g67f3791f7d133214

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97593

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jan Hubicka <hubicka@gcc.gnu.org>:

https://gcc.gnu.org/g:aa701610e51ca9e15573ba080cb93ef726252cfc

commit r11-4572-gaa701610e51ca9e15573ba080cb93ef726252cfc
Author: Jan Hubicka <jh@suse.cz>
Date:   Fri Oct 30 14:30:43 2020 +0100

    Fix thunk info WRT PCH

            PR pch/97593
            * cgraph.c (cgraph_node::create_thunk): Register thunk as early
during
            parsing.
            * cgraphunit.c (analyze_functions): Call
            thunk_info::process_early_thunks.
            * symtab-thunks.cc (struct unprocessed_thunk): New struct.
            (thunks): New static variable.
            (thunk_info::register_early): New member function.
            (thunk_info::process_early_thunks): New member function.
            * symtab-thunks.h (thunk_info::register_early): Declare.
            (thunk_info::process_early_thunks): Declare.

[Bug ipa/97593] [11 Regression] ICE in gt_pch_nx, at symbol-summary.h:290 since r11-4329-g67f3791f7d133214

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97593

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Fixed.