public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ppalka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/97613] chrono::year_month_weekday cast to sys_days : return bad value if index() == 0
Date: Wed, 28 Oct 2020 16:41:10 +0000	[thread overview]
Message-ID: <bug-97613-4-opVvWYCYcE@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-97613-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97613

--- Comment #3 from Patrick Palka <ppalka at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:8572edc828f6d1e7c8243f901fe7c96f62a11a8e

commit r11-4490-g8572edc828f6d1e7c8243f901fe7c96f62a11a8e
Author: Patrick Palka <ppalka@redhat.com>
Date:   Wed Oct 28 12:28:08 2020 -0400

    libstdc++: Fix arithmetic bug in year_month_weekday conversion [PR96713]

    The conversion function year_month_weekday::operator sys_days computes
    the offset in days from the first weekday of the month with:

     days{(index()-1)*7}
          ^~~~~~~~~~~~~  type 'unsigned'

    We want the above to yield -7d when index() is 0u, but our 'days' alias
    is based on long instead of int, so the conversion from unsigned to the
    underlying type of 'days' instead yields a large positive value.

    This patch fixes this by casting the result of index() to int so that
    the initializer is sign-extended in the conversion to long.

    The added testcase also verifies we do the right thing when index() == 5.

    libstdc++-v3/ChangeLog:

            PR libstdc++/96713
            * include/std/chrono (year_month_weekday::operator sys_days):
            Cast the result of index() to int so that the initializer for
            days{} is sign-extended when it's converted to the underlying
            type.
            * testsuite/std/time/year_month_weekday/3.cc: New test.

  parent reply	other threads:[~2020-10-28 16:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28  8:52 [Bug libstdc++/97613] New: " faithandbrave at gmail dot com
2020-10-28  9:05 ` [Bug libstdc++/97613] " faithandbrave at gmail dot com
2020-10-28 13:45 ` ppalka at gcc dot gnu.org
2020-10-28 16:41 ` ppalka at gcc dot gnu.org [this message]
2020-10-28 16:44 ` ppalka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-97613-4-opVvWYCYcE@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).