From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id D7FC83857C6F; Thu, 29 Oct 2020 00:20:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D7FC83857C6F From: "msebor at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/97620] -fexec-charset=IBM16804 triggers ICE Date: Thu, 29 Oct 2020 00:20:18 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: tree-optimization X-Bugzilla-Version: 11.0 X-Bugzilla-Keywords: ice-on-valid-code X-Bugzilla-Severity: normal X-Bugzilla-Who: msebor at gcc dot gnu.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: DUPLICATE X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 00:20:19 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D97620 --- Comment #4 from Martin Sebor --- I don't know of any such macros and -dM -E doesn't show any. Bug 82700 comment 1 explains that "The sprintf pass calls lang_hooks.to_target_charset () to convert each of these characters from the source set to the execution set and the function aborts when it can't do the conversion. That seems unfriendly -- it should instead return some failure code and let the caller decide how to deal with it." The caller could deal with it by issuing a more friendly message. But the = ICE happens inside the preprocessor library and there's no API to find out if a charset is valid. It also doesn't seem that handling the failure and issui= ng an error should be left up to each client of the library. It would probabl= y be best to handle during option validation.=