[Bug c++/97658] New: Tired of having to change make files on every new version. Damnit!

[Bug c++/97658] New: Tired of having to change make files on every new version. Damnit!

[hubert.vansteenhuyse at freecode dot be]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97658

            Bug ID: 97658
           Summary: Tired of having to change make files on every new
                    version. Damnit!
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hubert.vansteenhuyse at freecode dot be
  Target Milestone: ---

src/MAL/utils/utils.hpp:600:10: note: ‘struct
HASHTABLE<PROJECTILE_CACHE*>::CONTAINER’ declared here
  600 |   struct CONTAINER {
      |          ^~~~~~~~~
src/MAL/utils/utils.hpp: In instantiation of ‘void HASHTABLE<T>::reset() [with
T = PROJECTILE*]’:
src/game/game.hpp:431:19:   required from here
src/MAL/utils/utils.hpp:691:11: warning: ‘void* memset(void*, int, size_t)’
clearing an object of non-trivial type ‘struct
HASHTABLE<PROJECTILE*>::CONTAINER’; use assignment or value-initialization
instead [-Wclass-memaccess]
  691 |     memset(this->data.array, 0, sizeof(CONTAINER) *
this->data.elems());
      |     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/MAL/utils/utils.hpp:600:10: note: ‘struct
HASHTABLE<PROJECTILE*>::CONTAINER’ declared here
  600 |   struct CONTAINER {
      |          ^~~~~~~~~
src/MAL/utils/utils.hpp: In instantiation of ‘void HASHTABLE<T>::reset() [with
T = PROFILE*]’:
src/game/bots.cpp:330:16:   required from here
src/MAL/utils/utils.hpp:691:11: warning: ‘void* memset(void*, int, size_t)’
clearing an object of non-trivial type ‘struct HASHTABLE<PROFILE*>::CONTAINER’;
use assignment or value-initialization instead [-Wclass-memaccess]
  691 |     memset(this->data.array, 0, sizeof(CONTAINER) *
this->data.elems());
      |     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/MAL/utils/utils.hpp:600:10: note: ‘struct HASHTABLE<PROFILE*>::CONTAINER’
declared here
  600 |   struct CONTAINER {
      |          ^~~~~~~~~
src/MAL/utils/utils.hpp: In instantiation of ‘void HASHTABLE<T>::reset() [with
T = BOT*]’:
src/game/bots.cpp:1847:15:   required from here
src/MAL/utils/utils.hpp:691:11: warning: ‘void* memset(void*, int, size_t)’
clearing an object of non-trivial type ‘struct HASHTABLE<BOT*>::CONTAINER’; use
assignment or value-initialization instead [-Wclass-memaccess]
  691 |     memset(this->data.array, 0, sizeof(CONTAINER) *
this->data.elems());
      |     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/MAL/utils/utils.hpp:600:10: note: ‘struct HASHTABLE<BOT*>::CONTAINER’
declared here
  600 |   struct CONTAINER {
      |          ^~~~~~~~~
src/MAL/utils/utils.hpp: In instantiation of ‘void HASHTABLE<T>::reset() [with
T = TREE*]’:
src/MAL/utils/utils.hpp:684:4:   required from ‘HASHTABLE<T>::HASHTABLE(int)
[with T = TREE*]’
src/octree.hpp:1233:19:   required from here
src/MAL/utils/utils.hpp:691:11: warning: ‘void* memset(void*, int, size_t)’
clearing an object of non-trivial type ‘struct HASHTABLE<TREE*>::CONTAINER’;
use assignment or value-initialization instead [-Wclass-memaccess]
  691 |     memset(this->data.array, 0, sizeof(CONTAINER) *
this->data.elems());
      |     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/MAL/utils/utils.hpp:600:10: note: ‘struct HASHTABLE<TREE*>::CONTAINER’
declared here
  600 |   struct CONTAINER {
      |          ^~~~~~~~~
src/MAL/utils/utils.hpp: In instantiation of ‘void HASHTABLE<T>::reset() [with
T = LIST<GEORECT*>*]’:
src/MAL/utils/utils.hpp:684:4:   required from ‘HASHTABLE<T>::HASHTABLE(int)
[with T = LIST<GEORECT*>*]’
src/octedit.hpp:1307:30:   required from here
src/MAL/utils/utils.hpp:691:11: warning: ‘void* memset(void*, int, size_t)’
clearing an object of non-trivial type ‘struct
HASHTABLE<LIST<GEORECT*>*>::CONTAINER’; use assignment or value-initialization
instead [-Wclass-memaccess]
  691 |     memset(this->data.array, 0, sizeof(CONTAINER) *
this->data.elems());
      |     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/MAL/utils/utils.hpp:600:10: note: ‘struct
HASHTABLE<LIST<GEORECT*>*>::CONTAINER’ declared here
  600 |   struct CONTAINER {
      |          ^~~~~~~~~

[Bug c++/97658] Tired of having to change make files on every new version. Damnit!

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97658

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The compiler is telling you your code has undefined behaviour.

If you write code that conforms to the rules of the C++ language, you won't get
that warning.

Don't change your makefiles, fix your code.

I don't see any GCC bug here.

[Bug c++/97658] Tired of having to change make files on every new version. Damnit!

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97658

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
So just going to mention this, GCC adds new warnings every version as we are
trying to improve the things and warn the user about undefinedness and even
some other questionable things (which usually leads to not what the user
expects).  The warnings we add are controllable and all.

[Bug c++/97658] Tired of having to change make files on every new version. Damnit!

[hubert.vansteenhuyse at freecode dot be]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97658

--- Comment #3 from hubert.vansteenhuyse at freecode dot be ---
You are killing that marvelous gcc compiler by doing this, this is my point.

[Bug c++/97658] Tired of having to change make files on every new version. Damnit!

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97658

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Nonsense. Your code is buggy, the warning tells you about it.

If you don't want to know that your code has undefined behaviour, don't enable
warnings.