public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/97681] noinline attribute ignored on constexpr function Date: Tue, 03 Nov 2020 09:47:19 +0000 [thread overview] Message-ID: <bug-97681-4-1lDYgfcTGq@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-97681-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97681 --- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Guess that particular spot could be changed with: --- gcc/cp/typeck2.c 2020-09-12 13:36:42.500499341 +0200 +++ gcc/cp/typeck2.c 2020-11-03 10:44:10.257021110 +0100 @@ -935,9 +935,11 @@ store_init_value (tree decl, tree init, } /* Don't fold initializers of automatic variables in constexpr functions, that might fold away something that needs to be diagnosed at constexpr - evaluation time. */ + evaluation time. Don't fold initializers of automatic variables + with -O0 either. */ if (!current_function_decl - || !DECL_DECLARED_CONSTEXPR_P (current_function_decl) + || (!DECL_DECLARED_CONSTEXPR_P (current_function_decl) + && optimize) || TREE_STATIC (decl)) value = cp_fully_fold_init (value); but we have dozens if not hundreds of other places. And, just disabling constant evaluation at -O0 except in manifestly constant contexts can't really work, e.g. many of the warnings heavily relies on the foldings being possible.
next prev parent reply other threads:[~2020-11-03 9:47 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-02 21:11 [Bug c++/97681] New: " ldalessandro at gmail dot com 2020-11-02 21:15 ` [Bug c++/97681] " jakub at gcc dot gnu.org 2020-11-02 21:17 ` ldalessandro at gmail dot com 2020-11-02 21:20 ` jakub at gcc dot gnu.org 2020-11-02 21:28 ` ldalessandro at gmail dot com 2020-11-02 22:42 ` ldalessandro at gmail dot com 2020-11-03 7:23 ` rguenth at gcc dot gnu.org 2020-11-03 9:47 ` jakub at gcc dot gnu.org [this message] 2021-11-29 2:05 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-97681-4-1lDYgfcTGq@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).