public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "crazylht at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/97770] [ICELAKE]Missing vectorization for vpopcnt
Date: Fri, 04 Jun 2021 07:41:43 +0000	[thread overview]
Message-ID: <bug-97770-4-mzMqKGzX1V@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-97770-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97770

--- Comment #15 from Hongtao.liu <crazylht at gmail dot com> ---
(In reply to Richard Biener from comment #14)
> So we vectorize to
> 
>   _18 = .POPCOUNT (vect__5.7_22);
>   _17 = .POPCOUNT (vect__5.7_21);
>   vect__6.8_16 = VEC_PACK_TRUNC_EXPR <_18, _17>;
>   _6 = 0;
>   _7 = dest_13(D) + _2;
>   vect__8.9_10 = [vec_unpack_lo_expr] vect__6.8_16;
>   vect__8.9_9 = [vec_unpack_hi_expr] vect__6.8_16;
>   _8 = (long long int) _6;
> 
> which is exactly the issue that in the scalar code we have a 'int' producing
> popcount with long long argument but the vector IFN produces a result of the
> same width as the argument.  So the vectorizer compensates for that
> (VEC_PACK_TRUNC_EXPR) and then vectorizes the widening that's in the scalar
> code (vec_unpack_{lo,hi}_expr).  The fix for this and for the missing
> byte and word variants is to add a pattern to tree-vect-patterns.c for this
> case matching it to the .POPCOUNT internal function.  That possibly applies
> to other bitops, too, like parity, ctz, ffs, etc.  There's quite some
> _widen helpers in the pattern recog code so I'm not sure how complicated
> it is to match
> 
>  (long)popcountl(long)
> 
> and
> 
>  (short)popcount((int)short)
> 
> Richard may have a good idea since he did the last "big" surgery there.

Any suggestion for this, should we change prototype of builtins or add
vec_recog_popcnt_pattern in vectorizer?

  parent reply	other threads:[~2021-06-04  7:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10  2:12 [Bug target/97770] New: Missing " crazylht at gmail dot com
2020-11-10  2:14 ` [Bug target/97770] " crazylht at gmail dot com
2020-11-10  3:04 ` [Bug target/97770] [ICELAKE]Missing " crazylht at gmail dot com
2020-11-10  3:21 ` crazylht at gmail dot com
2020-11-10  8:12 ` rguenth at gcc dot gnu.org
2020-11-10  8:37 ` crazylht at gmail dot com
2020-11-10  8:55 ` rguenth at gcc dot gnu.org
2020-11-10  9:07 ` tkoenig at gcc dot gnu.org
2020-11-10 10:14 ` ubizjak at gmail dot com
2020-11-12  5:18 ` crazylht at gmail dot com
2020-11-12  7:33 ` rguenth at gcc dot gnu.org
2020-11-12  8:47 ` crazylht at gmail dot com
2020-12-03  2:03 ` cvs-commit at gcc dot gnu.org
2020-12-03  2:04 ` crazylht at gmail dot com
2020-12-03 11:24 ` [Bug tree-optimization/97770] " rguenth at gcc dot gnu.org
2021-06-04  7:41 ` crazylht at gmail dot com [this message]
2021-06-07 11:33 ` rguenth at gcc dot gnu.org
2021-06-10  3:29 ` crazylht at gmail dot com
2021-06-10  6:48 ` [Bug tree-optimization/97770] [ICELAKE]suboptimal vectorization for vpopcntw/b/q rguenther at suse dot de
2021-06-10 18:32 ` hjl.tools at gmail dot com
2021-06-11  7:25 ` rguenth at gcc dot gnu.org
2021-06-22  2:40 ` cvs-commit at gcc dot gnu.org
2021-06-22  2:46 ` crazylht at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-97770-4-mzMqKGzX1V@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).