public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/97816] [11 Regression] ICE in good_cloning_opportunity_p, at ipa-cp.c:3266 since r11-4949-gb86aedb0cc083efe712e530a723f1237051a6b56
Date: Fri, 13 Nov 2020 17:30:31 +0000 [thread overview]
Message-ID: <bug-97816-4-zwhpBFnFSz@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-97816-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97816
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Jambor <jamborm@gcc.gnu.org>:
https://gcc.gnu.org/g:2e97d6443f0a862ce9b798084499635914e3b8c6
commit r11-5000-g2e97d6443f0a862ce9b798084499635914e3b8c6
Author: Martin Jambor <mjambor@suse.cz>
Date: Fri Nov 13 18:30:11 2020 +0100
ipa-cp: One more safe_add (PR 97816)
The new behavior of safe_add triggered an ICE because of one use where
it had not been used instead of a simple addition. I'll fix it with the
following obvious patch so that periodic benchmarkers can continue
working because a proper fix (see below) will need a review.
The testcase showed me, however, that we can propagate time and cost
from one lattice to another more than once even when that was not the
intent. I'll address that as a follow-up after I verify it does not
affect the IPA-CP heuristics too much or change the corresponding
params accordingly.
Bootstrapped and tested on x86_64-linux.
gcc/ChangeLog:
2020-11-13 Martin Jambor <mjambor@suse.cz>
PR ipa/97816
* ipa-cp.c (value_topo_info<valtype>::propagate_effects): Use
safe_add instead of a simple addition.
next prev parent reply other threads:[~2020-11-13 17:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 12:08 [Bug ipa/97816] New: " marxin at gcc dot gnu.org
2020-11-13 12:09 ` [Bug ipa/97816] " marxin at gcc dot gnu.org
2020-11-13 12:10 ` marxin at gcc dot gnu.org
2020-11-13 12:16 ` marxin at gcc dot gnu.org
2020-11-13 12:41 ` jamborm at gcc dot gnu.org
2020-11-13 17:30 ` cvs-commit at gcc dot gnu.org [this message]
2020-11-13 17:31 ` jamborm at gcc dot gnu.org
2020-12-07 8:35 ` cvs-commit at gcc dot gnu.org
2020-12-07 12:04 ` jamborm at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-97816-4-zwhpBFnFSz@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).