[Bug tree-optimization/97830] New: [11 Regression] ICE in expressions_equal_p at gcc/tree-ssa-sccvn.c:5631 since r11-4982-g4d6b8d4213376e8a

[Bug tree-optimization/97830] New: [11 Regression] ICE in expressions_equal_p at gcc/tree-ssa-sccvn.c:5631 since r11-4982-g4d6b8d4213376e8a

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97830

            Bug ID: 97830
           Summary: [11 Regression] ICE in expressions_equal_p at
                    gcc/tree-ssa-sccvn.c:5631 since
                    r11-4982-g4d6b8d4213376e8a
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: rguenth at gcc dot gnu.org
  Target Milestone: ---

The following fails:

$ cat schedule.i
typedef enum { LangC } cLanguage;
typedef enum { FunctionOneArg, FunctionStandard } cFunctionType;
void *CCTK_CallFunction_function;
cLanguage CCTK_CallFunction_fdata_0;
cFunctionType CCTK_CallFunction_fdata_1;
void CCTK_CallFunction_data() {
  void (*standardfunc)();
  int (*oneargfunc)();
  switch (CCTK_CallFunction_fdata_1) {
  case FunctionOneArg:
    oneargfunc = CCTK_CallFunction_function;
    oneargfunc(CCTK_CallFunction_data);
    break;
  case FunctionStandard:
    switch (CCTK_CallFunction_fdata_0) {
    case LangC:
      standardfunc = CCTK_CallFunction_function;
      standardfunc(CCTK_CallFunction_data);
    }
  }
}

$ gcc schedule.i -c -O2
during GIMPLE pass: pre
schedule.i: In function 'CCTK_CallFunction_data':
schedule.i:6:6: internal compiler error: Segmentation fault
    6 | void CCTK_CallFunction_data() {
      |      ^~~~~~~~~~~~~~~~~~~~~~
0x13be442 crash_signal
        /home/marxin/Programming/gcc/gcc/toplev.c:330
0x7ffff7889d1f ???
       
/usr/src/debug/glibc-2.32-2.1.x86_64/signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0
0x16badca expressions_equal_p(tree_node*, tree_node*)
        /home/marxin/Programming/gcc/gcc/tree-ssa-sccvn.c:5631
0x16a9f5f vn_reference_eq(vn_reference_s const*, vn_reference_s const*)
        /home/marxin/Programming/gcc/gcc/tree-ssa-sccvn.c:705
0x16c5e86 vn_reference_hasher::equal(vn_reference_s const*, vn_reference_s
const*)
        /home/marxin/Programming/gcc/gcc/tree-ssa-sccvn.c:246
0x16c6c45 hash_table<vn_reference_hasher, false,
xcallocator>::find_slot_with_hash(vn_reference_s* const&, unsigned int,
insert_option)
        /home/marxin/Programming/gcc/gcc/hash-table.h:981
0x16ad9fa vn_reference_lookup_1
        /home/marxin/Programming/gcc/gcc/tree-ssa-sccvn.c:1645
0x16b4137 vn_reference_lookup_call(gcall*, vn_reference_s**, vn_reference_s*)
        /home/marxin/Programming/gcc/gcc/tree-ssa-sccvn.c:3579
0x16b8a1f visit_reference_op_call
        /home/marxin/Programming/gcc/gcc/tree-ssa-sccvn.c:4897
0x16ba84c visit_stmt
        /home/marxin/Programming/gcc/gcc/tree-ssa-sccvn.c:5503
0x16c08d2 process_bb
        /home/marxin/Programming/gcc/gcc/tree-ssa-sccvn.c:7110
0x16c29bc do_rpo_vn
        /home/marxin/Programming/gcc/gcc/tree-ssa-sccvn.c:7597
0x16bf041 run_rpo_vn(vn_lookup_kind)
        /home/marxin/Programming/gcc/gcc/tree-ssa-sccvn.c:6684
0x1677f18 execute
        /home/marxin/Programming/gcc/gcc/tree-ssa-pre.c:4392
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug tree-optimization/97830] [11 Regression] ICE in expressions_equal_p at gcc/tree-ssa-sccvn.c:5631 since r11-4982-g4d6b8d4213376e8a

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97830

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
           Priority|P3                          |P1
   Last reconfirmed|                            |2020-11-14
             Blocks|                            |26163
      Known to work|                            |10.2.0
      Known to fail|                            |11.0
   Target Milestone|---                         |11.0
     Ever confirmed|0                           |1

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Seen in a SPEC benchmark 436.cactusADM.


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=26163
[Bug 26163] [meta-bug] missed optimization in SPEC (2k17, 2k and 2k6 and 95)

[Bug tree-optimization/97830] [11 Regression] ICE in expressions_equal_p at gcc/tree-ssa-sccvn.c:5631 since r11-4982-g4d6b8d4213376e8a

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97830

David Binderman <dcb314 at hotmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcb314 at hotmail dot com

--- Comment #2 from David Binderman <dcb314 at hotmail dot com> ---
I see this also. I will make a reproducer.

[Bug tree-optimization/97830] [11 Regression] ICE in expressions_equal_p at gcc/tree-ssa-sccvn.c:5631 since r11-4982-g4d6b8d4213376e8a

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97830

--- Comment #3 from David Binderman <dcb314 at hotmail dot com> ---

Reduced C code is:

a;
b() {
  ((void (*)())b)(a);
  b(a);
}

Interestingly, this similar code

int a;
void b() {
  ((void (*)())b)(a);
  b(a);
}

compiles fine.

[Bug tree-optimization/97830] [11 Regression] ICE in expressions_equal_p at gcc/tree-ssa-sccvn.c:5631 since r11-4982-g4d6b8d4213376e8a

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97830

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.

[Bug tree-optimization/97830] [11 Regression] ICE in expressions_equal_p at gcc/tree-ssa-sccvn.c:5631 since r11-4982-g4d6b8d4213376e8a

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97830

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |seurer at gcc dot gnu.org

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
*** Bug 97845 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/97830] [11 Regression] ICE in expressions_equal_p at gcc/tree-ssa-sccvn.c:5631 since r11-4982-g4d6b8d4213376e8a

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97830

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:aaccdb9cec423ef4de9d541dbe0a95fa3346f430

commit r11-5047-gaaccdb9cec423ef4de9d541dbe0a95fa3346f430
Author: Richard Biener <rguenther@suse.de>
Date:   Mon Nov 16 08:40:47 2020 +0100

    tree-optimization/97830 - fix compare of incomplete type size in VN

    This avoids passing NULL to expressions_equal_p.

    2020-11-16  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/97830
            * tree-ssa-sccvn.c (vn_reference_eq): Check for incomplete
            types before comparing TYPE_SIZE.

            * gcc.dg/pr97830.c: New testcase.

[Bug tree-optimization/97830] [11 Regression] ICE in expressions_equal_p at gcc/tree-ssa-sccvn.c:5631 since r11-4982-g4d6b8d4213376e8a

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97830

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.