[Bug target/97847] New: [11 Regression] ICE in insert_insn_on_edge, at cfgrtl.c:1976

[Bug target/97847] New: [11 Regression] ICE in insert_insn_on_edge, at cfgrtl.c:1976

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97847

            Bug ID: 97847
           Summary: [11 Regression] ICE in insert_insn_on_edge, at
                    cfgrtl.c:1976
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: segher at gcc dot gnu.org
  Target Milestone: ---
              Host: x86_64-linux
            Target: ppc64-linux-gnu

The following fails:

$ ppc64-linux-gnu-gcc
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/pr32919.c
-mno-speculate-indirect-jumps
cc1: warning: ‘-mno-speculate-indirect-jumps’ is deprecated and not recommended
in any circumstances
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/pr32919.c: In
function ‘_IO_vfprintf_internal’:
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/pr32919.c:13:6:
warning: implicit declaration of function ‘read_int’
[-Wimplicit-function-declaration]
   13 |      read_int (&f);
      |      ^~~~~~~~
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/pr32919.c:15:5:
warning: implicit declaration of function ‘_itoa_word’
[-Wimplicit-function-declaration]
   15 |     _itoa_word (spec);
      |     ^~~~~~~~~~
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/pr32919.c:23:7:
warning: implicit declaration of function ‘__strnlen’
[-Wimplicit-function-declaration]
   23 |       __strnlen ();
      |       ^~~~~~~~~
during RTL pass: ira
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/pr32919.c:28:1:
internal compiler error: in insert_insn_on_edge, at cfgrtl.c:1976
   28 | }
      | ^
0x5af1a8 insert_insn_on_edge(rtx_def*, edge_def*)
       
/home/marxin/BIG/buildbot/buildworker/marxinbox-gcc-trunk-ppc64/build/gcc/cfgrtl.c:1976
0x94775d ira
       
/home/marxin/BIG/buildbot/buildworker/marxinbox-gcc-trunk-ppc64/build/gcc/ira.c:5438
0x94775d execute
       
/home/marxin/BIG/buildbot/buildworker/marxinbox-gcc-trunk-ppc64/build/gcc/ira.c:5943
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug target/97847] [11 Regression] ICE in insert_insn_on_edge, at cfgrtl.c:1976

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97847

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Target Milestone|---                         |11.0
   Last reconfirmed|                            |2020-11-16

[Bug target/97847] [11 Regression] ICE in insert_insn_on_edge, at cfgrtl.c:1976

[segher at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97847

Segher Boessenkool <segher at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING

--- Comment #1 from Segher Boessenkool <segher at gcc dot gnu.org> ---
I cannot reproduce this?  Not with any -mcpu= either, or any -O option.

[Bug target/97847] [11 Regression] ICE in insert_insn_on_edge, at cfgrtl.c:1976

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97847

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
I've just reproduced that on gcc110 machine with the following revision
g:4b81528241ca682025d92558ff6aeec91dafdca8

$ ./xgcc -v
Using built-in specs.
COLLECT_GCC=./xgcc
Target: powerpc64-unknown-linux-gnu
Configured with: ../configure --disable-bootstrap --enable-languages=c,c++,lto
--prefix=/home/marxin/bin/gcc
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 11.0.0 20201118 (experimental) (GCC) 

$ ./xgcc -B.
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/pr32919.c
-mno-speculate-indirect-jumps -c --verbose
Reading specs from ./specs
COLLECT_GCC=./xgcc
Target: powerpc64-unknown-linux-gnu
Configured with: ../configure --disable-bootstrap --enable-languages=c,c++,lto
--prefix=/home/marxin/bin/gcc
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 11.0.0 20201118 (experimental) (GCC) 
COLLECT_GCC_OPTIONS='-B' '.' '-mno-speculate-indirect-jumps' '-c' '-v'
 ./cc1 -quiet -v -iprefix
/home/marxin/Programming/gcc/objdir/gcc/../lib/gcc/powerpc64-unknown-linux-gnu/11.0.0/
-isystem ./include -isystem ./include-fixed
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/pr32919.c
-quiet -dumpbase pr32919.c -dumpbase-ext .c -mno-speculate-indirect-jumps
-version -o /tmp/cc35CrAT.s
GNU C17 (GCC) version 11.0.0 20201118 (experimental)
(powerpc64-unknown-linux-gnu)
        compiled by GNU C version 4.8.5 20150623 (Red Hat 4.8.5-39), GMP
version 6.0.0, MPFR version 3.1.1, MPC version 1.0.1, isl version none
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
ignoring nonexistent directory
"/home/marxin/Programming/gcc/objdir/gcc/../lib/gcc/powerpc64-unknown-linux-gnu/11.0.0/include"
ignoring nonexistent directory
"/home/marxin/Programming/gcc/objdir/gcc/../lib/gcc/powerpc64-unknown-linux-gnu/11.0.0/include-fixed"
ignoring nonexistent directory
"/home/marxin/Programming/gcc/objdir/gcc/../lib/gcc/powerpc64-unknown-linux-gnu/11.0.0/../../../../powerpc64-unknown-linux-gnu/include"
ignoring nonexistent directory
"/home/marxin/Programming/gcc/objdir/gcc/../lib/gcc/../../lib/gcc/powerpc64-unknown-linux-gnu/11.0.0/include"
ignoring nonexistent directory
"/home/marxin/Programming/gcc/objdir/gcc/../lib/gcc/../../include"
ignoring nonexistent directory
"/home/marxin/Programming/gcc/objdir/gcc/../lib/gcc/../../lib/gcc/powerpc64-unknown-linux-gnu/11.0.0/include-fixed"
ignoring nonexistent directory
"/home/marxin/Programming/gcc/objdir/gcc/../lib/gcc/../../lib/gcc/powerpc64-unknown-linux-gnu/11.0.0/../../../../powerpc64-unknown-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:
 ./include
 ./include-fixed
 /usr/local/include
 /usr/include
End of search list.
cc1: warning: ‘-mno-speculate-indirect-jumps’ is deprecated and not recommended
in any circumstances
GNU C17 (GCC) version 11.0.0 20201118 (experimental)
(powerpc64-unknown-linux-gnu)
        compiled by GNU C version 4.8.5 20150623 (Red Hat 4.8.5-39), GMP
version 6.0.0, MPFR version 3.1.1, MPC version 1.0.1, isl version none
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
Compiler executable checksum: 7d94193eb0258434742b800b3306907a
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/pr32919.c: In
function ‘_IO_vfprintf_internal’:
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/pr32919.c:13:6:
warning: implicit declaration of function ‘read_int’
[-Wimplicit-function-declaration]
   13 |      read_int (&f);
      |      ^~~~~~~~
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/pr32919.c:15:5:
warning: implicit declaration of function ‘_itoa_word’
[-Wimplicit-function-declaration]
   15 |     _itoa_word (spec);
      |     ^~~~~~~~~~
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/pr32919.c:23:7:
warning: implicit declaration of function ‘__strnlen’
[-Wimplicit-function-declaration]
   23 |       __strnlen ();
      |       ^~~~~~~~~
during RTL pass: ira
/home/marxin/Programming/gcc/gcc/testsuite/gcc.c-torture/compile/pr32919.c:28:1:
internal compiler error: in ira, at ira.c:5432
   28 | }
      | ^
0x10839583 ira
        ../../gcc/ira.c:5432
0x10839583 execute
        ../../gcc/ira.c:5945
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug target/97847] [11 Regression] ICE in insert_insn_on_edge, at cfgrtl.c:1976

[segher at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97847

--- Comment #3 from Segher Boessenkool <segher at gcc dot gnu.org> ---
I can now reproduce it, with a compiler built yesterday (previous was a
few days older), and -O0.

Confirmed.

[Bug target/97847] [11 Regression] ICE in insert_insn_on_edge, at cfgrtl.c:1976

[segher at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97847

--- Comment #4 from Segher Boessenkool <segher at gcc dot gnu.org> ---
This was caused (or exposed) by e3b3b59683c1:

commit e3b3b59683c1e7d31a9d313dd97394abebf644be
Author: Vladimir N. Makarov <vmakarov@redhat.com>
Date:   Fri Nov 13 12:45:59 2020 -0500

    [PATCH] Implementation of asm goto outputs

[Bug target/97847] [11 Regression] ICE in insert_insn_on_edge, at cfgrtl.c:1976

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97847

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
@Vladimir: Can you please take a look?

[Bug target/97847] [11 Regression] ICE in insert_insn_on_edge, at cfgrtl.c:1976

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97847

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug target/97847] [11 Regression] ICE in insert_insn_on_edge, at cfgrtl.c:1976

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97847

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |vmakarov at gcc dot gnu.org

[Bug target/97847] [11 Regression] ICE in insert_insn_on_edge, at cfgrtl.c:1976

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97847

--- Comment #6 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
I've reproduced the bug too.  The fix will be on the next week.

[Bug target/97847] [11 Regression] ICE in insert_insn_on_edge, at cfgrtl.c:1976

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97847

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Vladimir Makarov <vmakarov@gcc.gnu.org>:

https://gcc.gnu.org/g:a89c5d3539c36f160ca5b997324ebcd3d601d56e

commit r11-6778-ga89c5d3539c36f160ca5b997324ebcd3d601d56e
Author: Vladimir N. Makarov <vmakarov@redhat.com>
Date:   Mon Jan 18 16:41:39 2021 -0500

    [PR97847] IRA: Skip abnormal critical edge splitting

    PPC64 can generate jumps with clobbered pseudo-regs and a BB with
    such jump can have abnormal output edges.  IRA hits an assert when trying
    to split abnormal critical edge to deal with asm goto output reloads
    later.  The patch just skips splitting abnormal edges.  It is assumed
    that asm-goto with output reloads can not be in BB with output abnormal
edges.

    gcc/ChangeLog:

            PR target/97847
            * ira.c (ira): Skip abnormal critical edge splitting.

[Bug target/97847] [11 Regression] ICE in insert_insn_on_edge, at cfgrtl.c:1976

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97847

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
                 CC|                            |jakub at gcc dot gnu.org
         Resolution|---                         |FIXED

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.