[Bug objc/97854] New: [11 regression] ODR violation in stub-objc.c

[Bug objc/97854] New: [11 regression] ODR violation in stub-objc.c

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97854

            Bug ID: 97854
           Summary: [11 regression] ODR violation in stub-objc.c
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: objc
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hubicka at gcc dot gnu.org
  Target Milestone: ---

stub-objc provides dummy RID enum which causes ODR violation.
This produces warnings with lto-bootstrap:

../../gcc/c-family/c-common.h:63: warning: type ‘rid’ violates the C++ One
Definition Rule [-Wodr]
   63 | enum rid
      |
../../gcc/c-family/stub-objc.c:30: note: an enum with different value name is
defined in another translation unit
   30 | enum rid { DUMMY };
      |
../../gcc/c-family/c-common.h:67: note: name ‘RID_STATIC’ differs from name
‘DUMMY’ defined in another translation unit
   67 |   RID_STATIC = 0,
      |
../../gcc/c-family/stub-objc.c:30: note: mismatching definition
   30 | enum rid { DUMMY };
      |
../../gcc/c-family/c-common.h:63: warning: type ‘rid’ violates the C++ One
Definition Rule [-Wodr]
   63 | enum rid
      |
../../gcc/c-family/stub-objc.c:30: note: an enum with different value name is
defined in another translation unit
   30 | enum rid { DUMMY };
      |
../../gcc/c-family/c-common.h:67: note: name ‘RID_STATIC’ differs from name
‘DUMMY’ defined in another translation unit
   67 |   RID_STATIC = 0,
      |
../../gcc/c-family/stub-objc.c:30: note: mismatching definition
   30 | enum rid { DUMMY };
      |

I think this was introduced in g:9a34a5cce6b50fc3527e7c7ab356808ed435883c

[Bug objc/97854] [11 regression] ODR violation in stub-objc.c

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97854

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0
            Version|unknown                     |11.0
                 CC|                            |iains at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Yes, I already noticed Iains.

[Bug objc/97854] [11 regression] ODR violation in stub-objc.c

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97854

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2020-11-16

[Bug objc/97854] [11 regression] ODR violation in stub-objc.c

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97854

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>:

https://gcc.gnu.org/g:814e016318646d06b1662219cc716d502b76d8ce

commit r11-5065-g814e016318646d06b1662219cc716d502b76d8ce
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Mon Nov 16 19:33:35 2020 +0000

    C-family : Fix a C++ ODR violation [PR97854].

    The changes in r11-4799 introduced a dummy enum rid type with
    a different initial member name to the actual version (an ODR
    violation).  Fixed by including the header declaring the
    actual type.

    gcc/c-family/ChangeLog:

            PR objc/97854
            * stub-objc.c: Include c-common.h to declare enum rid.

[Bug objc/97854] [11 regression] ODR violation in stub-objc.c

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97854

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
fixed then

[Bug objc/97854] [11 regression] ODR violation in stub-objc.c

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97854

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:5dd5507265e3b7fecd775a106a20762a5e828421

commit r10-10805-g5dd5507265e3b7fecd775a106a20762a5e828421
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Mon Nov 16 19:33:35 2020 +0000

    C-family : Fix a C++ ODR violation [PR97854].

    The changes in r11-4799 introduced a dummy enum rid type with
    a different initial member name to the actual version (an ODR
    violation).  Fixed by including the header declaring the
    actual type.

    gcc/c-family/ChangeLog:

            PR objc/97854
            * stub-objc.c: Include c-common.h to declare enum rid.

    (cherry picked from commit 814e016318646d06b1662219cc716d502b76d8ce)