public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug objc/97854] New: [11 regression] ODR violation in stub-objc.c @ 2020-11-16 16:51 hubicka at gcc dot gnu.org 2020-11-16 19:36 ` [Bug objc/97854] " marxin at gcc dot gnu.org ` (4 more replies) 0 siblings, 5 replies; 6+ messages in thread From: hubicka at gcc dot gnu.org @ 2020-11-16 16:51 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97854 Bug ID: 97854 Summary: [11 regression] ODR violation in stub-objc.c Product: gcc Version: unknown Status: UNCONFIRMED Severity: normal Priority: P3 Component: objc Assignee: unassigned at gcc dot gnu.org Reporter: hubicka at gcc dot gnu.org Target Milestone: --- stub-objc provides dummy RID enum which causes ODR violation. This produces warnings with lto-bootstrap: ../../gcc/c-family/c-common.h:63: warning: type ‘rid’ violates the C++ One Definition Rule [-Wodr] 63 | enum rid | ../../gcc/c-family/stub-objc.c:30: note: an enum with different value name is defined in another translation unit 30 | enum rid { DUMMY }; | ../../gcc/c-family/c-common.h:67: note: name ‘RID_STATIC’ differs from name ‘DUMMY’ defined in another translation unit 67 | RID_STATIC = 0, | ../../gcc/c-family/stub-objc.c:30: note: mismatching definition 30 | enum rid { DUMMY }; | ../../gcc/c-family/c-common.h:63: warning: type ‘rid’ violates the C++ One Definition Rule [-Wodr] 63 | enum rid | ../../gcc/c-family/stub-objc.c:30: note: an enum with different value name is defined in another translation unit 30 | enum rid { DUMMY }; | ../../gcc/c-family/c-common.h:67: note: name ‘RID_STATIC’ differs from name ‘DUMMY’ defined in another translation unit 67 | RID_STATIC = 0, | ../../gcc/c-family/stub-objc.c:30: note: mismatching definition 30 | enum rid { DUMMY }; | I think this was introduced in g:9a34a5cce6b50fc3527e7c7ab356808ed435883c ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug objc/97854] [11 regression] ODR violation in stub-objc.c 2020-11-16 16:51 [Bug objc/97854] New: [11 regression] ODR violation in stub-objc.c hubicka at gcc dot gnu.org @ 2020-11-16 19:36 ` marxin at gcc dot gnu.org 2020-11-16 19:36 ` marxin at gcc dot gnu.org ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: marxin at gcc dot gnu.org @ 2020-11-16 19:36 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97854 Martin Liška <marxin at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |11.0 Version|unknown |11.0 CC| |iains at gcc dot gnu.org, | |marxin at gcc dot gnu.org --- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> --- Yes, I already noticed Iains. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug objc/97854] [11 regression] ODR violation in stub-objc.c 2020-11-16 16:51 [Bug objc/97854] New: [11 regression] ODR violation in stub-objc.c hubicka at gcc dot gnu.org 2020-11-16 19:36 ` [Bug objc/97854] " marxin at gcc dot gnu.org @ 2020-11-16 19:36 ` marxin at gcc dot gnu.org 2020-11-16 21:38 ` cvs-commit at gcc dot gnu.org ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: marxin at gcc dot gnu.org @ 2020-11-16 19:36 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97854 Martin Liška <marxin at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Last reconfirmed| |2020-11-16 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug objc/97854] [11 regression] ODR violation in stub-objc.c 2020-11-16 16:51 [Bug objc/97854] New: [11 regression] ODR violation in stub-objc.c hubicka at gcc dot gnu.org 2020-11-16 19:36 ` [Bug objc/97854] " marxin at gcc dot gnu.org 2020-11-16 19:36 ` marxin at gcc dot gnu.org @ 2020-11-16 21:38 ` cvs-commit at gcc dot gnu.org 2020-11-17 7:01 ` rguenth at gcc dot gnu.org 2022-05-31 18:13 ` cvs-commit at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2020-11-16 21:38 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97854 --- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>: https://gcc.gnu.org/g:814e016318646d06b1662219cc716d502b76d8ce commit r11-5065-g814e016318646d06b1662219cc716d502b76d8ce Author: Iain Sandoe <iain@sandoe.co.uk> Date: Mon Nov 16 19:33:35 2020 +0000 C-family : Fix a C++ ODR violation [PR97854]. The changes in r11-4799 introduced a dummy enum rid type with a different initial member name to the actual version (an ODR violation). Fixed by including the header declaring the actual type. gcc/c-family/ChangeLog: PR objc/97854 * stub-objc.c: Include c-common.h to declare enum rid. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug objc/97854] [11 regression] ODR violation in stub-objc.c 2020-11-16 16:51 [Bug objc/97854] New: [11 regression] ODR violation in stub-objc.c hubicka at gcc dot gnu.org ` (2 preceding siblings ...) 2020-11-16 21:38 ` cvs-commit at gcc dot gnu.org @ 2020-11-17 7:01 ` rguenth at gcc dot gnu.org 2022-05-31 18:13 ` cvs-commit at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: rguenth at gcc dot gnu.org @ 2020-11-17 7:01 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97854 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> --- fixed then ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug objc/97854] [11 regression] ODR violation in stub-objc.c 2020-11-16 16:51 [Bug objc/97854] New: [11 regression] ODR violation in stub-objc.c hubicka at gcc dot gnu.org ` (3 preceding siblings ...) 2020-11-17 7:01 ` rguenth at gcc dot gnu.org @ 2022-05-31 18:13 ` cvs-commit at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2022-05-31 18:13 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97854 --- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-10 branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>: https://gcc.gnu.org/g:5dd5507265e3b7fecd775a106a20762a5e828421 commit r10-10805-g5dd5507265e3b7fecd775a106a20762a5e828421 Author: Iain Sandoe <iain@sandoe.co.uk> Date: Mon Nov 16 19:33:35 2020 +0000 C-family : Fix a C++ ODR violation [PR97854]. The changes in r11-4799 introduced a dummy enum rid type with a different initial member name to the actual version (an ODR violation). Fixed by including the header declaring the actual type. gcc/c-family/ChangeLog: PR objc/97854 * stub-objc.c: Include c-common.h to declare enum rid. (cherry picked from commit 814e016318646d06b1662219cc716d502b76d8ce) ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-31 18:13 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-11-16 16:51 [Bug objc/97854] New: [11 regression] ODR violation in stub-objc.c hubicka at gcc dot gnu.org 2020-11-16 19:36 ` [Bug objc/97854] " marxin at gcc dot gnu.org 2020-11-16 19:36 ` marxin at gcc dot gnu.org 2020-11-16 21:38 ` cvs-commit at gcc dot gnu.org 2020-11-17 7:01 ` rguenth at gcc dot gnu.org 2022-05-31 18:13 ` cvs-commit at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).