[Bug ada/97859] New: [11 Regression] bootstrap error building a gnat cross compiler targeting ppc64le on x86_64-linux-gnu

[Bug ada/97859] New: [11 Regression] bootstrap error building a gnat cross compiler targeting ppc64le on x86_64-linux-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97859

            Bug ID: 97859
           Summary: [11 Regression] bootstrap error building a gnat cross
                    compiler targeting ppc64le on x86_64-linux-gnu
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at debian dot org
  Target Milestone: ---

seen with trunk 20201114:

[...]
/usr/powerpc64le-linux-gnu/bin/ld: a-nbnbin.o: in function
`ada__numerics__big_numbers__big_integers__
from_string':
/packages/cross/11/gcc-cross/gcc/build/gcc/ada/rts/a-nbnbin.adb:242: undefined
reference to `system__v
al_llli__impl__value_integer'
collect2: error: ld returned 1 exit status
make[7]: *** [gcc-interface/Makefile:674: gnatlib-shared-default] Error 1

[Bug ada/97859] [11 Regression] bootstrap error building a gnat cross compiler targeting ppc64le on x86_64-linux-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97859

--- Comment #1 from Matthias Klose <doko at debian dot org> ---
targeting aarch64-linux-gnu with the same version works

[Bug ada/97859] [11 Regression] bootstrap error building a gnat cross compiler targeting ppc64le on x86_64-linux-gnu

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97859

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0

[Bug ada/97859] [11 Regression] bootstrap error building a gnat cross compiler targeting ppc64le on x86_64-linux-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97859

--- Comment #2 from Matthias Klose <doko at debian dot org> ---
targeting powerpc-linux-gnu also works

[Bug ada/97859] [11 Regression] bootstrap error building a gnat cross compiler targeting ppc64le on x86_64-linux-gnu

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97859

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2020-11-17
                 CC|                            |ebotcazou at gcc dot gnu.org

--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
It should be defined there though:

eric@fomalhaut:~/build/gcc/native/gcc/ada/rts> nm s-valllli.o
0000000000000000 D system__val_llli_E
0000000000000000 T system__val_llli__impl__scan_integer
00000000000000f0 T system__val_llli__impl__value_integer
                 U system__val_lllu__impl__scan_raw_unsigned
                 U system__val_util__bad_value
                 U system__val_util__scan_sign
                 U system__val_util__scan_trailing_blanks

In any case, the output of 'gcc -v' would be helpful as always.

[Bug ada/97859] [11 Regression] bootstrap error building a gnat cross compiler targeting ppc64le on x86_64-linux-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97859

--- Comment #4 from Matthias Klose <doko at debian dot org> ---
hmm, that file doesn't exist for the cross build.

$ find -name 's-val*.o'
./build/gcc/ada/libgnat/s-valint.o
./build/gcc/ada/libgnat/s-valuti.o
./build/gcc/ada/libgnat/s-valuns.o
./build/gcc/ada/rts/s-valdec.o
./build/gcc/ada/rts/s-valueu.o
./build/gcc/ada/rts/s-valboo.o
./build/gcc/ada/rts/s-valuei.o
./build/gcc/ada/rts/s-vallli.o
./build/gcc/ada/rts/s-valint.o
./build/gcc/ada/rts/s-valuti.o
./build/gcc/ada/rts/s-valwch.o
./build/gcc/ada/rts/s-valuns.o
./build/gcc/ada/rts/s-valrea.o
./build/gcc/ada/rts/s-valcha.o
./build/gcc/ada/rts/s-valllu.o
./build/gcc/ada/rts/s-valenu.o
./build/gcc/ada/rts/s-vallld.o

but it's build in a native build.

$ build/gcc/xgcc -v
Using built-in specs.
COLLECT_GCC=build/gcc/xgcc
OFFLOAD_TARGET_NAMES=nvptx-none
Target: powerpc64le-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Debian 11-20201117-1'
--with-bugurl=file:///usr/share/doc/gcc-11/README.Bugs
--enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++ --prefix=/usr
--with-gcc-major-version-only --program-suffix=-11 --enable-shared
--enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext
--enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/
--enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes
--with-default-libstdcxx-abi=new --enable-gnu-unique-object --enable-plugin
--enable-default-pie --with-system-zlib --enable-libphobos-checking=release
--without-target-system-zlib --enable-secureplt --with-cpu=power8
--enable-targets=powerpcle-linux --disable-multilib --enable-multiarch
--disable-werror --with-long-double-128
--enable-offload-targets=nvptx-none=/packages/cross/11/gcc-cross/gcc/debian/tmp-nvptx/usr
--enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu
--target=powerpc64le-linux-gnu --program-prefix=powerpc64le-linux-gnu-
--includedir=/usr/powerpc64le-linux-gnu/include
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 11.0.0 20201117 (experimental) [master revision
c2cf58f0e3a:4924d184b2a:a5f9c27bfc4417224e332392bb81a2d733b2b5bf] (Debian
11-20201117-1)

[Bug ada/97859] [11 Regression] bootstrap error building a gnat cross compiler targeting ppc64le on x86_64-linux-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97859

--- Comment #5 from Matthias Klose <doko at debian dot org> ---
target_cpu is powerpc64le

Makefile.rtl:

    ifeq ($(strip $(filter-out powerpc64,$(target_cpu))),)
      ifneq ($(strip $(MULTISUBDIR)),/ppc)
        LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)
        EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)
      else
        SO_OPTS += -m32
      endif
    else
      ifeq ($(strip $(MULTISUBDIR)),/ppc64)
        SO_OPTS += -m64
        LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)
        EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)
      endif
    endif
  endif

looks like this logic makes the assumption that any power architecture is
always mutilib'd, which is only true for powerpc-linux-gnu and
powerpc64-linux-gnu, but not powerpc64le-linux-gnu.

I didn't check where else this assumption is made.

[Bug ada/97859] [11 Regression] bootstrap error building a gnat cross compiler targeting ppc64le on x86_64-linux-gnu

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97859

--- Comment #6 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> target_cpu is powerpc64le
> 
> Makefile.rtl:
> 
>     ifeq ($(strip $(filter-out powerpc64,$(target_cpu))),)
>       ifneq ($(strip $(MULTISUBDIR)),/ppc)
>         LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)
>         EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)
>       else
>         SO_OPTS += -m32
>       endif
>     else
>       ifeq ($(strip $(MULTISUBDIR)),/ppc64)
>         SO_OPTS += -m64
>         LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)
>         EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)
>       endif
>     endif
>   endif

It's the MacOS section though.

Can you replace "powerpc64" with "powerpc64%" in the Linux section?

  ifeq ($(strip $(filter-out powerpc64,$(target_cpu))),)
    ifneq ($(strip $(MULTISUBDIR)),/32)
      LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)
      EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)
    endif
  else
    ifeq ($(strip $(MULTISUBDIR)),/64)
      LIBGNAT_TARGET_PAIRS += $(GNATRTL_128BIT_PAIRS)
      EXTRA_GNATRTL_NONTASKING_OBJS += $(GNATRTL_128BIT_OBJS)
    endif
  endif

[Bug ada/97859] [11 Regression] bootstrap error building a gnat cross compiler targeting ppc64le on x86_64-linux-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97859

--- Comment #7 from Matthias Klose <doko at debian dot org> ---
patch posted at
https://gcc.gnu.org/pipermail/gcc-patches/2020-November/559485.html

the build succeeds

[Bug ada/97859] [11 Regression] bootstrap error building a gnat cross compiler targeting ppc64le on x86_64-linux-gnu

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97859

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Matthias Klose <doko@gcc.gnu.org>:

https://gcc.gnu.org/g:ba97b532604815333848ee30e069dde6e36ce4c9

commit r11-5129-gba97b532604815333848ee30e069dde6e36ce4c9
Author: Matthias Klose <doko@ubuntu.com>
Date:   Wed Nov 18 13:24:33 2020 +0100

    Fix PR ada/97859, building ada cross compiler targeting
powerpc64le-linux-gnu

    2020-11-18  Matthias Klose  <doko@ubuntu.com>

            PR ada/97859
            * Makefile.rtl (powerpc% linux%): Also match powerpc64le cpu.

[Bug ada/97859] [11 Regression] bootstrap error building a gnat cross compiler targeting ppc64le on x86_64-linux-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97859

Matthias Klose <doko at debian dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|WAITING                     |RESOLVED