public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/97869] New: <version> defines __cpp_lib_span even when <span> doesn't provide an implementation
@ 2020-11-17 4:09 rs2740 at gmail dot com
2020-11-17 7:27 ` [Bug libstdc++/97869] " redi at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: rs2740 at gmail dot com @ 2020-11-17 4:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97869
Bug ID: 97869
Summary: <version> defines __cpp_lib_span even when <span>
doesn't provide an implementation
Product: gcc
Version: 11.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
Assignee: unassigned at gcc dot gnu.org
Reporter: rs2740 at gmail dot com
Target Milestone: ---
<version> defines __cpp_lib_span if __cplusplus > 201703L and _GLIBCXX_HOSTED,
but <span> only provides a definition of std::span when __cpp_lib_concepts is
defined.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libstdc++/97869] <version> defines __cpp_lib_span even when <span> doesn't provide an implementation
2020-11-17 4:09 [Bug libstdc++/97869] New: <version> defines __cpp_lib_span even when <span> doesn't provide an implementation rs2740 at gmail dot com
@ 2020-11-17 7:27 ` redi at gcc dot gnu.org
2020-11-17 14:18 ` redi at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2020-11-17 7:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97869
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |10.3
Status|UNCONFIRMED |NEW
Last reconfirmed| |2020-11-17
Ever confirmed|0 |1
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libstdc++/97869] <version> defines __cpp_lib_span even when <span> doesn't provide an implementation
2020-11-17 4:09 [Bug libstdc++/97869] New: <version> defines __cpp_lib_span even when <span> doesn't provide an implementation rs2740 at gmail dot com
2020-11-17 7:27 ` [Bug libstdc++/97869] " redi at gcc dot gnu.org
@ 2020-11-17 14:18 ` redi at gcc dot gnu.org
2020-11-17 16:13 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2020-11-17 14:18 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97869
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |redi at gcc dot gnu.org
--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Oops. JeanHeyd's original <span> worked without concepts, so the definition in
<version> was correct. We modified <span> later to be empty unless concepts are
supported.
I have a script to check the macros, but I only have clang 10.0 installed,
which defines __cpp_concepts.
It looks like we also have a discrepancy for __cpp_lib_coroutine.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libstdc++/97869] <version> defines __cpp_lib_span even when <span> doesn't provide an implementation
2020-11-17 4:09 [Bug libstdc++/97869] New: <version> defines __cpp_lib_span even when <span> doesn't provide an implementation rs2740 at gmail dot com
2020-11-17 7:27 ` [Bug libstdc++/97869] " redi at gcc dot gnu.org
2020-11-17 14:18 ` redi at gcc dot gnu.org
@ 2020-11-17 16:13 ` cvs-commit at gcc dot gnu.org
2020-11-18 13:03 ` cvs-commit at gcc dot gnu.org
2020-11-18 13:04 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-11-17 16:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97869
--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:ecf65330c11544ebf35e198087b4a42be089c620
commit r11-5099-gecf65330c11544ebf35e198087b4a42be089c620
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Nov 17 15:26:29 2020 +0000
libstdc++: Fix unconditional definition of __cpp_lib_span in <version> [PR
97869}
The <span> header is empty unless Concepts are supported, but <version>
defines the __cpp_lib_span feature test macro unconditionally. It should
be guarded by the same conditions as in <span>.
libstdc++-v3/ChangeLog:
PR libstdc++/97869
* include/precompiled/stdc++.h: Include <coroutine>.
* include/std/version (__cpp_lib_span): Check __cpp_lib_concepts
before defining.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libstdc++/97869] <version> defines __cpp_lib_span even when <span> doesn't provide an implementation
2020-11-17 4:09 [Bug libstdc++/97869] New: <version> defines __cpp_lib_span even when <span> doesn't provide an implementation rs2740 at gmail dot com
` (2 preceding siblings ...)
2020-11-17 16:13 ` cvs-commit at gcc dot gnu.org
@ 2020-11-18 13:03 ` cvs-commit at gcc dot gnu.org
2020-11-18 13:04 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-11-18 13:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97869
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:992643655c872f8332f9e8e453631a8fad52943a
commit r10-9044-g992643655c872f8332f9e8e453631a8fad52943a
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Nov 17 15:26:29 2020 +0000
libstdc++: Fix unconditional definition of __cpp_lib_span in <version> [PR
97869}
The <span> header is empty unless Concepts are supported, but <version>
defines the __cpp_lib_span feature test macro unconditionally. It should
be guarded by the same conditions as in <span>.
libstdc++-v3/ChangeLog:
PR libstdc++/97869
* include/precompiled/stdc++.h: Include <coroutine>.
* include/std/version (__cpp_lib_span): Check __cpp_lib_concepts
before defining.
(cherry picked from commit ecf65330c11544ebf35e198087b4a42be089c620)
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libstdc++/97869] <version> defines __cpp_lib_span even when <span> doesn't provide an implementation
2020-11-17 4:09 [Bug libstdc++/97869] New: <version> defines __cpp_lib_span even when <span> doesn't provide an implementation rs2740 at gmail dot com
` (3 preceding siblings ...)
2020-11-18 13:03 ` cvs-commit at gcc dot gnu.org
@ 2020-11-18 13:04 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2020-11-18 13:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97869
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 10.3
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-18 13:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-17 4:09 [Bug libstdc++/97869] New: <version> defines __cpp_lib_span even when <span> doesn't provide an implementation rs2740 at gmail dot com
2020-11-17 7:27 ` [Bug libstdc++/97869] " redi at gcc dot gnu.org
2020-11-17 14:18 ` redi at gcc dot gnu.org
2020-11-17 16:13 ` cvs-commit at gcc dot gnu.org
2020-11-18 13:03 ` cvs-commit at gcc dot gnu.org
2020-11-18 13:04 ` redi at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).