[Bug c/97932] New: Preprocessor, generated error dumps most of the source file, not just one line.

[Bug c/97932] New: Preprocessor, generated error dumps most of the source file, not just one line.

[lance.delahaye at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97932

            Bug ID: 97932
           Summary: Preprocessor, generated error dumps most of the source
                    file, not just one line.
           Product: gcc
           Version: 8.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: lance.delahaye at gmail dot com
  Target Milestone: ---

Created attachment 49608
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49608&action=edit
Minimal source (too many comments maybe) but no #includes needed.

When error generated originating expanding #define, entire source between line
of  #define and the line invoking the macro is listed as error line. Can be
hundreds of lines, most of the source file.

Verified on 6.3 and 8.2, not tried most recent.

Attached source .c file, no #include dependancies.

To reproduce:

gcc -C _gcc_container_of_bug.c

gcc --version 
gcc (x86_64-posix-seh-rev0, Built by MinGW-W64 project) 8.1.0
Copyright (C) 2018 Free Software Foundation, Inc.

[Bug c/97932] Preprocessor, generated error dumps most of the source file, not just one line.

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97932

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
           Keywords|                            |diagnostic
   Last reconfirmed|                            |2020-11-21

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed,
Min example:
#define container_of( P, T, M )  ( (void)((P) - &((T*)0)->M), (T*)((char*)(P) -
(int)&((T*)0)->M) )
typedef struct {
    short a;
    short b;
} test_t;

int main( int argc, const char *argv[] )
{
    short c;
    char b;
    tptr = container_of( b, test_t, b );
    return  0;
}

---- CUT ----
For some reason the preprocessor or the C front-end thinks the range goes all
the way to the closing ) on the container_of line.

[Bug c/97932] Preprocessor, generated error dumps most of the source file, not just one line.

[lance.delahaye at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97932

--- Comment #2 from Lance de la Haye <lance.delahaye at gmail dot com> ---
Also verified with mingw64 build from winlibs.com

gcc --version
gcc.exe (MinGW-W64 x86_64-posix-seh, built by Brecht Sanders) 10.2.0
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[Bug c/97932] Preprocessor, generated error dumps most of the source file, not just one line.

[lance.delahaye at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97932

Lance de la Haye <lance.delahaye at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|8.2.0                       |10.2.0

--- Comment #3 from Lance de la Haye <lance.delahaye at gmail dot com> ---
Also verified with mingw64 build from winlibs.com

gcc --version
gcc.exe (MinGW-W64 x86_64-posix-seh, built by Brecht Sanders) 10.2.0
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[Bug c/97932] [8/9/10/11 Regression] Preprocessor, generated error dumps most of the source file, not just one line by r6-5941

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97932

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dmalcolm at redhat dot com
            Summary|Preprocessor, generated     |[8/9/10/11 Regression]
                   |error dumps most of the     |Preprocessor, generated
                   |source file, not just one   |error dumps most of the
                   |line.                       |source file, not just one
                   |                            |line by r6-5941
   Target Milestone|---                         |8.5

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> ---
It is caused by r6-5941.

[Bug c/97932] [8/9/10/11 Regression] Preprocessor, generated error dumps most of the source file, not just one line by r6-5941

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97932

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug c/97932] [8/9/10/11 Regression] Preprocessor, generated error dumps most of the source file, not just one line by r6-5941

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97932

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
David, do you think you could have a look?  Perhaps having some upper limit on
the number of lines and not print the source if it would be too many lines?

[Bug c/97932] [8/9/10/11 Regression] Preprocessor, generated error dumps most of the source file, not just one line by r6-5941

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97932

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dmalcolm at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |dmalcolm at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #6 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Mine

[Bug c/97932] [8/9/10/11 Regression] Preprocessor, generated error dumps most of the source file, not just one line by r6-5941

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97932

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:65c1cb358999e9d1618834af341b31837ede839e

commit r11-7105-g65c1cb358999e9d1618834af341b31837ede839e
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Thu Feb 4 15:20:59 2021 -0500

    diagnostics: fix excessive range-printing involving macros [PR97932]

    PR c/97932 describes a bug in which diagnostic_show_locus prints most
    of a source file.

    The issue is that it prints a range in which the start and end locations
    are part of the same macro map, but the start location is for a token in
    the definition of the macro, whereas the end location is for a token in
    an argument of the macro.

    This patch extends compatible_locations_p to require that range-printing
    of macro maps requires the location to either be both for the definition
    of the macro, or both for the arguments of the macro (not one of each),
    fixing the issue.

    gcc/ChangeLog:
            PR c/97932
            * diagnostic-show-locus.c (compatible_locations_p): Require
            locations in the same macro map to be either both from the
            macro definition, or both from the macro arguments.

    gcc/testsuite/ChangeLog:
            PR c/97932
            * gcc.dg/pr97932.c: New test.

[Bug c/97932] [8/9/10 Regression] Preprocessor, generated error dumps most of the source file, not just one line by r6-5941

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97932

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[8/9/10/11 Regression]      |[8/9/10 Regression]
                   |Preprocessor, generated     |Preprocessor, generated
                   |error dumps most of the     |error dumps most of the
                   |source file, not just one   |source file, not just one
                   |line by r6-5941             |line by r6-5941

--- Comment #8 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Should be fixed on trunk by above commit.

[Bug c/97932] [9/10 Regression] Preprocessor, generated error dumps most of the source file, not just one line by r6-5941

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97932

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|8.5                         |9.4

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 8 branch is being closed.

[Bug c/97932] [9/10 Regression] Preprocessor, generated error dumps most of the source file, not just one line by r6-5941

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97932

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |9.5

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.

[Bug c/97932] [10 Regression] Preprocessor, generated error dumps most of the source file, not just one line by r6-5941

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97932

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.5                         |10.4

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9 branch is being closed

[Bug c/97932] [10 Regression] Preprocessor, generated error dumps most of the source file, not just one line by r6-5941

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97932

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

[Bug c/97932] [10 Regression] Preprocessor, generated error dumps most of the source file, not just one line by r6-5941

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97932

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |11.0
         Resolution|---                         |FIXED
      Known to fail|                            |10.5.0
      Known to work|                            |11.1.0
             Status|ASSIGNED                    |RESOLVED

--- Comment #13 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed in GCC 11.