public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug libstdc++/97935] New: Missing subsumption in iterator category detection @ 2020-11-21 23:09 rs2740 at gmail dot com 2020-11-22 0:46 ` [Bug libstdc++/97935] " redi at gcc dot gnu.org ` (3 more replies) 0 siblings, 4 replies; 5+ messages in thread From: rs2740 at gmail dot com @ 2020-11-21 23:09 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97935 Bug ID: 97935 Summary: Missing subsumption in iterator category detection Product: gcc Version: 11.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: libstdc++ Assignee: unassigned at gcc dot gnu.org Reporter: rs2740 at gmail dot com Target Milestone: --- In <bits/iterator_concepts.h>: template<typename _Iter> requires (!requires { typename _Iter::iterator_category; } && __detail::__cpp17_randacc_iterator<_Iter>) struct __cat<_Iter> { using type = random_access_iterator_tag; }; template<typename _Iter> requires (!requires { typename _Iter::iterator_category; } && __detail::__cpp17_bidi_iterator<_Iter>) struct __cat<_Iter> { using type = bidirectional_iterator_tag; }; template<typename _Iter> requires (!requires { typename _Iter::iterator_category; } && __detail::__cpp17_fwd_iterator<_Iter>) struct __cat<_Iter> { using type = forward_iterator_tag; }; The !requires part of the constraints do not subsume each other, so any iterator that is a __cpp17_bidi_iterator or stronger causes an ambiguity. It needs to be extracted into a concept. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libstdc++/97935] Missing subsumption in iterator category detection 2020-11-21 23:09 [Bug libstdc++/97935] New: Missing subsumption in iterator category detection rs2740 at gmail dot com @ 2020-11-22 0:46 ` redi at gcc dot gnu.org 2020-11-25 17:41 ` cvs-commit at gcc dot gnu.org ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: redi at gcc dot gnu.org @ 2020-11-22 0:46 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97935 Jonathan Wakely <redi at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Target Milestone|--- |10.3 Last reconfirmed| |2020-11-22 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libstdc++/97935] Missing subsumption in iterator category detection 2020-11-21 23:09 [Bug libstdc++/97935] New: Missing subsumption in iterator category detection rs2740 at gmail dot com 2020-11-22 0:46 ` [Bug libstdc++/97935] " redi at gcc dot gnu.org @ 2020-11-25 17:41 ` cvs-commit at gcc dot gnu.org 2020-11-25 18:11 ` cvs-commit at gcc dot gnu.org 2020-11-25 18:11 ` redi at gcc dot gnu.org 3 siblings, 0 replies; 5+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2020-11-25 17:41 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97935 --- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>: https://gcc.gnu.org/g:9d908b7fc475b351622fa5630d4874068c789d70 commit r11-5381-g9d908b7fc475b351622fa5630d4874068c789d70 Author: Jonathan Wakely <jwakely@redhat.com> Date: Wed Nov 25 17:18:44 2020 +0000 libstdc++: Fix missing subsumption in std::iterator_traits [PR 97935] libstdc++-v3/ChangeLog: PR libstdc++/97935 * include/bits/iterator_concepts.h (__detail::__iter_without_category): New helper concept. (__iterator_traits::__cat): Use __detail::__iter_without_category. * testsuite/24_iterators/associated_types/iterator.traits.cc: New test. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libstdc++/97935] Missing subsumption in iterator category detection 2020-11-21 23:09 [Bug libstdc++/97935] New: Missing subsumption in iterator category detection rs2740 at gmail dot com 2020-11-22 0:46 ` [Bug libstdc++/97935] " redi at gcc dot gnu.org 2020-11-25 17:41 ` cvs-commit at gcc dot gnu.org @ 2020-11-25 18:11 ` cvs-commit at gcc dot gnu.org 2020-11-25 18:11 ` redi at gcc dot gnu.org 3 siblings, 0 replies; 5+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2020-11-25 18:11 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97935 --- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-10 branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>: https://gcc.gnu.org/g:f89ba6e9a5da5506cb72235f500b152d4d365f3f commit r10-9081-gf89ba6e9a5da5506cb72235f500b152d4d365f3f Author: Jonathan Wakely <jwakely@redhat.com> Date: Wed Nov 25 17:18:44 2020 +0000 libstdc++: Fix missing subsumption in std::iterator_traits [PR 97935] libstdc++-v3/ChangeLog: PR libstdc++/97935 * include/bits/iterator_concepts.h (__detail::__iter_without_category): New helper concept. (__iterator_traits::__cat): Use __detail::__iter_without_category. * testsuite/24_iterators/associated_types/iterator.traits.cc: New test. (cherry picked from commit 9d908b7fc475b351622fa5630d4874068c789d70) ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libstdc++/97935] Missing subsumption in iterator category detection 2020-11-21 23:09 [Bug libstdc++/97935] New: Missing subsumption in iterator category detection rs2740 at gmail dot com ` (2 preceding siblings ...) 2020-11-25 18:11 ` cvs-commit at gcc dot gnu.org @ 2020-11-25 18:11 ` redi at gcc dot gnu.org 3 siblings, 0 replies; 5+ messages in thread From: redi at gcc dot gnu.org @ 2020-11-25 18:11 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97935 Jonathan Wakely <redi at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> --- Fix for 10.3, thanks. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-25 18:11 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-11-21 23:09 [Bug libstdc++/97935] New: Missing subsumption in iterator category detection rs2740 at gmail dot com 2020-11-22 0:46 ` [Bug libstdc++/97935] " redi at gcc dot gnu.org 2020-11-25 17:41 ` cvs-commit at gcc dot gnu.org 2020-11-25 18:11 ` cvs-commit at gcc dot gnu.org 2020-11-25 18:11 ` redi at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).