public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/97979] [11 Regression]: Segmentation fault with "-O3 -fno-toplevel-reorder -fno-tree-ccp" since r11-5271-g4866b2f5db117f9e Date: Thu, 26 Nov 2020 09:51:10 +0000 [thread overview] Message-ID: <bug-97979-4-jcOHtVTa3F@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-97979-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97979 --- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:39f5e9aded23e8b7e0e7080fc6020478b9c5b7b5 commit r11-5433-g39f5e9aded23e8b7e0e7080fc6020478b9c5b7b5 Author: Jakub Jelinek <jakub@redhat.com> Date: Thu Nov 26 10:50:23 2020 +0100 match.pd: Avoid ICE with shifts [PR97979] My recent wide_int_binop changes caused ICE on this testcase. The problem is that for shift where amount has MSB set now fails to optimize into a constant (IMHO we should treat out of bounds shifts the same later), but there is a precedent for that already - e.g. division by zero fails to optimize into a constant too. I think it is better if path isolation checks for these UBs and does something the user chooses (__builtin_trap vs. __builtin_unreachable, and either a deferred warning about the UB or nothing). This patch just doesn't optimize if int_const_binop failed. 2020-11-26 Jakub Jelinek <jakub@redhat.com> PR tree-optimization/97979 * match.pd ((X {&,^,|} C2) << C1 into (X << C1) {&,^,|} (C2 << C1)): Only optimize if int_const_binop returned non-NULL. * gcc.dg/pr97979.c: New test. * gcc.c-torture/compile/pr97979.c: New test.
next prev parent reply other threads:[~2020-11-26 9:51 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-25 6:50 [Bug c/97979] New: internal compiler error: Segmentation fault with "-O3 -fno-toplevel-reorder -fno-tree-ccp" suochenyao at 163 dot com 2020-11-25 8:15 ` [Bug tree-optimization/97979] [11 Regression]: Segmentation fault with "-O3 -fno-toplevel-reorder -fno-tree-ccp" since r11-5271-g4866b2f5db117f9e marxin at gcc dot gnu.org 2020-11-25 8:36 ` rguenth at gcc dot gnu.org 2020-11-25 15:35 ` jakub at gcc dot gnu.org 2020-11-26 9:51 ` cvs-commit at gcc dot gnu.org [this message] 2020-11-26 10:02 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-97979-4-jcOHtVTa3F@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).