public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/98011] [OpenACC] 'gcc/fortran/scanner.c:load_line' should consider 'flag_openacc' in addition to 'flag_openmp' (and vice versa?)? Date: Mon, 30 Nov 2020 14:48:14 +0000 [thread overview] Message-ID: <bug-98011-4-bikEVWCNSE@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-98011-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98011 Tobias Burnus <burnus at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> --- Actually, the code in gcc/fortran/scanner.c load_line is fine. It does load too much for OpenMP – but that only wastes memory. The actual check for '!$omp' vs. '!$ ' is done in skip_free_comments and skip_fixed_comments (which has to do some additional checking). And that check works well. However, as mentioned in comment 2, 'gfortran -fopenacc' did process OpenMP's '!$ ' conditional-compilation sentinels (and OpenACC does not have its own sentinels). That issue has now been FIXED for mainline.
next prev parent reply other threads:[~2020-11-30 14:48 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-26 10:59 [Bug fortran/98011] New: " tschwinge at gcc dot gnu.org 2020-11-26 11:41 ` [Bug fortran/98011] " burnus at gcc dot gnu.org 2020-11-26 11:59 ` burnus at gcc dot gnu.org 2020-11-30 14:37 ` cvs-commit at gcc dot gnu.org 2020-11-30 14:48 ` burnus at gcc dot gnu.org [this message] 2023-10-15 21:12 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-98011-4-bikEVWCNSE@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).