[Bug c++/98072] New: [11 Regression] ICE in cp_parser_omp_var_list_no_open, at cp/parser.c:34843

[Bug c++/98072] New: [11 Regression] ICE in cp_parser_omp_var_list_no_open, at cp/parser.c:34843

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98072

            Bug ID: 98072
           Summary: [11 Regression] ICE in cp_parser_omp_var_list_no_open,
                    at cp/parser.c:34843
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code, openmp
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

g++-11.0.0-alpha20201129 snapshot (g:bb67ad5cff58a707aaae645d4f45a913d8511c86)
ICEs when compiling the following testcase, reduced from
test/OpenMP/depobj_ast_print.cpp from the clang 11.0.0 test suite, w/ -fopenmp:

void
dh (int *vp, int pm, int ca)
{
#pragma omp depobj (pm) depend (iterator (ca = 0 : *vp), in: vp[ca])
    ;
}

% g++-11.0.0 -fopenmp -c wmttbiko.cpp
wmttbiko.cpp: In function 'void dh(int*, int, int)':
wmttbiko.cpp:4:65: internal compiler error: in cp_parser_omp_var_list_no_open,
at cp/parser.c:34843
    4 | #pragma omp depobj (pm) depend (iterator (ca = 0 : *vp), in: vp[ca])
      |                                                                 ^~
0x9e4b1b cp_parser_omp_var_list_no_open
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:34843
0x9ec406 cp_parser_omp_clause_depend
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:37177
0x9d9540 cp_parser_omp_depobj
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:38787
0x9d9540 cp_parser_pragma
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:44282
0x9dfd68 cp_parser_statement
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:11561
0x9e0aed cp_parser_statement_seq_opt
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:11953
0x9e0bc8 cp_parser_compound_statement
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:11903
0x9fac64 cp_parser_function_body
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:23570
0x9fac64 cp_parser_ctor_initializer_opt_and_function_body
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:23621
0x9ff719 cp_parser_function_definition_after_declarator
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:29511
0xa00ab9 cp_parser_function_definition_from_specifiers_and_declarator
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:29427
0xa00ab9 cp_parser_init_declarator
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:21143
0x9ddaf7 cp_parser_simple_declaration
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:13963
0xa0aaa4 cp_parser_declaration
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:13660
0xa0b450 cp_parser_translation_unit
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:4806
0xa0b450 c_parse_file()
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/cp/parser.c:44630
0xb3082d c_common_parse_file()
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/gcc/c-family/c-opts.c:1198

The failing assert has been introduced in
g:c0c7270cc4efd896fe99f8ad5409dbef089a407f.

[Bug c++/98072] [11 Regression] ICE in cp_parser_omp_var_list_no_open, at cp/parser.c:34843

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98072

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0

[Bug c++/98072] [9/10/11 Regression] ICE in cp_parser_omp_var_list_no_open, at cp/parser.c:34843

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98072

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|ice-on-invalid-code         |ice-checking
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |tschwinge at gcc dot gnu.org
           Priority|P3                          |P1
            Summary|[11 Regression] ICE in      |[9/10/11 Regression] ICE in
                   |cp_parser_omp_var_list_no_o |cp_parser_omp_var_list_no_o
                   |pen, at cp/parser.c:34843   |pen, at cp/parser.c:34843

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
ICEs even when the testcase is turned into valid one:

typedef struct __attribute__((__aligned__ (sizeof (void *)))) omp_depend_t {
  char __omp_depend_t__[2 * sizeof (void *)];
} omp_depend_t;

void
foo (int *x, omp_depend_t *y, int z)
{
#pragma omp depobj (*y) depend (in: x[z])
}

Started with 
r11-5430-gc0c7270cc4efd896fe99f8ad5409dbef089a407f but that change has been
backported to 10 and 9 branches too.

[Bug c++/98072] [9/10/11 Regression] ICE in cp_parser_omp_var_list_no_open, at cp/parser.c:34843

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98072

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2020-12-01
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 49656
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49656&action=edit
gcc11-pr98072.patch

Untested fix.  The ultimate right fix is of course get rid of these sentinels
from OpenMP/OpenACC parsing and deal with location wrappers when handling the
clauses.

[Bug c++/98072] [9/10/11 Regression] ICE in cp_parser_omp_var_list_no_open, at cp/parser.c:34843

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98072

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dmalcolm at gcc dot gnu.org

--- Comment #3 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
(In reply to Arseny Solokha from comment #0)
> g++-11.0.0-alpha20201129 snapshot
> (g:bb67ad5cff58a707aaae645d4f45a913d8511c86) ICEs when compiling the
> following testcase, reduced from test/OpenMP/depobj_ast_print.cpp from the
> clang 11.0.0 test suite, w/ -fopenmp:

Thanks for doing such testing.

> % g++-11.0.0 -fopenmp -c wmttbiko.cpp
> wmttbiko.cpp: In function 'void dh(int*, int, int)':
> wmttbiko.cpp:4:65: internal compiler error: in
> cp_parser_omp_var_list_no_open, at cp/parser.c:34843
>     4 | #pragma omp depobj (pm) depend (iterator (ca = 0 : *vp), in: vp[ca])
>       |                                                                 ^~
> 0x9e4b1b cp_parser_omp_var_list_no_open
> 	/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/
> gcc/cp/parser.c:34843
> 0x9ec406 cp_parser_omp_clause_depend
> 	/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201129/work/gcc-11-20201129/

> The failing assert has been introduced in
> g:c0c7270cc4efd896fe99f8ad5409dbef089a407f.

ACK, and that means (a) missing testsuite coverage, and (b) likely mis-handling
these clauses (at least concerning validity checking, diagnostics) -- so, I'm
glad that the 'assert' has found this additional case.

(In reply to Jakub Jelinek from comment #2)
> Created attachment 49656 [details]
> gcc11-pr98072.patch
> 
> Untested fix.

ACK.  I suggest you also add the standard source code comment that we use in
other similar places.


Alternatively (separate change), I wondered whether we might actually move the
sentinel into 'cp_parser_omp_var_list_no_open', supposing that's the one only
place where this matters?  (But I haven't verified that.)


> The ultimate right fix is of course get rid of these
> sentinels from OpenMP/OpenACC parsing and deal with location wrappers when
> handling the clauses.

ACK.  (Or, get rid of (this implementation of) these explicit location wrapper
nodes.  I understand the intention behind the location wrappers, but maybe this
should be implemented differently?)

[Bug c++/98072] [9/10/11 Regression] ICE in cp_parser_omp_var_list_no_open, at cp/parser.c:34843

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98072

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:91ddf867a57b028ab322b737ea8355d5a472cd44

commit r11-5623-g91ddf867a57b028ab322b737ea8355d5a472cd44
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Dec 1 21:41:44 2020 +0100

    openmp: Avoid ICE on depend clause on depobj OpenMP construct [PR98072]

    Since r11-5430 we ICE on the following testcase.  When parsing the depobj
    directive we don't really use cp_parser_omp_all_clauses routine which ATM
    disables generation of location wrappers and the newly added assertion
    that there are no location wrappers thus triggers.

    Fixed by adding the location wrappers suppression sentinel.

    Longer term, we should handle location wrappers inside of OpenMP clauses.

    2020-12-01  Jakub Jelinek  <jakub@redhat.com>

            PR c++/98072
            * parser.c (cp_parser_omp_depobj): Suppress location wrappers when
            parsing depend clause.

            * c-c++-common/gomp/depobj-2.c: New test.

[Bug c++/98072] [9/10 Regression] ICE in cp_parser_omp_var_list_no_open, at cp/parser.c:34843

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98072

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[9/10/11 Regression] ICE in |[9/10 Regression] ICE in
                   |cp_parser_omp_var_list_no_o |cp_parser_omp_var_list_no_o
                   |pen, at cp/parser.c:34843   |pen, at cp/parser.c:34843
   Target Milestone|11.0                        |9.4

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk, needs to be backported to release branches where it
regressed since the latest released minor versions.

[Bug c++/98072] [9/10 Regression] ICE in cp_parser_omp_var_list_no_open, at cp/parser.c:34843

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98072

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:d62daad11b21a2ee9c39a43c5e94e7b966793dbd

commit r10-9212-gd62daad11b21a2ee9c39a43c5e94e7b966793dbd
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Dec 1 21:41:44 2020 +0100

    openmp: Avoid ICE on depend clause on depobj OpenMP construct [PR98072]

    Since r11-5430 we ICE on the following testcase.  When parsing the depobj
    directive we don't really use cp_parser_omp_all_clauses routine which ATM
    disables generation of location wrappers and the newly added assertion
    that there are no location wrappers thus triggers.

    Fixed by adding the location wrappers suppression sentinel.

    Longer term, we should handle location wrappers inside of OpenMP clauses.

    2020-12-01  Jakub Jelinek  <jakub@redhat.com>

            PR c++/98072
            * parser.c (cp_parser_omp_depobj): Suppress location wrappers when
            parsing depend clause.

            * c-c++-common/gomp/depobj-2.c: New test.

    (cherry picked from commit 91ddf867a57b028ab322b737ea8355d5a472cd44)

[Bug c++/98072] [9 Regression] ICE in cp_parser_omp_var_list_no_open, at cp/parser.c:34843

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98072

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[9/10 Regression] ICE in    |[9 Regression] ICE in
                   |cp_parser_omp_var_list_no_o |cp_parser_omp_var_list_no_o
                   |pen, at cp/parser.c:34843   |pen, at cp/parser.c:34843

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 10.3+ too.

[Bug c++/98072] [9 Regression] ICE in cp_parser_omp_var_list_no_open, at cp/parser.c:34843

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98072

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:705afe9b40aabbe395baa2979cdac0a9fef194ef

commit r9-9396-g705afe9b40aabbe395baa2979cdac0a9fef194ef
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Dec 1 21:41:44 2020 +0100

    openmp: Avoid ICE on depend clause on depobj OpenMP construct [PR98072]

    Since r11-5430 we ICE on the following testcase.  When parsing the depobj
    directive we don't really use cp_parser_omp_all_clauses routine which ATM
    disables generation of location wrappers and the newly added assertion
    that there are no location wrappers thus triggers.

    Fixed by adding the location wrappers suppression sentinel.

    Longer term, we should handle location wrappers inside of OpenMP clauses.

    2020-12-01  Jakub Jelinek  <jakub@redhat.com>

            PR c++/98072
            * parser.c (cp_parser_omp_depobj): Suppress location wrappers when
            parsing depend clause.

            * c-c++-common/gomp/depobj-2.c: New test.

    (cherry picked from commit d62daad11b21a2ee9c39a43c5e94e7b966793dbd)

[Bug c++/98072] [9 Regression] ICE in cp_parser_omp_var_list_no_open, at cp/parser.c:34843

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98072

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.