[Bug c/98100] New: ICE in expand_debug_locations, at cfgexpand.c:5610

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug c/98100] New: ICE in expand_debug_locations, at cfgexpand.c:5610
@ 2020-12-02 17:09 gscfq@t-online.de
  2020-12-03  7:19 ` [Bug target/98100] " rguenth at gcc dot gnu.org
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: gscfq@t-online.de @ 2020-12-02 17:09 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98100

            Bug ID: 98100
           Summary: ICE in expand_debug_locations, at cfgexpand.c:5610
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Affects versions down to r7 :


$ cat z1.c
__attribute__((target_clones("default","sse2")))
void f ()
{
  __attribute__((__vector_size__(4 * sizeof(float)))) int b = {};
}


$ gcc-11-20201129 -c z1.c -O2 -mgeneral-regs-only -fvar-tracking-assignments
during RTL pass: expand
z1.c: In function 'f.sse2.0':
z1.c:2:6: internal compiler error: in expand_debug_locations, at
cfgexpand.c:5610
    2 | void f ()
      |      ^
0x759573 expand_debug_locations
        ../../gcc/cfgexpand.c:5606
0x759573 execute
        ../../gcc/cfgexpand.c:6727

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug target/98100] ICE in expand_debug_locations, at cfgexpand.c:5610
  2020-12-02 17:09 [Bug c/98100] New: ICE in expand_debug_locations, at cfgexpand.c:5610 gscfq@t-online.de
@ 2020-12-03  7:19 ` rguenth at gcc dot gnu.org
  2020-12-03  8:06 ` marxin at gcc dot gnu.org
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-12-03  7:19 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98100

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c                           |target

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Not sure if valid - -mgeneral-regs-only forbits use of vector registers but the
code explicitely asks for them(?)

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug target/98100] ICE in expand_debug_locations, at cfgexpand.c:5610
  2020-12-02 17:09 [Bug c/98100] New: ICE in expand_debug_locations, at cfgexpand.c:5610 gscfq@t-online.de
  2020-12-03  7:19 ` [Bug target/98100] " rguenth at gcc dot gnu.org
@ 2020-12-03  8:06 ` marxin at gcc dot gnu.org
  2020-12-03 13:19 ` jakub at gcc dot gnu.org
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-12-03  8:06 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98100

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2020-12-03
                 CC|                            |marxin at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r7-1047-gc6e434f5b73538b7 where -mgeneral-regs-only option was
added.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug target/98100] ICE in expand_debug_locations, at cfgexpand.c:5610
  2020-12-02 17:09 [Bug c/98100] New: ICE in expand_debug_locations, at cfgexpand.c:5610 gscfq@t-online.de
  2020-12-03  7:19 ` [Bug target/98100] " rguenth at gcc dot gnu.org
  2020-12-03  8:06 ` marxin at gcc dot gnu.org
@ 2020-12-03 13:19 ` jakub at gcc dot gnu.org
  2020-12-03 13:23 ` jakub at gcc dot gnu.org
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-12-03 13:19 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98100

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The problem is that while we have TYPE_MODE defined such that for vector types
it adjusts the raw mode depending on whether the vector mode is or is not
available ATM, we don't adjust DECL_MODE that way.
So, seems like a copy of PR88587, just for some reason the PR88587 fix doesn't
work here.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug target/98100] ICE in expand_debug_locations, at cfgexpand.c:5610
  2020-12-02 17:09 [Bug c/98100] New: ICE in expand_debug_locations, at cfgexpand.c:5610 gscfq@t-online.de
                   ` (2 preceding siblings ...)
  2020-12-03 13:19 ` jakub at gcc dot gnu.org
@ 2020-12-03 13:23 ` jakub at gcc dot gnu.org
  2020-12-03 13:34 ` jakub at gcc dot gnu.org
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-12-03 13:23 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98100

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Ah, that is because we don't really copy the decl during cloning, because it
isn't really used in the code.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug target/98100] ICE in expand_debug_locations, at cfgexpand.c:5610
  2020-12-02 17:09 [Bug c/98100] New: ICE in expand_debug_locations, at cfgexpand.c:5610 gscfq@t-online.de
                   ` (3 preceding siblings ...)
  2020-12-03 13:23 ` jakub at gcc dot gnu.org
@ 2020-12-03 13:34 ` jakub at gcc dot gnu.org
  2020-12-04 11:18 ` cvs-commit at gcc dot gnu.org
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-12-03 13:34 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98100

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 49673
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49673&action=edit
gcc11-pr98100.patch

Untested fix.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug target/98100] ICE in expand_debug_locations, at cfgexpand.c:5610
  2020-12-02 17:09 [Bug c/98100] New: ICE in expand_debug_locations, at cfgexpand.c:5610 gscfq@t-online.de
                   ` (4 preceding siblings ...)
  2020-12-03 13:34 ` jakub at gcc dot gnu.org
@ 2020-12-04 11:18 ` cvs-commit at gcc dot gnu.org
  2020-12-04 11:19 ` jakub at gcc dot gnu.org
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-12-04 11:18 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98100

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:704ccefb576dcf30b27a4b9bdacb6e15902f5307

commit r11-5743-g704ccefb576dcf30b27a4b9bdacb6e15902f5307
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Dec 4 12:18:21 2020 +0100

    debug: Fix another vector DECL_MODE ICE [PR98100]

    The PR88587 fix changes DECL_MODE of vars with vector type during
inlining/cloning
    when the vars are copied, so that their DECL_MODE matches their TYPE_MODE
in
    the new function.  Unfortunately, the following testcase still ICEs, the
var
    isn't really used in the new function and so it isn't copied, but becomes
    just a nonlocalized var.  So we can't adjust its DECL_MODE because it
    appears in multiple functions and needs different modes in between them.
    The following patch changes the DEBUG_INSN creation to use TYPE_MODE
instead
    of DECL_MODE for vars with vector types.

    2020-12-04  Jakub Jelinek  <jakub@redhat.com>

            PR target/98100
            * cfgexpand.c (expand_gimple_basic_block): For vars with
            vector type, use TYPE_MODE rather than DECL_MODE.

            * gcc.target/i386/pr98100.c: New test.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug target/98100] ICE in expand_debug_locations, at cfgexpand.c:5610
  2020-12-02 17:09 [Bug c/98100] New: ICE in expand_debug_locations, at cfgexpand.c:5610 gscfq@t-online.de
                   ` (5 preceding siblings ...)
  2020-12-04 11:18 ` cvs-commit at gcc dot gnu.org
@ 2020-12-04 11:19 ` jakub at gcc dot gnu.org
  2021-01-06  9:39 ` cvs-commit at gcc dot gnu.org
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-12-04 11:19 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98100

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk (so far).

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug target/98100] ICE in expand_debug_locations, at cfgexpand.c:5610
  2020-12-02 17:09 [Bug c/98100] New: ICE in expand_debug_locations, at cfgexpand.c:5610 gscfq@t-online.de
                   ` (6 preceding siblings ...)
  2020-12-04 11:19 ` jakub at gcc dot gnu.org
@ 2021-01-06  9:39 ` cvs-commit at gcc dot gnu.org
  2021-04-20 23:30 ` cvs-commit at gcc dot gnu.org
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-01-06  9:39 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98100

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:4c18faa4dd4dffdb76bc879b7555574ce3f4da01

commit r10-9215-g4c18faa4dd4dffdb76bc879b7555574ce3f4da01
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Dec 4 12:18:21 2020 +0100

    debug: Fix another vector DECL_MODE ICE [PR98100]

    The PR88587 fix changes DECL_MODE of vars with vector type during
inlining/cloning
    when the vars are copied, so that their DECL_MODE matches their TYPE_MODE
in
    the new function.  Unfortunately, the following testcase still ICEs, the
var
    isn't really used in the new function and so it isn't copied, but becomes
    just a nonlocalized var.  So we can't adjust its DECL_MODE because it
    appears in multiple functions and needs different modes in between them.
    The following patch changes the DEBUG_INSN creation to use TYPE_MODE
instead
    of DECL_MODE for vars with vector types.

    2020-12-04  Jakub Jelinek  <jakub@redhat.com>

            PR target/98100
            * cfgexpand.c (expand_gimple_basic_block): For vars with
            vector type, use TYPE_MODE rather than DECL_MODE.

            * gcc.target/i386/pr98100.c: New test.

    (cherry picked from commit 704ccefb576dcf30b27a4b9bdacb6e15902f5307)

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug target/98100] ICE in expand_debug_locations, at cfgexpand.c:5610
  2020-12-02 17:09 [Bug c/98100] New: ICE in expand_debug_locations, at cfgexpand.c:5610 gscfq@t-online.de
                   ` (7 preceding siblings ...)
  2021-01-06  9:39 ` cvs-commit at gcc dot gnu.org
@ 2021-04-20 23:30 ` cvs-commit at gcc dot gnu.org
  2021-04-22 16:49 ` cvs-commit at gcc dot gnu.org
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-04-20 23:30 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98100

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:c47d4bddf3b08f833b2a59cc0be40234fe10e6bc

commit r9-9398-gc47d4bddf3b08f833b2a59cc0be40234fe10e6bc
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Dec 4 12:18:21 2020 +0100

    debug: Fix another vector DECL_MODE ICE [PR98100]

    The PR88587 fix changes DECL_MODE of vars with vector type during
inlining/cloning
    when the vars are copied, so that their DECL_MODE matches their TYPE_MODE
in
    the new function.  Unfortunately, the following testcase still ICEs, the
var
    isn't really used in the new function and so it isn't copied, but becomes
    just a nonlocalized var.  So we can't adjust its DECL_MODE because it
    appears in multiple functions and needs different modes in between them.
    The following patch changes the DEBUG_INSN creation to use TYPE_MODE
instead
    of DECL_MODE for vars with vector types.

    2020-12-04  Jakub Jelinek  <jakub@redhat.com>

            PR target/98100
            * cfgexpand.c (expand_gimple_basic_block): For vars with
            vector type, use TYPE_MODE rather than DECL_MODE.

            * gcc.target/i386/pr98100.c: New test.

    (cherry picked from commit 4c18faa4dd4dffdb76bc879b7555574ce3f4da01)

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug target/98100] ICE in expand_debug_locations, at cfgexpand.c:5610
  2020-12-02 17:09 [Bug c/98100] New: ICE in expand_debug_locations, at cfgexpand.c:5610 gscfq@t-online.de
                   ` (8 preceding siblings ...)
  2021-04-20 23:30 ` cvs-commit at gcc dot gnu.org
@ 2021-04-22 16:49 ` cvs-commit at gcc dot gnu.org
  2021-04-22 17:08 ` jakub at gcc dot gnu.org
  2021-09-11 14:21 ` pinskia at gcc dot gnu.org
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-04-22 16:49 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98100

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:455f165fd86f50163d2147b669edcc2e9bf5b0f8

commit r8-10867-g455f165fd86f50163d2147b669edcc2e9bf5b0f8
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Dec 4 12:18:21 2020 +0100

    debug: Fix another vector DECL_MODE ICE [PR98100]

    The PR88587 fix changes DECL_MODE of vars with vector type during
inlining/cloning
    when the vars are copied, so that their DECL_MODE matches their TYPE_MODE
in
    the new function.  Unfortunately, the following testcase still ICEs, the
var
    isn't really used in the new function and so it isn't copied, but becomes
    just a nonlocalized var.  So we can't adjust its DECL_MODE because it
    appears in multiple functions and needs different modes in between them.
    The following patch changes the DEBUG_INSN creation to use TYPE_MODE
instead
    of DECL_MODE for vars with vector types.

    2020-12-04  Jakub Jelinek  <jakub@redhat.com>

            PR target/98100
            * cfgexpand.c (expand_gimple_basic_block): For vars with
            vector type, use TYPE_MODE rather than DECL_MODE.

            * gcc.target/i386/pr98100.c: New test.

    (cherry picked from commit 4c18faa4dd4dffdb76bc879b7555574ce3f4da01)

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug target/98100] ICE in expand_debug_locations, at cfgexpand.c:5610
  2020-12-02 17:09 [Bug c/98100] New: ICE in expand_debug_locations, at cfgexpand.c:5610 gscfq@t-online.de
                   ` (9 preceding siblings ...)
  2021-04-22 16:49 ` cvs-commit at gcc dot gnu.org
@ 2021-04-22 17:08 ` jakub at gcc dot gnu.org
  2021-09-11 14:21 ` pinskia at gcc dot gnu.org
  11 siblings, 0 replies; 13+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-04-22 17:08 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98100

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug target/98100] ICE in expand_debug_locations, at cfgexpand.c:5610
  2020-12-02 17:09 [Bug c/98100] New: ICE in expand_debug_locations, at cfgexpand.c:5610 gscfq@t-online.de
                   ` (10 preceding siblings ...)
  2021-04-22 17:08 ` jakub at gcc dot gnu.org
@ 2021-09-11 14:21 ` pinskia at gcc dot gnu.org
  11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-09-11 14:21 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98100

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |8.5

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2021-09-11 14:21 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02 17:09 [Bug c/98100] New: ICE in expand_debug_locations, at cfgexpand.c:5610 gscfq@t-online.de
2020-12-03  7:19 ` [Bug target/98100] " rguenth at gcc dot gnu.org
2020-12-03  8:06 ` marxin at gcc dot gnu.org
2020-12-03 13:19 ` jakub at gcc dot gnu.org
2020-12-03 13:23 ` jakub at gcc dot gnu.org
2020-12-03 13:34 ` jakub at gcc dot gnu.org
2020-12-04 11:18 ` cvs-commit at gcc dot gnu.org
2020-12-04 11:19 ` jakub at gcc dot gnu.org
2021-01-06  9:39 ` cvs-commit at gcc dot gnu.org
2021-04-20 23:30 ` cvs-commit at gcc dot gnu.org
2021-04-22 16:49 ` cvs-commit at gcc dot gnu.org
2021-04-22 17:08 ` jakub at gcc dot gnu.org
2021-09-11 14:21 ` pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).