public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug testsuite/98125] [11 Regression] New test case g++.dg/pr93195a.C in r11-5656 has excess errors Date: Sat, 03 Apr 2021 08:04:29 +0000 [thread overview] Message-ID: <bug-98125-4-e6icdT1kRl@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-98125-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98125 --- Comment #19 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:b680b9049737198d010e49cf434704c6a6ed2b3f commit r11-7968-gb680b9049737198d010e49cf434704c6a6ed2b3f Author: Jakub Jelinek <jakub@redhat.com> Date: Sat Apr 3 10:03:15 2021 +0200 rs6000: Avoid -fpatchable-function-entry* regressions on powerpc64 be [PR98125] The SECTION_LINK_ORDER changes broke powerpc64-linux ELFv1. Seems that the assembler/linker relies on the symbol mentioned for the "awo" section to be in the same section as the symbols mentioned in the relocations in that section (i.e. labels for the patchable area in this case). That is the case for most targets, including powerpc-linux 32-bit or powerpc64 ELFv2 (that one has -fpatchable-function-entry* support broken for other reasons and it doesn't seem to be a regression). But it doesn't work on powerpc64-linux ELFv1. We emit: .section ".opd","aw" .align 3 _Z3foov: .quad .L._Z3foov,.TOC.@tocbase,0 .previous .type _Z3foov, @function .L._Z3foov: .section __patchable_function_entries,"awo",@progbits,_Z3foov .align 3 .8byte .LPFE1 .section .text._Z3foov,"axG",@progbits,_Z3foov,comdat .LPFE1: nop .LFB0: .cfi_startproc and because _Z3foov is in the .opd section rather than the function text section, it doesn't work. I'm afraid I don't know what exactly should be done, whether e.g. it could use .section __patchable_function_entries,"awo",@progbits,.L._Z3foov instead, or whether the linker should be changed to handle it as is, or something else. But because we have a P1 regression that didn't see useful progress over the 4 months since it has been filed and we don't really have much time, below is an attempt to do a targetted reversion of H.J's patch, basically act as if HAVE_GAS_SECTION_LINK_ORDER is never true for powerpc64-linux ELFv1, but for 32-bit or 64-bit ELFv2 keep working as is. This would give us time to resolve it for GCC 12 properly. 2021-04-03 Jakub Jelinek <jakub@redhat.com> PR testsuite/98125 * targhooks.h (default_print_patchable_function_entry_1): Declare. * targhooks.c (default_print_patchable_function_entry_1): New function, copied from default_print_patchable_function_entry with an added flags argument. (default_print_patchable_function_entry): Rewritten into a small wrapper around default_print_patchable_function_entry_1. * config/rs6000/rs6000.c (TARGET_ASM_PRINT_PATCHABLE_FUNCTION_ENTRY): Redefine. (rs6000_print_patchable_function_entry): New function. * g++.dg/pr93195a.C: Skip on powerpc*-*-* 64-bit.
next prev parent reply other threads:[~2021-04-03 8:04 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-03 16:31 [Bug testsuite/98125] New: " seurer at gcc dot gnu.org 2020-12-03 16:36 ` [Bug testsuite/98125] " hjl.tools at gmail dot com 2020-12-03 16:56 ` seurer at gcc dot gnu.org 2020-12-03 18:20 ` hjl.tools at gmail dot com 2020-12-03 20:18 ` hjl.tools at gmail dot com 2020-12-04 6:09 ` amodra at gmail dot com 2020-12-04 7:11 ` [Bug testsuite/98125] [11 Regression] " rguenth at gcc dot gnu.org 2020-12-04 12:00 ` amodra at gmail dot com 2020-12-07 21:45 ` amodra at gmail dot com 2021-01-14 11:01 ` rguenth at gcc dot gnu.org 2021-01-22 15:16 ` jakub at gcc dot gnu.org 2021-01-22 21:05 ` seurer at gcc dot gnu.org 2021-01-22 22:13 ` amodra at gmail dot com 2021-01-22 22:18 ` amodra at gmail dot com 2021-02-12 15:13 ` jakub at gcc dot gnu.org 2021-02-16 1:07 ` amodra at gmail dot com 2021-02-23 15:29 ` jakub at gcc dot gnu.org 2021-02-23 15:32 ` jakub at gcc dot gnu.org 2021-03-30 13:02 ` jakub at gcc dot gnu.org 2021-03-30 14:10 ` jakub at gcc dot gnu.org 2021-04-03 8:04 ` cvs-commit at gcc dot gnu.org [this message] 2021-04-03 8:16 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-98125-4-e6icdT1kRl@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).