public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/98136] [8/9/10/11 Regression] [aarch64] Internal compiler error with large classes and virtual methods since r8-5967-gf5470a77425a54efebfe1732488c40f05ef176d0
Date: Tue, 30 Mar 2021 10:43:12 +0000	[thread overview]
Message-ID: <bug-98136-4-8YUwMt51yz@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98136-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98136

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.org>:

https://gcc.gnu.org/g:48c79f054bf435051c95ee093c45a0f8c9de5b4e

commit r11-7905-g48c79f054bf435051c95ee093c45a0f8c9de5b4e
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Tue Mar 30 11:42:50 2021 +0100

    aarch64: Tweak post-RA handling of CONST_INT moves [PR98136]

    This PR is a regression caused by r8-5967, where we replaced
    a call to aarch64_internal_mov_immediate in aarch64_add_offset
    with a call to aarch64_force_temporary, which in turn uses the
    normal emit_move_insn{,_1} routines.

    The problem is that aarch64_add_offset can be called while
    outputting a thunk, where we require all instructions to be
    valid without splitting.  However, the move expanders were
    not splitting CONST_INT moves themselves.

    I think the right fix is to make the move expanders work
    even in this scenario, rather than require callers to handle
    it as a special case.

    gcc/
            PR target/98136
            * config/aarch64/aarch64.md (mov<mode>): Pass multi-instruction
            CONST_INTs to aarch64_expand_mov_immediate when called after RA.

    gcc/testsuite/
            PR target/98136
            * g++.dg/pr98136.C: New test.

  parent reply	other threads:[~2021-03-30 10:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04  9:33 [Bug c++/98136] New: [aarch64] Internal compiler error with large classes and virtual methods dark141 at gmail dot com
2020-12-04  9:50 ` [Bug target/98136] " marxin at gcc dot gnu.org
2020-12-04  9:52 ` [Bug target/98136] [8/9/10/11 Regression] " pinskia at gcc dot gnu.org
2020-12-04 11:45 ` [Bug target/98136] [8/9/10/11 Regression] [aarch64] Internal compiler error with large classes and virtual methods since r8-5967-gf5470a77425a54efebfe1732488c40f05ef176d0 marxin at gcc dot gnu.org
2020-12-04 11:51 ` rguenth at gcc dot gnu.org
2021-01-05 11:35 ` rsandifo at gcc dot gnu.org
2021-03-30 10:43 ` cvs-commit at gcc dot gnu.org [this message]
2021-03-30 10:49 ` [Bug target/98136] [8/9/10 " rsandifo at gcc dot gnu.org
2021-04-23  9:10 ` cvs-commit at gcc dot gnu.org
2021-04-25 13:51 ` [Bug target/98136] [8/9 " cvs-commit at gcc dot gnu.org
2021-04-26  8:37 ` [Bug target/98136] [8 " cvs-commit at gcc dot gnu.org
2021-04-26  8:38 ` rsandifo at gcc dot gnu.org
2023-04-26  2:22 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98136-4-8YUwMt51yz@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).