public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/98172] Update -mtune=generic for the current Intel and AMD processors
Date: Wed, 20 Jan 2021 23:09:53 +0000	[thread overview]
Message-ID: <bug-98172-4-AN2ynft2Mp@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98172-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98172

--- Comment #8 from H.J. Lu <hjl.tools at gmail dot com> ---
-mtune=generic -mavx2 -mfma generates awful code:

[hjl@gnu-skx-1 tmp]$ cat y.c
#define DATA_ENTRIES 256
extern double *a, *x, *y, *z;
void work()
{
        int i;

        for (i = 0; i < DATA_ENTRIES; ++i)
               z[i] = a[i] * x[i] + y[i];
}

[hjl@gnu-skx-1 tmp]$ gcc -S -O3 y.c -mavx2 -mfma
[hjl@gnu-skx-1 tmp]$ cat y.s
        .file   "y.c"
        .text
        .p2align 4
        .globl  work
        .type   work, @function
work:
.LFB0:
        .cfi_startproc
        movq    z(%rip), %rdx
        movq    x(%rip), %rsi
        movq    a(%rip), %rcx
        movq    y(%rip), %rdi
        leaq    8(%rsi), %r8
        movq    %rdx, %rax
        subq    %r8, %rax
        leaq    8(%rcx), %r9
        cmpq    $16, %rax
        movq    %rdx, %rax
        seta    %r8b
        subq    %r9, %rax
        cmpq    $16, %rax
        seta    %al
        testb   %al, %r8b
        je      .L5
        leaq    8(%rdi), %r8
        movq    %rdx, %rax
        subq    %r8, %rax
        cmpq    $16, %rax
        jbe     .L5
        xorl    %eax, %eax
        .p2align 4,,10
        .p2align 3
.L3:
        vmovupd (%rcx,%rax), %xmm3
        vmovupd (%rsi,%rax), %xmm4
        vinsertf128     $0x1, 16(%rcx,%rax), %ymm3, %ymm0
        vinsertf128     $0x1, 16(%rsi,%rax), %ymm4, %ymm2
        vmovupd (%rdi,%rax), %xmm5
        vinsertf128     $0x1, 16(%rdi,%rax), %ymm5, %ymm1
        vfmadd132pd     %ymm2, %ymm1, %ymm0
        vmovupd %xmm0, (%rdx,%rax)
        vextractf128    $0x1, %ymm0, 16(%rdx,%rax)
        addq    $32, %rax
        cmpq    $2048, %rax
        jne     .L3
        vzeroupper
        ret
.L5:
        xorl    %eax, %eax
        .p2align 4,,10
        .p2align 3
.L2:
        vmovsd  (%rcx,%rax), %xmm0
        vmovsd  (%rdi,%rax), %xmm6
        vfmadd132sd     (%rsi,%rax), %xmm6, %xmm0
        vmovsd  %xmm0, (%rdx,%rax)
        addq    $8, %rax
        cmpq    $2048, %rax
        jne     .L2
        ret
        .cfi_endproc
.LFE0:
        .size   work, .-work
        .ident  "GCC: (GNU) 10.2.1 20210119 (Red Hat 10.2.1-10)"
        .section        .note.GNU-stack,"",@progbits
[hjl@gnu-skx-1 tmp]$ gcc -S -O3 y.c -mavx2 -mfma -mtune=haswell
[hjl@gnu-skx-1 tmp]$ cat y.s
        .file   "y.c"
        .text
        .p2align 4
        .globl  work
        .type   work, @function
work:
.LFB0:
        .cfi_startproc
        movq    z(%rip), %rdx
        movq    x(%rip), %rsi
        movq    a(%rip), %rcx
        movq    y(%rip), %rdi
        leaq    8(%rsi), %r8
        movq    %rdx, %rax
        subq    %r8, %rax
        leaq    8(%rcx), %r9
        cmpq    $16, %rax
        movq    %rdx, %rax
        seta    %r8b
        subq    %r9, %rax
        cmpq    $16, %rax
        seta    %al
        testb   %al, %r8b
        je      .L5
        leaq    8(%rdi), %r8
        movq    %rdx, %rax
        subq    %r8, %rax
        cmpq    $16, %rax
        jbe     .L5
        xorl    %eax, %eax
        .p2align 4,,10
        .p2align 3
.L3:
        vmovupd (%rcx,%rax), %ymm0
        vmovupd (%rdi,%rax), %ymm1
        vfmadd132pd     (%rsi,%rax), %ymm1, %ymm0
        vmovupd %ymm0, (%rdx,%rax)
        addq    $32, %rax
        cmpq    $2048, %rax
        jne     .L3
        vzeroupper
        ret
.L5:
        xorl    %eax, %eax
        .p2align 4,,10
        .p2align 3
.L2:
        vmovsd  (%rcx,%rax), %xmm0
        vmovsd  (%rdi,%rax), %xmm2
        vfmadd132sd     (%rsi,%rax), %xmm2, %xmm0
        vmovsd  %xmm0, (%rdx,%rax)
        addq    $8, %rax
        cmpq    $2048, %rax
        jne     .L2
        ret
        .cfi_endproc
.LFE0:
        .size   work, .-work
        .ident  "GCC: (GNU) 10.2.1 20210119 (Red Hat 10.2.1-10)"
        .section        .note.GNU-stack,"",@progbits
[hjl@gnu-skx-1 tmp]$

  parent reply	other threads:[~2021-01-20 23:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-07 13:01 [Bug target/98172] New: " hjl.tools at gmail dot com
2020-12-07 13:03 ` [Bug target/98172] " hubicka at gcc dot gnu.org
2020-12-07 13:12 ` hjl.tools at gmail dot com
2020-12-07 14:08 ` rguenth at gcc dot gnu.org
2020-12-07 14:08 ` hubicka at ucw dot cz
2020-12-07 14:10 ` hubicka at ucw dot cz
2020-12-07 14:44 ` hjl.tools at gmail dot com
2020-12-07 14:50 ` hjl.tools at gmail dot com
2021-01-20 23:09 ` hjl.tools at gmail dot com [this message]
2021-01-21  1:38 ` crazylht at gmail dot com
2021-01-21  1:55 ` crazylht at gmail dot com
2021-02-05  1:58 ` cvs-commit at gcc dot gnu.org
2021-04-27 11:39 ` jakub at gcc dot gnu.org
2021-07-28  7:05 ` rguenth at gcc dot gnu.org
2022-04-21  7:48 ` rguenth at gcc dot gnu.org
2023-05-29 10:03 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98172-4-AN2ynft2Mp@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).